Piteball
/
android_hardware_qcom_display
mirror of https://github.com/followmsi/android_hardware_qcom_display.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

hwcomposer: Work around overzealous fortify checks 

Storage for six pollfd structs is allocated on the stack in a 2d array.
Subsequently, the address of the first element is passed to poll along
with the same total number of fds.  At this point, the fortify dynamic
checker, considering only one of the dimensions of the array, throws an
error and warns that array is too small.  Since the array is actually
sized appropriately, use a reinterpret_cast to subvert the checker.

Bug: 77323983
Change-Id: Ib88c5a00bc84b3d05be95baf57df5f522a769da4
This commit is contained in:
Tim Kryger 2018-03-30 14:40:39 -07:00
parent 286449a94b
commit 26105d8c60
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
msm8909/libhwcomposer/hwc_vsync.cpp
View File

@ -169,7 +169,8 @@ static void *vsync_loop(void *param)
if (LIKELY(!ctx->vstate.fakevsync)) {
do {
int err = poll(*pfd, (int)(num_displays * num_events), -1);
int err = poll(reinterpret_cast<struct pollfd *>(pfd),
(int)(num_displays * num_events), -1);
if(err > 0) {
for (int dpy = HWC_DISPLAY_PRIMARY; dpy < num_displays; dpy++) {
for(size_t ev = 0; ev < num_events; ev++) {