The libc++ defines this (wrapped in ifndef, like this should have
been), so including a libc++ header and then defining this results in
a werror failure. Define this in common.mk so we can be sure it does
get defined, but also that it gets defined early enough that anyone
defining this in source wrapped with ifndef doesn't get broken.
Test: mma # on angler
Bug: http://b/34740564
Change-Id: Id7d70a6ad5e530390eb8b37e5e618312d1d7e6dc
Hwc_sync is in the hotpath of display
rendering and gets called every ~17ms
during active rerendering.
Reading the property "debug.egl.swapinterval"
on every execution of hwc_sync causes a major
regression where the execution of hwc_sync
is much slower than it can be.
Doing I/O in hotpaths is inacceptable
and can cause an unnecessary constant
I/O load, additionally to the slowdown
in display rendering which was caused
in this case.
As solution, we condition this debugging
feature with "DISPLAY_DEBUG_SWAPINTERVAL",
so it can be enabled when explicitly needed.
Gralloc is not directly affected by the regression,
it was adjusted to match the conditioning
of the swapinterval debugging feature.
The HALs of msm8084,msm8226,msm8909,msm8960 and
msm8994 are affected by the regression and
get patched by this patch. Newer HALs
are not affected.
The stats contained in this patch were
collected using a Nextbit Robin (MSM8992),
which uses the msm8994 HAL.
Test: Manual testing for proper conditioning.
Test: Running full CTS suite without DISPLAY_DEBUG_SWAPINTERVAL set.
Change-Id: If08595d37ac0c1a19edd8d296289a21c9f95512a
Signed-off-by: Alex Naidis <alex.naidis@linux.com>
Add clang support for display modules and fix error identified by clang.
Change-Id: I8e62ce5773c675e50ef9f4c82ae588ff0ec7ff67
Signed-off-by: Sachin Bhayare <sbhayare@qti.qualcomm.com>
am: d44112d
* commit 'd44112dc0a37ec132b2d5440903df89564a20919':
display: Point to new opensource project path.
Change-Id: Iba2a57f0bb2c5819cc1060ed28fcc886478733c0
Clang has more warnings and errors than gcc which prevent the
msm8909 display components from compiling successfully. Disable -Werror
and clang temporarily until these issues can be fixed.
Bug: 27790279
Change-Id: I83fef652d3da81d0740286040b8a942998e9d836
The sanitized kernel headers don't include references to several inline
functions associated with the VENUS_COLOR_FORMAT, causing the build to
break.
To get things building, we remove the VENUS_COLOR_FORMAT flag
altogether.
Bug: 25691995
Change-Id: Iabcc305d7f175a413de1100621835128c804745a
Ben Fennema
Dan Albert
Alex Naidis
Sachin Bhayare
Alain Vongsouvanh
Roopesh Rajashekharaiah Nataraja
Tom Cherry
Sachin Bhayare
Prashant Malani