Commit Graph

227 Commits

Author SHA1 Message Date
Courtney Goeltzenleuchter d1c08b13d3 Fix Buffer Overflow in Vendor Service display.qservice
Bug: 63145942
Test: adb shell vndservice call display.qservice 36 s16 sdlkfjsadlfkjasdf
Change-Id: I3fdf5ccd2bf4ed0fa980883fefdb57eb5fbfeee7
(cherry picked from commit 4050091844)
2018-07-27 18:43:41 +00:00
Gousemoodhin Nadaf 0296371991 hwc2: Night light causes major stuttering.
- Initialize transform matrix with an identity matrix.
- Use matrix when mode map is empty.
- Do not reapply mode if it is the same as before.
- Do not reapply hint if it is the same as before.

Bug: 68721781
Change-Id: Iac6d76ceded65b8527abf0b0f26ffc76479e5db9
2018-05-24 16:04:21 -07:00
Naseer Ahmed 1ff191fed3 hwc2: Skip validation fixes
* Disable skip validation for solid fill during calibration.
* Require validation when the client changes the composition type

Bug: 77925367
CRs-Fixed: 2122072
Change-Id: I9ded200e5c15701f653c73d67c18c41de8278d52
2018-04-18 12:45:46 -07:00
Jiyong Park 9f455f0d35 Explicitly export headers from gralloc.* and gralloc_headers
Publicly visible headers of the lib uses other headers from liblog and
libhardware. Therefore, explicitly export the required headers so that
the client that is using this library doesn't need to add additional
dependency.

Bug: 69526027
Test: mma -j under libgralloc1
Change-Id: I532bc43e0d8ff428008709d95983ec98342017d8
2018-01-26 15:15:44 +09:00
TreeHugger Robot 0e97d16da2 Merge "Make libqservice build with the VNDK." 2018-01-26 00:34:35 +00:00
TreeHugger Robot 1c7691da8f Merge "Make memtrack build with the VNDK." 2018-01-26 00:16:06 +00:00
TreeHugger Robot 8892e88da7 Merge "Import headers for enabling VNDK." 2018-01-26 00:11:33 +00:00
Steven Moreland d162d7f96b Make libqservice build with the VNDK.
When the vndk is enabled (BOARD_VNDK_VERSION=current),
vendor libraries must only link against vendor variants
in the build system. This also means that they receive
restricted sets of headers and that automatic global
headers are restricted.

Test: build libqservice with BOARD_VNDK_VERSION=current
Bug: 69526027
Change-Id: Id98bf5e2ecc6f514f1d4dd9580d25027f36e0d86
2018-01-25 14:25:09 -08:00
Steven Moreland 8be2ccb1ea Make memtrack build with the VNDK.
When the vndk is enabled (BOARD_VNDK_VERSION=current),
vendor libraries must only link against vendor variants
in the build system. This also means that they receive
restricted sets of headers and that automatic global
headers are restricted.

Test: build memtrack with BOARD_VNDK_VERSION=current
Bug: 69526027
Change-Id: Ie3cb9ffb72931fbb0cc816f5158a649e09f7bb43
2018-01-25 14:15:59 -08:00
Steven Moreland c0f68916f8 Make light build with the VNDK.
When the vndk is enabled (BOARD_VNDK_VERSION=current),
vendor libraries must only link against vendor variants
in the build system. This also means that they receive
restricted sets of headers and that automatic global
headers are restricted.

Test: build light with BOARD_VNDK_VERSION=current
Bug: 69526027
Change-Id: I8ad1da8aa2802a93493c877644266995c59f18ab
2018-01-25 14:11:24 -08:00
Steven Moreland 31174f4806 Import headers for enabling VNDK.
These modules don't explicitly declare their
dependence on hardware/gralloc1.h

Bug: 69526027
Test: mma -j BOARD_VNDK_VERSION=current
Change-Id: If9e5636635c7d039d7fa924cb51fa5f838ee6bca
2018-01-25 12:29:25 -08:00
Chih-Hung Hsieh 6fd2d4bb57 Add -Wno-error to compile with global -Werror.
Bug: 66996870
Test: normal builds.
Change-Id: Iee4ac5f95a2013c5eeac1c061889a593caf0ec36
2018-01-04 12:09:30 -08:00
Mark Salyzyn 96a73c98ee msm8998: deprecate cutils/log.h
Replace cutils/log.h with log/log.h.  Fix up header ordering.

Test: compile
Bug: 34250038
Change-Id: Ib9d9f9919e6a220205014c2f720f7b9633e1bc87
2017-12-19 10:00:55 -08:00
Yi Kong eb53b91b46 Merge "Remove unused variable"
am: 02880f6383

Change-Id: I45affa7c1da94e926788e5af99d88a1253531733
2017-12-05 00:38:45 +00:00
Yi Kong 3a1e361a56 Remove unused variable
Discovered by the upcoming compiler update.

Test: build
Change-Id: Ibe04228dfa03b82f7d0f86cf2c4a3bb90dd68792
2017-12-04 14:24:50 -08:00
Steve Pfetsch 86da9224b4 resolve merge conflicts of 5abba5cb to oc-dr1-dev am: 812125f118
am: 0e89ea8021

Change-Id: I672741415f643e3a299abbddaab1ec0a12dc4c1d
2017-10-17 20:36:33 +00:00
Steve Pfetsch 0e89ea8021 resolve merge conflicts of 5abba5cb to oc-dr1-dev
am: 812125f118

Change-Id: Id44d8d0f0594bf53bc2a46b73830b74d61b54332
2017-10-17 20:34:00 +00:00
Steve Pfetsch 812125f118 resolve merge conflicts of 5abba5cb to oc-dr1-dev
Bug: 63662821
Test: I solemnly swear I tested this conflict resolution.
Change-Id: I8f4539b80c542b1212a090a45fbb7b2dfd5ce274
2017-10-17 18:03:14 +00:00
Dan Albert 4a3f1227a9 Add missing includes. am: 726ab4f0c1
am: 4d23cad8bb

Change-Id: Ic2f35fe6eef6e731988f9a6449966af11f1a4761
2017-10-17 08:44:12 +00:00
Dan Albert 726ab4f0c1 Add missing includes.
Test: mma
Bug: None
Change-Id: I945e22b606e0ed3b944ac2bc352b13ed9a73ed7d
(cherry picked from commit 6a8d7abeb4)
2017-10-17 07:58:14 +00:00
Ramkumar Radhakrishnan 7344889023 [DO NOT MERGE] msm8996: libgralloc: Fix adding offset to the mapped base address
Bug: 63662821
CRs-Fixed: 2109325

Change-Id: Ib67ba670753d0f2ce41ca7168de7ab5202103a47
2017-10-11 18:07:23 -07:00
Naseer Ahmed 8480196c50 msm8996: gralloc1: Align buffer size for each layer
Align the per layer buffer size instead of the total size.

Bug: 62299647
Test: Ran multiview test on Pixel XL, verified no visual artifacts
Change-Id: I114fe6b9e0b40ce6cf92fcb32559ed01b94527e4
2017-10-03 12:06:51 -07:00
Naseer Ahmed bbc6f15a63 gralloc1: Locking fixes
* Separate buffer lock and descriptor lock
* Add lock for allocation as we touch the handles_map

Change-Id: I2baf7a65f55b04f1bbbfbf78a19c0e288040fab7
Bug: 64340340
2017-08-28 17:18:05 -07:00
Naseer Ahmed f9b32af057 msm8996: Disable gralloc dump
Bug: 62624942
Change-Id: I7cb03edfdc6ac37579c07d3d5603c33e42cdb72c
2017-08-28 16:14:12 -07:00
Arun Kumar K.R bf533c115a sdm: Handle invalid layers in Dump
Check for invalid layer or layer buffer in dump and handle
gracefully.

Bug: 63113833
Change-Id: I98aaf2b868a98687e715796b3eebb5dabde719bb
2017-08-28 16:06:50 -07:00
Naseer Ahmed d8991a4624 hwc2: cursor fixes
* Treat cursor layers as device layers
* Reject incorrect setCursorPosition calls

Bug: 62992393
Change-Id: Icebc268d1429324f198691cee7aa1737d1a54081
2017-08-23 15:48:43 -07:00
Naseer Ahmed 985b4e311a hwc2: invalidate on format change am: dd6edac0dc
am: 110d13c815

Change-Id: Idff7439d1250c66dc177e5aeb61db4dfb78118f0
2017-06-28 23:19:04 +00:00
Naseer Ahmed 37e38ea681 hwc2: invalidate on format change
am: dd6edac0dc

Change-Id: I26753b9df2b5e37d6745522db4d7e9d6620ace32
2017-06-28 23:14:03 +00:00
Naseer Ahmed 110d13c815 hwc2: invalidate on format change
am: dd6edac0dc

Change-Id: Ia9a0adc02f56caee007422d7cb247b6dfabb743f
2017-06-28 23:14:03 +00:00
Naseer Ahmed dd6edac0dc hwc2: invalidate on format change
Bug: 62999638
Change-Id: I7a59c9f5a104637a7e61af04682f1239b09d4dcf
2017-06-28 10:37:33 -07:00
Naseer Ahmed d9a9a78afb hwc2: Reset layer flags in SetLayerBuffer am: 26aafb60e0
am: 0a0cfb1377

Change-Id: Ib8407b68763d73c7f1bd71fd5ef91c0f2543c62f
2017-06-24 03:30:47 +00:00
Naseer Ahmed af6daaeea5 hwc2: Reset layer flags in SetLayerBuffer
am: 26aafb60e0

Change-Id: I98500527d60c6605047c38f6acdf5257de31d591
2017-06-24 03:28:47 +00:00
Naseer Ahmed 0a0cfb1377 hwc2: Reset layer flags in SetLayerBuffer
am: 26aafb60e0

Change-Id: If2868ac3005314cf74d37c9e5913c10ad66b8402
2017-06-24 03:28:47 +00:00
Naseer Ahmed 26aafb60e0 hwc2: Reset layer flags in SetLayerBuffer
Bug: 36511863
Test: Verified with demo-noExtensions-debug.apk, YouTube
Change-Id: I0e3fcffebfcc41943b0830abcbb5c32249fe3d6d
2017-06-23 18:31:16 -07:00
Naseer Ahmed 6cc49a1b8c msm8996: More checks for skip validate
am: b1c242f15a

Change-Id: Ie9930d1ed93f4abb8e173634e279624377bbf143
2017-06-22 22:10:21 +00:00
Naseer Ahmed d813484dc1 msm8996: More checks for skip validate
am: b1c242f15a

Change-Id: If41d07821f5bb25ec25709aa8842cd1f2d767d6f
2017-06-22 22:10:21 +00:00
Naseer Ahmed b1c242f15a msm8996: More checks for skip validate
* Require validate on power transitions
* Reset retire fence after programming the client with it.

Bug: 37474580
Bug: 62897896
Test: manual
Change-Id: I8fa48cc872edf92811b9d3f56e4787f485c42c10
2017-06-22 14:58:10 -07:00
Naseer Ahmed 867f69008c sdm: hwc2: Support Skip validate feature
am: 503cff39e9

Change-Id: I8479693cb60b7b3e3e05a6e552439d8f1a881fc7
2017-06-22 05:58:10 +00:00
Naseer Ahmed ebb1024364 sdm: hwc2: Support Skip validate feature
am: 503cff39e9

Change-Id: I6ae05026d332854f4d51a44bf5316b14aa6454ce
2017-06-22 05:57:20 +00:00
Naseer Ahmed 503cff39e9 sdm: hwc2: Support Skip validate feature
1. SF skips ValidateDisplay call, when the layer geometry attributes
   have not changed for any of the layer, as compared to last frame.
2. In case of Surface Damage update on a layer, SDM needs a Validate
   call to program SDE driver for Partial Update feature.
3. SDM needs Validate call to enter in safe Mode for use cases like
   Idle/Thermal fallback, HDMI and Virtual Connect/Disconnet, etc.
4. Set HWC2_CAPABILITY_SKIP_VALIDATE cap in GetCapabilities api.

b/37474580
b/62806392

Test: marlin, ryu

Change-Id: I68f0db3af16afa4ad4eb789cd1f6b12caf6381e4
Acked-by: Sushil Chauhan <sushilchauhan@codeaurora.org>
Signed-off-by: Iliyan Malchev <malchev@google.com>
2017-06-22 04:47:45 +00:00
Naseer Ahmed d6751d55a6 gralloc1: Support GRALLOC1_CAPABILITY_RELEASE_IMPLY_DELETE
v2: Handle buffers allocated outside gralloc with flag
PRIV_FLAGS_CLIENT_ALLOCATED.

CRs-Fixed: 2041607
Bug: 36355756
Change-Id: Icb0c4b724f7bf7097812f6306fb0b9a56bb790a9
2017-06-16 01:50:18 +00:00
Naseer Ahmed 2aeb8fd42c msm8996: hwc2: Cache dataspace am: 1cbdfaa988
am: e43dde050e

Change-Id: I7ea7b03077ca8074444e1638d21eba9814e4b0ba
2017-05-31 21:35:06 +00:00
Naseer Ahmed e43dde050e msm8996: hwc2: Cache dataspace
am: 1cbdfaa988

Change-Id: I48122f3ae7eb1d28504d192a62b13d9609f965f4
2017-05-31 21:24:39 +00:00
Naseer Ahmed 1cbdfaa988 msm8996: hwc2: Cache dataspace
Avoid setting the geometry changed flag when the dataspace is the
same.

Bug: 38396128
Test: Manually checked systraces on Pixel
Change-Id: I80561ddf43356514616d1132a293b43a6138541d
2017-05-30 16:01:21 -07:00
Naseer Ahmed d60aa476c2 hwc2: Remove power manager dependency
am: a4094dfb63

Change-Id: I641c472735fde04c346a061842172d75622ca2e8
2017-05-26 18:52:27 +00:00
Naseer Ahmed a4094dfb63 hwc2: Remove power manager dependency
Bug: 37471448
Test: sailfish boots
Change-Id: I1e4777a8f07f2def4abd9b28f96c10bb0ccb1f7f
Merged-In: Ibcddc7fc8f04b530fc7d96080d4d6c2025e76db7
2017-05-25 15:17:15 +08:00
Naseer Ahmed 8ad51bbf67 hwc2: Remove power manager dependency
Bug: 37471448
Test: sailfish boots
Change-Id: Ibcddc7fc8f04b530fc7d96080d4d6c2025e76db7
2017-05-18 15:07:31 +08:00
Yi Kong 22b24c4bc4 Merge "Add const specifier to SortLayersByZ comparator" am: 42ea1de680 am: 34773c848e am: f3e8e72aa2
am: d63ab1f229

Change-Id: Ib0316d7e7780c97922ee6058e3b03c4b3c516782
2017-05-16 01:55:29 +00:00
Yi Kong d63ab1f229 Merge "Add const specifier to SortLayersByZ comparator" am: 42ea1de680 am: 34773c848e
am: f3e8e72aa2

Change-Id: Ic7479cb3fefff4affba52a736959d35b1771f90e
2017-05-16 00:00:26 +00:00
Naseer Ahmed 82ba39de29 gralloc1: Allocate sensor data from ADSP heap am: 851178be9b
am: 46378e748f

Change-Id: I02b3de30db7569e68b27ad5b57feac448615b68e
2017-05-15 09:39:04 +00:00