From 26ec0b6b5d02750bdd329fbff3e809234b4d85fa Mon Sep 17 00:00:00 2001 From: Rohit Vaswani Date: Tue, 6 Dec 2011 20:03:07 -0800 Subject: [PATCH] checkpatch: Add check for gpiomux usage in msm board files MSM has a board-*-gpiomux file where all the gpiomux configs reside. Warn if a non gpiomux board file tries to add gpiomux configs. The camera board file is an exception to this rule. Change-Id: Ibab190dcbd7ea78e7ca150142c68c5ae881e4e06 Signed-off-by: Rohit Vaswani (cherry picked from commit 60d78bb9809e7d4d1c3dc1425cbfd9e649e87c1c) --- scripts/checkpatch.pl | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 13571b9c2d65..7f1ff2b9ac53 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3288,6 +3288,13 @@ sub process { $herecurr); } +# MSM - check if a non board-gpiomux file has any gpiomux declarations + if ($realfile =~ /\/mach-msm\/board-[0-9]+/ && + $realfile !~ /camera/ && $realfile !~ /gpiomux/ && + $line =~ /\s*struct msm_gpiomux_config\s*/ ) { + WARN("Non gpiomux board file cannot have a gpiomux config declarations. Please declare gpiomux configs in board-*-gpiomux.c file.\n" . $herecurr); + } + # unbounded string functions are overflow risks my %str_fns = ( "sprintf" => "snprintf",