mirror of
https://github.com/followmsi/android_kernel_google_msm.git
synced 2024-11-06 23:17:41 +00:00
Merge branch 'drm-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/airlied/drm-2.6
* 'drm-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/airlied/drm-2.6: drm/radeon/kms: pll tweaks for r7xx drm/nouveau: fix allocation of notifier object drm/nouveau: fix notifier memory corruption bug drm/nouveau: fix pinning of notifier block drm/nouveau: populate ttm_alloced with false, when it's not drm/nouveau: fix nv30 pcie boards drm/nouveau: split ramin_lock into two locks, one hardirq safe drm/radeon/kms: adjust evergreen display watermark setup drm/radeon/kms: add connectors even if i2c fails drm/radeon/kms: fix bad shift in atom iio table parser
This commit is contained in:
commit
2f666bcf75
16 changed files with 102 additions and 92 deletions
|
@ -83,7 +83,7 @@ nouveau_dma_init(struct nouveau_channel *chan)
|
|||
return ret;
|
||||
|
||||
/* NV_MEMORY_TO_MEMORY_FORMAT requires a notifier object */
|
||||
ret = nouveau_notifier_alloc(chan, NvNotify0, 32, 0xfd0, 0x1000,
|
||||
ret = nouveau_notifier_alloc(chan, NvNotify0, 32, 0xfe0, 0x1000,
|
||||
&chan->m2mf_ntfy);
|
||||
if (ret)
|
||||
return ret;
|
||||
|
|
|
@ -682,6 +682,9 @@ struct drm_nouveau_private {
|
|||
/* For PFIFO and PGRAPH. */
|
||||
spinlock_t context_switch_lock;
|
||||
|
||||
/* VM/PRAMIN flush, legacy PRAMIN aperture */
|
||||
spinlock_t vm_lock;
|
||||
|
||||
/* RAMIN configuration, RAMFC, RAMHT and RAMRO offsets */
|
||||
struct nouveau_ramht *ramht;
|
||||
struct nouveau_gpuobj *ramfc;
|
||||
|
|
|
@ -181,13 +181,13 @@ nouveau_fbcon_sync(struct fb_info *info)
|
|||
OUT_RING (chan, 0);
|
||||
}
|
||||
|
||||
nouveau_bo_wr32(chan->notifier_bo, chan->m2mf_ntfy + 3, 0xffffffff);
|
||||
nouveau_bo_wr32(chan->notifier_bo, chan->m2mf_ntfy/4 + 3, 0xffffffff);
|
||||
FIRE_RING(chan);
|
||||
mutex_unlock(&chan->mutex);
|
||||
|
||||
ret = -EBUSY;
|
||||
for (i = 0; i < 100000; i++) {
|
||||
if (!nouveau_bo_rd32(chan->notifier_bo, chan->m2mf_ntfy + 3)) {
|
||||
if (!nouveau_bo_rd32(chan->notifier_bo, chan->m2mf_ntfy/4 + 3)) {
|
||||
ret = 0;
|
||||
break;
|
||||
}
|
||||
|
|
|
@ -398,7 +398,7 @@ nouveau_mem_vram_init(struct drm_device *dev)
|
|||
dma_bits = 40;
|
||||
} else
|
||||
if (drm_pci_device_is_pcie(dev) &&
|
||||
dev_priv->chipset != 0x40 &&
|
||||
dev_priv->chipset > 0x40 &&
|
||||
dev_priv->chipset != 0x45) {
|
||||
if (pci_dma_supported(dev->pdev, DMA_BIT_MASK(39)))
|
||||
dma_bits = 39;
|
||||
|
|
|
@ -35,19 +35,22 @@ nouveau_notifier_init_channel(struct nouveau_channel *chan)
|
|||
{
|
||||
struct drm_device *dev = chan->dev;
|
||||
struct nouveau_bo *ntfy = NULL;
|
||||
uint32_t flags;
|
||||
uint32_t flags, ttmpl;
|
||||
int ret;
|
||||
|
||||
if (nouveau_vram_notify)
|
||||
if (nouveau_vram_notify) {
|
||||
flags = NOUVEAU_GEM_DOMAIN_VRAM;
|
||||
else
|
||||
ttmpl = TTM_PL_FLAG_VRAM;
|
||||
} else {
|
||||
flags = NOUVEAU_GEM_DOMAIN_GART;
|
||||
ttmpl = TTM_PL_FLAG_TT;
|
||||
}
|
||||
|
||||
ret = nouveau_gem_new(dev, NULL, PAGE_SIZE, 0, flags, 0, 0, &ntfy);
|
||||
if (ret)
|
||||
return ret;
|
||||
|
||||
ret = nouveau_bo_pin(ntfy, flags);
|
||||
ret = nouveau_bo_pin(ntfy, ttmpl);
|
||||
if (ret)
|
||||
goto out_err;
|
||||
|
||||
|
|
|
@ -1039,19 +1039,20 @@ nv_ro32(struct nouveau_gpuobj *gpuobj, u32 offset)
|
|||
{
|
||||
struct drm_nouveau_private *dev_priv = gpuobj->dev->dev_private;
|
||||
struct drm_device *dev = gpuobj->dev;
|
||||
unsigned long flags;
|
||||
|
||||
if (gpuobj->pinst == ~0 || !dev_priv->ramin_available) {
|
||||
u64 ptr = gpuobj->vinst + offset;
|
||||
u32 base = ptr >> 16;
|
||||
u32 val;
|
||||
|
||||
spin_lock(&dev_priv->ramin_lock);
|
||||
spin_lock_irqsave(&dev_priv->vm_lock, flags);
|
||||
if (dev_priv->ramin_base != base) {
|
||||
dev_priv->ramin_base = base;
|
||||
nv_wr32(dev, 0x001700, dev_priv->ramin_base);
|
||||
}
|
||||
val = nv_rd32(dev, 0x700000 + (ptr & 0xffff));
|
||||
spin_unlock(&dev_priv->ramin_lock);
|
||||
spin_unlock_irqrestore(&dev_priv->vm_lock, flags);
|
||||
return val;
|
||||
}
|
||||
|
||||
|
@ -1063,18 +1064,19 @@ nv_wo32(struct nouveau_gpuobj *gpuobj, u32 offset, u32 val)
|
|||
{
|
||||
struct drm_nouveau_private *dev_priv = gpuobj->dev->dev_private;
|
||||
struct drm_device *dev = gpuobj->dev;
|
||||
unsigned long flags;
|
||||
|
||||
if (gpuobj->pinst == ~0 || !dev_priv->ramin_available) {
|
||||
u64 ptr = gpuobj->vinst + offset;
|
||||
u32 base = ptr >> 16;
|
||||
|
||||
spin_lock(&dev_priv->ramin_lock);
|
||||
spin_lock_irqsave(&dev_priv->vm_lock, flags);
|
||||
if (dev_priv->ramin_base != base) {
|
||||
dev_priv->ramin_base = base;
|
||||
nv_wr32(dev, 0x001700, dev_priv->ramin_base);
|
||||
}
|
||||
nv_wr32(dev, 0x700000 + (ptr & 0xffff), val);
|
||||
spin_unlock(&dev_priv->ramin_lock);
|
||||
spin_unlock_irqrestore(&dev_priv->vm_lock, flags);
|
||||
return;
|
||||
}
|
||||
|
||||
|
|
|
@ -55,6 +55,7 @@ nouveau_sgdma_populate(struct ttm_backend *be, unsigned long num_pages,
|
|||
be->func->clear(be);
|
||||
return -EFAULT;
|
||||
}
|
||||
nvbe->ttm_alloced[nvbe->nr_pages] = false;
|
||||
}
|
||||
|
||||
nvbe->nr_pages++;
|
||||
|
@ -427,7 +428,7 @@ nouveau_sgdma_init(struct drm_device *dev)
|
|||
u32 aper_size, align;
|
||||
int ret;
|
||||
|
||||
if (dev_priv->card_type >= NV_50 || drm_pci_device_is_pcie(dev))
|
||||
if (dev_priv->card_type >= NV_40 && drm_pci_device_is_pcie(dev))
|
||||
aper_size = 512 * 1024 * 1024;
|
||||
else
|
||||
aper_size = 64 * 1024 * 1024;
|
||||
|
@ -457,7 +458,7 @@ nouveau_sgdma_init(struct drm_device *dev)
|
|||
dev_priv->gart_info.func = &nv50_sgdma_backend;
|
||||
} else
|
||||
if (drm_pci_device_is_pcie(dev) &&
|
||||
dev_priv->chipset != 0x40 && dev_priv->chipset != 0x45) {
|
||||
dev_priv->chipset > 0x40 && dev_priv->chipset != 0x45) {
|
||||
if (nv44_graph_class(dev)) {
|
||||
dev_priv->gart_info.func = &nv44_sgdma_backend;
|
||||
align = 512 * 1024;
|
||||
|
|
|
@ -608,6 +608,7 @@ nouveau_card_init(struct drm_device *dev)
|
|||
spin_lock_init(&dev_priv->channels.lock);
|
||||
spin_lock_init(&dev_priv->tile.lock);
|
||||
spin_lock_init(&dev_priv->context_switch_lock);
|
||||
spin_lock_init(&dev_priv->vm_lock);
|
||||
|
||||
/* Make the CRTCs and I2C buses accessible */
|
||||
ret = engine->display.early_init(dev);
|
||||
|
|
|
@ -404,23 +404,25 @@ void
|
|||
nv50_instmem_flush(struct drm_device *dev)
|
||||
{
|
||||
struct drm_nouveau_private *dev_priv = dev->dev_private;
|
||||
unsigned long flags;
|
||||
|
||||
spin_lock(&dev_priv->ramin_lock);
|
||||
spin_lock_irqsave(&dev_priv->vm_lock, flags);
|
||||
nv_wr32(dev, 0x00330c, 0x00000001);
|
||||
if (!nv_wait(dev, 0x00330c, 0x00000002, 0x00000000))
|
||||
NV_ERROR(dev, "PRAMIN flush timeout\n");
|
||||
spin_unlock(&dev_priv->ramin_lock);
|
||||
spin_unlock_irqrestore(&dev_priv->vm_lock, flags);
|
||||
}
|
||||
|
||||
void
|
||||
nv84_instmem_flush(struct drm_device *dev)
|
||||
{
|
||||
struct drm_nouveau_private *dev_priv = dev->dev_private;
|
||||
unsigned long flags;
|
||||
|
||||
spin_lock(&dev_priv->ramin_lock);
|
||||
spin_lock_irqsave(&dev_priv->vm_lock, flags);
|
||||
nv_wr32(dev, 0x070000, 0x00000001);
|
||||
if (!nv_wait(dev, 0x070000, 0x00000002, 0x00000000))
|
||||
NV_ERROR(dev, "PRAMIN flush timeout\n");
|
||||
spin_unlock(&dev_priv->ramin_lock);
|
||||
spin_unlock_irqrestore(&dev_priv->vm_lock, flags);
|
||||
}
|
||||
|
||||
|
|
|
@ -174,10 +174,11 @@ void
|
|||
nv50_vm_flush_engine(struct drm_device *dev, int engine)
|
||||
{
|
||||
struct drm_nouveau_private *dev_priv = dev->dev_private;
|
||||
unsigned long flags;
|
||||
|
||||
spin_lock(&dev_priv->ramin_lock);
|
||||
spin_lock_irqsave(&dev_priv->vm_lock, flags);
|
||||
nv_wr32(dev, 0x100c80, (engine << 16) | 1);
|
||||
if (!nv_wait(dev, 0x100c80, 0x00000001, 0x00000000))
|
||||
NV_ERROR(dev, "vm flush timeout: engine %d\n", engine);
|
||||
spin_unlock(&dev_priv->ramin_lock);
|
||||
spin_unlock_irqrestore(&dev_priv->vm_lock, flags);
|
||||
}
|
||||
|
|
|
@ -104,11 +104,12 @@ nvc0_vm_flush(struct nouveau_vm *vm)
|
|||
struct nouveau_instmem_engine *pinstmem = &dev_priv->engine.instmem;
|
||||
struct drm_device *dev = vm->dev;
|
||||
struct nouveau_vm_pgd *vpgd;
|
||||
unsigned long flags;
|
||||
u32 engine = (dev_priv->chan_vm == vm) ? 1 : 5;
|
||||
|
||||
pinstmem->flush(vm->dev);
|
||||
|
||||
spin_lock(&dev_priv->ramin_lock);
|
||||
spin_lock_irqsave(&dev_priv->vm_lock, flags);
|
||||
list_for_each_entry(vpgd, &vm->pgd_list, head) {
|
||||
/* looks like maybe a "free flush slots" counter, the
|
||||
* faster you write to 0x100cbc to more it decreases
|
||||
|
@ -125,5 +126,5 @@ nvc0_vm_flush(struct nouveau_vm *vm)
|
|||
nv_rd32(dev, 0x100c80), engine);
|
||||
}
|
||||
}
|
||||
spin_unlock(&dev_priv->ramin_lock);
|
||||
spin_unlock_irqrestore(&dev_priv->vm_lock, flags);
|
||||
}
|
||||
|
|
|
@ -135,7 +135,7 @@ static uint32_t atom_iio_execute(struct atom_context *ctx, int base,
|
|||
case ATOM_IIO_MOVE_INDEX:
|
||||
temp &=
|
||||
~((0xFFFFFFFF >> (32 - CU8(base + 1))) <<
|
||||
CU8(base + 2));
|
||||
CU8(base + 3));
|
||||
temp |=
|
||||
((index >> CU8(base + 2)) &
|
||||
(0xFFFFFFFF >> (32 - CU8(base + 1)))) << CU8(base +
|
||||
|
@ -145,7 +145,7 @@ static uint32_t atom_iio_execute(struct atom_context *ctx, int base,
|
|||
case ATOM_IIO_MOVE_DATA:
|
||||
temp &=
|
||||
~((0xFFFFFFFF >> (32 - CU8(base + 1))) <<
|
||||
CU8(base + 2));
|
||||
CU8(base + 3));
|
||||
temp |=
|
||||
((data >> CU8(base + 2)) &
|
||||
(0xFFFFFFFF >> (32 - CU8(base + 1)))) << CU8(base +
|
||||
|
@ -155,7 +155,7 @@ static uint32_t atom_iio_execute(struct atom_context *ctx, int base,
|
|||
case ATOM_IIO_MOVE_ATTR:
|
||||
temp &=
|
||||
~((0xFFFFFFFF >> (32 - CU8(base + 1))) <<
|
||||
CU8(base + 2));
|
||||
CU8(base + 3));
|
||||
temp |=
|
||||
((ctx->
|
||||
io_attr >> CU8(base + 2)) & (0xFFFFFFFF >> (32 -
|
||||
|
|
|
@ -532,10 +532,7 @@ static u32 atombios_adjust_pll(struct drm_crtc *crtc,
|
|||
else
|
||||
pll->flags |= RADEON_PLL_PREFER_LOW_REF_DIV;
|
||||
|
||||
if ((rdev->family == CHIP_R600) ||
|
||||
(rdev->family == CHIP_RV610) ||
|
||||
(rdev->family == CHIP_RV630) ||
|
||||
(rdev->family == CHIP_RV670))
|
||||
if (rdev->family < CHIP_RV770)
|
||||
pll->flags |= RADEON_PLL_PREFER_MINM_OVER_MAXP;
|
||||
} else {
|
||||
pll->flags |= RADEON_PLL_LEGACY;
|
||||
|
@ -565,7 +562,6 @@ static u32 atombios_adjust_pll(struct drm_crtc *crtc,
|
|||
if (radeon_encoder->devices & (ATOM_DEVICE_LCD_SUPPORT)) {
|
||||
if (ss_enabled) {
|
||||
if (ss->refdiv) {
|
||||
pll->flags |= RADEON_PLL_PREFER_MINM_OVER_MAXP;
|
||||
pll->flags |= RADEON_PLL_USE_REF_DIV;
|
||||
pll->reference_div = ss->refdiv;
|
||||
if (ASIC_IS_AVIVO(rdev))
|
||||
|
|
|
@ -353,7 +353,7 @@ static u32 evergreen_line_buffer_adjust(struct radeon_device *rdev,
|
|||
struct drm_display_mode *mode,
|
||||
struct drm_display_mode *other_mode)
|
||||
{
|
||||
u32 tmp = 0;
|
||||
u32 tmp;
|
||||
/*
|
||||
* Line Buffer Setup
|
||||
* There are 3 line buffers, each one shared by 2 display controllers.
|
||||
|
@ -363,64 +363,63 @@ static u32 evergreen_line_buffer_adjust(struct radeon_device *rdev,
|
|||
* first display controller
|
||||
* 0 - first half of lb (3840 * 2)
|
||||
* 1 - first 3/4 of lb (5760 * 2)
|
||||
* 2 - whole lb (7680 * 2)
|
||||
* 2 - whole lb (7680 * 2), other crtc must be disabled
|
||||
* 3 - first 1/4 of lb (1920 * 2)
|
||||
* second display controller
|
||||
* 4 - second half of lb (3840 * 2)
|
||||
* 5 - second 3/4 of lb (5760 * 2)
|
||||
* 6 - whole lb (7680 * 2)
|
||||
* 6 - whole lb (7680 * 2), other crtc must be disabled
|
||||
* 7 - last 1/4 of lb (1920 * 2)
|
||||
*/
|
||||
if (mode && other_mode) {
|
||||
if (mode->hdisplay > other_mode->hdisplay) {
|
||||
if (mode->hdisplay > 2560)
|
||||
tmp = 1; /* 3/4 */
|
||||
else
|
||||
tmp = 0; /* 1/2 */
|
||||
} else if (other_mode->hdisplay > mode->hdisplay) {
|
||||
if (other_mode->hdisplay > 2560)
|
||||
tmp = 3; /* 1/4 */
|
||||
else
|
||||
tmp = 0; /* 1/2 */
|
||||
} else
|
||||
/* this can get tricky if we have two large displays on a paired group
|
||||
* of crtcs. Ideally for multiple large displays we'd assign them to
|
||||
* non-linked crtcs for maximum line buffer allocation.
|
||||
*/
|
||||
if (radeon_crtc->base.enabled && mode) {
|
||||
if (other_mode)
|
||||
tmp = 0; /* 1/2 */
|
||||
} else if (mode)
|
||||
tmp = 2; /* whole */
|
||||
else if (other_mode)
|
||||
tmp = 3; /* 1/4 */
|
||||
else
|
||||
tmp = 2; /* whole */
|
||||
} else
|
||||
tmp = 0;
|
||||
|
||||
/* second controller of the pair uses second half of the lb */
|
||||
if (radeon_crtc->crtc_id % 2)
|
||||
tmp += 4;
|
||||
WREG32(DC_LB_MEMORY_SPLIT + radeon_crtc->crtc_offset, tmp);
|
||||
|
||||
switch (tmp) {
|
||||
case 0:
|
||||
case 4:
|
||||
default:
|
||||
if (ASIC_IS_DCE5(rdev))
|
||||
return 4096 * 2;
|
||||
else
|
||||
return 3840 * 2;
|
||||
case 1:
|
||||
case 5:
|
||||
if (ASIC_IS_DCE5(rdev))
|
||||
return 6144 * 2;
|
||||
else
|
||||
return 5760 * 2;
|
||||
case 2:
|
||||
case 6:
|
||||
if (ASIC_IS_DCE5(rdev))
|
||||
return 8192 * 2;
|
||||
else
|
||||
return 7680 * 2;
|
||||
case 3:
|
||||
case 7:
|
||||
if (ASIC_IS_DCE5(rdev))
|
||||
return 2048 * 2;
|
||||
else
|
||||
return 1920 * 2;
|
||||
if (radeon_crtc->base.enabled && mode) {
|
||||
switch (tmp) {
|
||||
case 0:
|
||||
case 4:
|
||||
default:
|
||||
if (ASIC_IS_DCE5(rdev))
|
||||
return 4096 * 2;
|
||||
else
|
||||
return 3840 * 2;
|
||||
case 1:
|
||||
case 5:
|
||||
if (ASIC_IS_DCE5(rdev))
|
||||
return 6144 * 2;
|
||||
else
|
||||
return 5760 * 2;
|
||||
case 2:
|
||||
case 6:
|
||||
if (ASIC_IS_DCE5(rdev))
|
||||
return 8192 * 2;
|
||||
else
|
||||
return 7680 * 2;
|
||||
case 3:
|
||||
case 7:
|
||||
if (ASIC_IS_DCE5(rdev))
|
||||
return 2048 * 2;
|
||||
else
|
||||
return 1920 * 2;
|
||||
}
|
||||
}
|
||||
|
||||
/* controller not enabled, so no lb used */
|
||||
return 0;
|
||||
}
|
||||
|
||||
static u32 evergreen_get_number_of_dram_channels(struct radeon_device *rdev)
|
||||
|
|
|
@ -1199,7 +1199,7 @@ radeon_add_atom_connector(struct drm_device *dev,
|
|||
if (router->ddc_valid || router->cd_valid) {
|
||||
radeon_connector->router_bus = radeon_i2c_lookup(rdev, &router->i2c_info);
|
||||
if (!radeon_connector->router_bus)
|
||||
goto failed;
|
||||
DRM_ERROR("Failed to assign router i2c bus! Check dmesg for i2c errors.\n");
|
||||
}
|
||||
switch (connector_type) {
|
||||
case DRM_MODE_CONNECTOR_VGA:
|
||||
|
@ -1208,7 +1208,7 @@ radeon_add_atom_connector(struct drm_device *dev,
|
|||
if (i2c_bus->valid) {
|
||||
radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
|
||||
if (!radeon_connector->ddc_bus)
|
||||
goto failed;
|
||||
DRM_ERROR("VGA: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
|
||||
}
|
||||
radeon_connector->dac_load_detect = true;
|
||||
drm_connector_attach_property(&radeon_connector->base,
|
||||
|
@ -1226,7 +1226,7 @@ radeon_add_atom_connector(struct drm_device *dev,
|
|||
if (i2c_bus->valid) {
|
||||
radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
|
||||
if (!radeon_connector->ddc_bus)
|
||||
goto failed;
|
||||
DRM_ERROR("DVIA: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
|
||||
}
|
||||
radeon_connector->dac_load_detect = true;
|
||||
drm_connector_attach_property(&radeon_connector->base,
|
||||
|
@ -1249,7 +1249,7 @@ radeon_add_atom_connector(struct drm_device *dev,
|
|||
if (i2c_bus->valid) {
|
||||
radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
|
||||
if (!radeon_connector->ddc_bus)
|
||||
goto failed;
|
||||
DRM_ERROR("DVI: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
|
||||
}
|
||||
subpixel_order = SubPixelHorizontalRGB;
|
||||
drm_connector_attach_property(&radeon_connector->base,
|
||||
|
@ -1290,7 +1290,7 @@ radeon_add_atom_connector(struct drm_device *dev,
|
|||
if (i2c_bus->valid) {
|
||||
radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
|
||||
if (!radeon_connector->ddc_bus)
|
||||
goto failed;
|
||||
DRM_ERROR("HDMI: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
|
||||
}
|
||||
drm_connector_attach_property(&radeon_connector->base,
|
||||
rdev->mode_info.coherent_mode_property,
|
||||
|
@ -1329,10 +1329,10 @@ radeon_add_atom_connector(struct drm_device *dev,
|
|||
else
|
||||
radeon_dig_connector->dp_i2c_bus = radeon_i2c_create_dp(dev, i2c_bus, "DP-auxch");
|
||||
if (!radeon_dig_connector->dp_i2c_bus)
|
||||
goto failed;
|
||||
DRM_ERROR("DP: Failed to assign dp ddc bus! Check dmesg for i2c errors.\n");
|
||||
radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
|
||||
if (!radeon_connector->ddc_bus)
|
||||
goto failed;
|
||||
DRM_ERROR("DP: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
|
||||
}
|
||||
subpixel_order = SubPixelHorizontalRGB;
|
||||
drm_connector_attach_property(&radeon_connector->base,
|
||||
|
@ -1381,7 +1381,7 @@ radeon_add_atom_connector(struct drm_device *dev,
|
|||
if (i2c_bus->valid) {
|
||||
radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
|
||||
if (!radeon_connector->ddc_bus)
|
||||
goto failed;
|
||||
DRM_ERROR("LVDS: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
|
||||
}
|
||||
drm_connector_attach_property(&radeon_connector->base,
|
||||
dev->mode_config.scaling_mode_property,
|
||||
|
@ -1457,7 +1457,7 @@ radeon_add_legacy_connector(struct drm_device *dev,
|
|||
if (i2c_bus->valid) {
|
||||
radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
|
||||
if (!radeon_connector->ddc_bus)
|
||||
goto failed;
|
||||
DRM_ERROR("VGA: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
|
||||
}
|
||||
radeon_connector->dac_load_detect = true;
|
||||
drm_connector_attach_property(&radeon_connector->base,
|
||||
|
@ -1475,7 +1475,7 @@ radeon_add_legacy_connector(struct drm_device *dev,
|
|||
if (i2c_bus->valid) {
|
||||
radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
|
||||
if (!radeon_connector->ddc_bus)
|
||||
goto failed;
|
||||
DRM_ERROR("DVIA: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
|
||||
}
|
||||
radeon_connector->dac_load_detect = true;
|
||||
drm_connector_attach_property(&radeon_connector->base,
|
||||
|
@ -1493,7 +1493,7 @@ radeon_add_legacy_connector(struct drm_device *dev,
|
|||
if (i2c_bus->valid) {
|
||||
radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
|
||||
if (!radeon_connector->ddc_bus)
|
||||
goto failed;
|
||||
DRM_ERROR("DVI: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
|
||||
}
|
||||
if (connector_type == DRM_MODE_CONNECTOR_DVII) {
|
||||
radeon_connector->dac_load_detect = true;
|
||||
|
@ -1538,7 +1538,7 @@ radeon_add_legacy_connector(struct drm_device *dev,
|
|||
if (i2c_bus->valid) {
|
||||
radeon_connector->ddc_bus = radeon_i2c_lookup(rdev, i2c_bus);
|
||||
if (!radeon_connector->ddc_bus)
|
||||
goto failed;
|
||||
DRM_ERROR("LVDS: Failed to assign ddc bus! Check dmesg for i2c errors.\n");
|
||||
}
|
||||
drm_connector_attach_property(&radeon_connector->base,
|
||||
dev->mode_config.scaling_mode_property,
|
||||
|
@ -1567,9 +1567,4 @@ radeon_add_legacy_connector(struct drm_device *dev,
|
|||
radeon_legacy_backlight_init(radeon_encoder, connector);
|
||||
}
|
||||
}
|
||||
return;
|
||||
|
||||
failed:
|
||||
drm_connector_cleanup(connector);
|
||||
kfree(connector);
|
||||
}
|
||||
|
|
|
@ -1096,6 +1096,9 @@ void radeon_router_select_ddc_port(struct radeon_connector *radeon_connector)
|
|||
if (!radeon_connector->router.ddc_valid)
|
||||
return;
|
||||
|
||||
if (!radeon_connector->router_bus)
|
||||
return;
|
||||
|
||||
radeon_i2c_get_byte(radeon_connector->router_bus,
|
||||
radeon_connector->router.i2c_addr,
|
||||
0x3, &val);
|
||||
|
@ -1121,6 +1124,9 @@ void radeon_router_select_cd_port(struct radeon_connector *radeon_connector)
|
|||
if (!radeon_connector->router.cd_valid)
|
||||
return;
|
||||
|
||||
if (!radeon_connector->router_bus)
|
||||
return;
|
||||
|
||||
radeon_i2c_get_byte(radeon_connector->router_bus,
|
||||
radeon_connector->router.i2c_addr,
|
||||
0x3, &val);
|
||||
|
|
Loading…
Reference in a new issue