mirror of
https://github.com/followmsi/android_kernel_google_msm.git
synced 2024-11-06 23:17:41 +00:00
workqueue: add WARN_ON_ONCE() on CPU number to wq_worker_waking_up()
Recently, workqueue code has gone through some changes and we found some bugs related to concurrency management operations happening on the wrong CPU. When a worker is concurrency managed (!WORKER_NOT_RUNNIG), it should be bound to its associated cpu and woken up to that cpu. Add WARN_ON_ONCE() to verify this. Signed-off-by: Joonsoo Kim <js1304@gmail.com> Signed-off-by: Tejun Heo <tj@kernel.org>
This commit is contained in:
parent
999767beb1
commit
3657600040
1 changed files with 3 additions and 1 deletions
|
@ -739,8 +739,10 @@ void wq_worker_waking_up(struct task_struct *task, unsigned int cpu)
|
||||||
{
|
{
|
||||||
struct worker *worker = kthread_data(task);
|
struct worker *worker = kthread_data(task);
|
||||||
|
|
||||||
if (!(worker->flags & WORKER_NOT_RUNNING))
|
if (!(worker->flags & WORKER_NOT_RUNNING)) {
|
||||||
|
WARN_ON_ONCE(worker->pool->gcwq->cpu != cpu);
|
||||||
atomic_inc(get_pool_nr_running(worker->pool));
|
atomic_inc(get_pool_nr_running(worker->pool));
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
|
Loading…
Reference in a new issue