Piteball/android_kernel_google_msm
1
0
Fork 0
mirror of https://github.com/followmsi/android_kernel_google_msm.git synced 2024-11-06 23:17:41 +00:00
Code Issues Projects Releases Wiki Activity

Revert "[PATCH] LOG2: Alter get_order() so that it can make use of ilog2() on a constant"

Browse source 
This reverts commit 39d61db0ed.

The commit was buggy in multiple ways:
 - the conversion to ilog2() was incorrect to begin with
 - it tested the wrong #defines, so on all architectures but FRV you'd
   never see the bug except for constant arguments.
 - the new "get_order()" macro used its arguments multiple times, and
   didn't even parenthesize them properly
 - despite the comments, it was not true that you could use it for
   constant initializers, since not all architectures even use the
   generic page.h header file.

All of the problems are individually fixable, but it all boils down to:
better just revert it, and re-do it from scratch.

Cc: David Howells <dhowells@redhat.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Linus Torvalds 2007-03-06 19:38:01 -08:00
parent 5d6deb940f
commit 38f3323037
1 changed files with 4 additions and 34 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

38
include/asm-generic/page.h
View file

@ -4,51 +4,21 @@
#ifdef __KERNEL__
#ifndef __ASSEMBLY__
#include <linux/log2.h>
#include <linux/compiler.h>
/*
* non-const pure 2^n version of get_order
* - the arch may override these in asm/bitops.h if they can be implemented
* more efficiently than using the arch log2 routines
* - we use the non-const log2() instead if the arch has defined one suitable
*/
#ifndef ARCH_HAS_GET_ORDER
static inline __attribute__((const))
int __get_order(unsigned long size, int page_shift)
/* Pure 2^n version of get_order */
static __inline__ __attribute_const__ int get_order(unsigned long size)
{
#if BITS_PER_LONG == 32 && defined(ARCH_HAS_ILOG2_U32)
int order = __ilog2_u32(size) - page_shift;
return order >= 0 ? order : 0;
#elif BITS_PER_LONG == 64 && defined(ARCH_HAS_ILOG2_U64)
int order = __ilog2_u64(size) - page_shift;
return order >= 0 ? order : 0;
#else
int order;
size = (size - 1) >> (page_shift - 1);
size = (size - 1) >> (PAGE_SHIFT - 1);
order = -1;
do {
size >>= 1;
order++;
} while (size);
return order;
#endif
}
#endif
/**
* get_order - calculate log2(pages) to hold a block of the specified size
* @n - size
*
* calculate allocation order based on the current page size
* - this can be used to initialise global variables from constant data
*/
#define get_order(n) \
( \
__builtin_constant_p(n) ? \
((n < (1UL << PAGE_SHIFT)) ? 0 : ilog2(n) - PAGE_SHIFT) : \
__get_order(n, PAGE_SHIFT) \
)
#endif /* __ASSEMBLY__ */
#endif /* __KERNEL__ */