From 45da08a85b28f6828712e8527e37e88d10a2a904 Mon Sep 17 00:00:00 2001 From: Gregory Bean Date: Sat, 7 Aug 2010 07:34:23 -0700 Subject: [PATCH] Revert "checkpatch: Add warning for blank lines in header" This reverts commit 8212698c653945d0fd0783829822917bf13a5aab. The original commit incorrectly prevents the following: - Commit messages which cite other commit messages, which are commonly used for attribution; - Any use of checkpatch which doesn't contain a full mail header, such as 'show | checkpatch.pl -' Change-Id: I681a97913432d05bf66290cf74972aaa4e03fe5d Signed-off-by: Gregory Bean (cherry picked from commit c73e32b4a1a59e3a33e9c8975ab08b5475d30f3e) --- scripts/checkpatch.pl | 9 --------- 1 file changed, 9 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 77bc0fef38d6..5901bab4bf0a 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1381,7 +1381,6 @@ sub process { my $stashrawline=""; my $subjectline=""; my $sublinenr=""; - my $blankline_flag=0; my $length; my $indent; @@ -1718,7 +1717,6 @@ sub process { if ($line =~ /^\s*signed-off-by:.*(quicinc|qualcomm)\.com/i) { WARN("invalid Signed-off-by identity\n" . $line ); } - $blankline_flag = 1; } #check the patch for invalid author credentials @@ -1726,13 +1724,6 @@ sub process { WARN("invalid author identity\n" . $line ); } -#check the patch for blank lines in the header - if($line =~ /^\s*$/ && $blankline_flag == 1) { - WARN("Blank lines should not appear in the header once signed off\n"); - } elsif($line =~ /^---$/) { - $blankline_flag = 0; - } - # Check for wrappage within a valid hunk of the file if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) { ERROR("CORRUPTED_PATCH",