Piteball/android_kernel_google_msm
1
0
Fork 0
mirror of https://github.com/followmsi/android_kernel_google_msm.git synced 2024-11-06 23:17:41 +00:00
Code Issues Projects Releases Wiki Activity

memstick: mspro_block: add missing curly braces

Browse source 
commit 13f6b191aaa11c7fd718d35a0c565f3c16bc1d99 upstream.

Using the indenting we can see the curly braces were obviously intended.
This is a static checker fix, but my guess is that we don't read enough
bytes, because we don't calculate "t_len" correctly.

Fixes: f1d8269802 ('memstick: use fully asynchronous request processing')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Alex Dubov <oakad@yahoo.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Zefan Li <lizefan@huawei.com>
This commit is contained in:
Dan Carpenter 2015-04-16 12:48:35 -07:00 committed by Zefan Li
parent a12cb10097
commit 4897576f6d
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
drivers/memstick/core/mspro_block.c
View file

@ -760,7 +760,7 @@ static int mspro_block_complete_req(struct memstick_dev *card, int error)
if (error || (card->current_mrq.tpc == MSPRO_CMD_STOP)) { if (error || (card->current_mrq.tpc == MSPRO_CMD_STOP)) {
if (msb->data_dir == READ) { if (msb->data_dir == READ) {
for (cnt = 0; cnt < msb->current_seg; cnt++) for (cnt = 0; cnt < msb->current_seg; cnt++) {
t_len += msb->req_sg[cnt].length t_len += msb->req_sg[cnt].length
/ msb->page_size; / msb->page_size;
@ -768,6 +768,7 @@ static int mspro_block_complete_req(struct memstick_dev *card, int error)
t_len += msb->current_page - 1; t_len += msb->current_page - 1;
t_len *= msb->page_size; t_len *= msb->page_size;
}
} }
} else } else
t_len = blk_rq_bytes(msb->block_req); t_len = blk_rq_bytes(msb->block_req);