Piteball
/
android_kernel_google_msm
mirror of https://github.com/followmsi/android_kernel_google_msm.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

ktest.pl: Fix combined usage of BISECT_REVERSE and BISECT_SKIP 

When BISECT_REVERSE and BISECT_SKIP are used together with boot or test
testing, build failures are treated as boot or test failures and
'git bisect bad' is executed instead of 'git bisect skip'. This is because
the $ret value of -1 is treated as a build failure, but the $reverse_bisect
logic does not properly handle this.

Simple fix, only invert it if it is positive.

Link: http://lkml.kernel.org/r/1335235380-8509-1-git-send-email-Russ.Dill@ti.com

Signed-off-by: Russ Dill <Russ.Dill@ti.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
This commit is contained in:
Russ Dill 2012-04-23 19:43:00 -07:00 committed by Steven Rostedt
parent 66f75a5d02
commit 5158ba3ea7
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/testing/ktest/ktest.pl
View File

@ -2192,7 +2192,7 @@ sub run_bisect {
}
# Are we looking for where it worked, not failed?
if ($reverse_bisect) {
if ($reverse_bisect && $ret >= 0) {
$ret = !$ret;
}