Piteball/android_kernel_google_msm
1
0
Fork 0
mirror of https://github.com/followmsi/android_kernel_google_msm.git synced 2024-11-06 23:17:41 +00:00
Code Issues Projects Releases Wiki Activity

perf buildid: Fix possible unterminated readlink() result buffer

Browse source 
The readlink function doesn't guarantee that a '\0' will be put at the
end of the provided buffer if there is no space left.

No need to do "buf[len] = '\0';" since the buffer is allocated with
zalloc().

Link: http://lkml.kernel.org/r/4E986ABF.9040706@intra2net.com
Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Thomas Jarosch 2011-10-14 19:00:47 +02:00 committed by Arnaldo Carvalho de Melo
parent 0361fc25d5
commit 6c3c5b26d0
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tools/perf/util/header.c
View file

@ -1289,7 +1289,7 @@ int build_id_cache__remove_s(const char *sbuild_id, const char *debugdir)
if (access(linkname, F_OK)) if (access(linkname, F_OK))
goto out_free; goto out_free;
if (readlink(linkname, filename, size) < 0) if (readlink(linkname, filename, size - 1) < 0)
goto out_free; goto out_free;
if (unlink(linkname)) if (unlink(linkname))