Piteball/android_kernel_google_msm
1
0
Fork 0
mirror of https://github.com/followmsi/android_kernel_google_msm.git synced 2024-11-06 23:17:41 +00:00
Code Issues Projects Releases Wiki Activity

mm/vmalloc.c: use seq_open_private() instead of seq_open()

Browse source 
Using seq_open_private() removes boilerplate code from vmalloc_open().

The resultant code is shorter and easier to follow.

However, please note that seq_open_private() call kzalloc() rather than
kmalloc() which may affect timing due to the memory initialisation
overhead.

Signed-off-by: Rob Jones <rob.jones@codethink.co.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Rob Jones 2014-10-09 15:28:01 -07:00 committed by Linus Torvalds
parent 1c93923cc2
commit 703394c100
1 changed files with 5 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
mm/vmalloc.c
View file

@ -2646,21 +2646,11 @@ static const struct seq_operations vmalloc_op = {
static int vmalloc_open(struct inode *inode, struct file *file) static int vmalloc_open(struct inode *inode, struct file *file)
{ {
unsigned int *ptr = NULL; if (IS_ENABLED(CONFIG_NUMA))
int ret; return seq_open_private(file, &vmalloc_op,
nr_node_ids * sizeof(unsigned int));
if (IS_ENABLED(CONFIG_NUMA)) { else
ptr = kmalloc(nr_node_ids * sizeof(unsigned int), GFP_KERNEL); return seq_open(file, &vmalloc_op);
if (ptr == NULL)
return -ENOMEM;
}
ret = seq_open(file, &vmalloc_op);
if (!ret) {
struct seq_file *m = file->private_data;
m->private = ptr;
} else
kfree(ptr);
return ret;
} }
static const struct file_operations proc_vmalloc_operations = { static const struct file_operations proc_vmalloc_operations = {