From 795cd3130836d205ea9d67480f24cc81cad5939e Mon Sep 17 00:00:00 2001 From: Max Bires Date: Thu, 5 Jan 2017 14:23:23 -0800 Subject: [PATCH] Fixing an issue that caused DEVPORT to always be set. Without a bool string present, using "# CONFIG_DEVPORT is not set" in defconfig files would not actually unset devport. This ensured that /dev/port was always on, but there are reasons a user may wish to disable it (smaller kernel, attack surface reduction) if it's not being used. Adding a message here in order to make this user visible. Bug: 36604779 Change-Id: Iab41b5c1ba44e9e52361fbfd8b1863b88eee417b Signed-off-by: Max Bires Acked-by: Arnd Bergmann Bug: 33301618 --- drivers/char/Kconfig | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig index 0b3ffef43cb8..081edcd9e917 100644 --- a/drivers/char/Kconfig +++ b/drivers/char/Kconfig @@ -593,10 +593,13 @@ config TELCLOCK controlling the behavior of this hardware. config DEVPORT - bool + bool "/dev/port character device" depends on !M68K depends on ISA || PCI default y + help + Say Y here if you want to support the /dev/port device. The + /dev/port device is similar to /dev/mem, but for I/O ports. config DCC_TTY tristate "DCC tty driver"