Piteball/android_kernel_google_msm
1
0
Fork 0
mirror of https://github.com/followmsi/android_kernel_google_msm.git synced 2024-11-06 23:17:41 +00:00
Code Issues Projects Releases Wiki Activity

ANDROID: sdcardfs: remove dead function open_flags_to_access_mode()

Browse source 
smatch warns about the suspicious formatting in the last line of
open_flags_to_access_mode().  It turns out the only caller was deleted
over a year ago by "ANDROID: sdcardfs: Bring up to date with Android M
permissions:", so we can "fix" the function's formatting by deleting it.

Change-Id: Id85946f3eb01722eef35b1815f405a6fda3aa4ff
Signed-off-by: Greg Hackmann <ghackmann@google.com>
This commit is contained in:
Greg Hackmann 2017-05-16 16:48:49 -07:00 committed by Artem Borisov
parent 72c554da0c
commit b429963b29
2 changed files with 0 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
fs/sdcardfs/packagelist.c
View file

@ -179,19 +179,6 @@ int check_caller_access_to_name(struct inode *parent_node, const struct qstr *na
return 1;
}
/* This function is used when file opening. The open flags must be
* checked before calling check_caller_access_to_name()
*/
int open_flags_to_access_mode(int open_flags)
{
if ((open_flags & O_ACCMODE) == O_RDONLY)
return 0; /* R_OK */
if ((open_flags & O_ACCMODE) == O_WRONLY)
return 1; /* W_OK */
/* Probably O_RDRW, but treat as default to be safe */
return 1; /* R_OK | W_OK */
}
static struct hashtable_entry *alloc_hashtable_entry(const struct qstr *key,
appid_t value)
{

1
fs/sdcardfs/sdcardfs.h
View file

@ -498,7 +498,6 @@ extern appid_t get_appid(const char *app_name);
extern appid_t get_ext_gid(const char *app_name);
extern appid_t is_excluded(const char *app_name, userid_t userid);
extern int check_caller_access_to_name(struct inode *parent_node, const struct qstr *name);
extern int open_flags_to_access_mode(int open_flags);
extern int packagelist_init(void);
extern void packagelist_exit(void);