Piteball/android_kernel_google_msm
1
0
Fork 0
mirror of https://github.com/followmsi/android_kernel_google_msm.git synced 2024-11-06 23:17:41 +00:00
Code Issues Projects Releases Wiki Activity

checkpatch: Check for illegal return codes

Browse source 
The only legal integer return is 0, anything else
following "return" should be -ERRCODE or a function.

http://lkml.org/lkml/2010/7/23/318
  There's lots of "return -1;" statements in this patch - it's obscene
  that this is used to indicate "some error occurred" in kernel space
  rather than a real errno value - even when an existing function
  (eg, request_irq) gave you an error code already.

  Please note this for the future - and please review patches on this
  point internally first.

Change-Id: I16268b2ee034f0b3b899115e45c28acfa734ddec
Signed-off-by: Patrick Pannuto <ppannuto@codeaurora.org>
(cherry picked from commit 39531a47164294315b5a7256b520fe22d6e87013)
This commit is contained in:
Patrick Pannuto 2010-07-23 13:34:18 -07:00 committed by Stephen Boyd
parent 4be1c09bc3
commit dc4e47c544
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
scripts/checkpatch.pl
View file

@ -3446,6 +3446,11 @@ sub process {
"Statements terminations use 1 semicolon\n" . $herecurr);
}
# check for return codes on error paths
if ($line =~ /\breturn\s+-\d+/) {
ERROR("illegal return value, please use an error code");
}
# check for gcc specific __FUNCTION__
if ($line =~ /__FUNCTION__/) {
WARN("USE_FUNC",