Piteball/android_kernel_google_msm
1
0
Fork 0
mirror of https://github.com/followmsi/android_kernel_google_msm.git synced 2024-11-06 23:17:41 +00:00
Code Issues Projects Releases Wiki Activity

vt: synchronize_rcu() under spinlock is not nice...

Browse source 
vcs_poll_data_free() calls unregister_vt_notifier(), which calls
atomic_notifier_chain_unregister(), which calls synchronize_rcu().
Do it *after* we'd dropped ->f_lock.

Cc: stable@vger.kernel.org (all kernels since 2.6.37)
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Al Viro 2013-03-26 20:30:17 -04:00
parent 7ea600b531
commit e8cd81693b
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/tty/vt/vc_screen.c
View file

@ -93,7 +93,7 @@ vcs_poll_data_free(struct vcs_poll_data *poll)
static struct vcs_poll_data * static struct vcs_poll_data *
vcs_poll_data_get(struct file *file) vcs_poll_data_get(struct file *file)
{ {
struct vcs_poll_data *poll = file->private_data; struct vcs_poll_data *poll = file->private_data, *kill = NULL;
if (poll) if (poll)
return poll; return poll;
@ -122,10 +122,12 @@ vcs_poll_data_get(struct file *file)
file->private_data = poll; file->private_data = poll;
} else { } else {
/* someone else raced ahead of us */ /* someone else raced ahead of us */
vcs_poll_data_free(poll); kill = poll;
poll = file->private_data; poll = file->private_data;
} }
spin_unlock(&file->f_lock); spin_unlock(&file->f_lock);
if (kill)
vcs_poll_data_free(kill);
return poll; return poll;
} }