Commit graph

6 commits

Author SHA1 Message Date
Binoy Jayan
bc64aa3603 char: Fix NULL pointer dereferences
Fix the following NULL pointer dereferences in character drivers.

Null pointer 'pra' that comes from line 825 may be passed to function
and can be dereferenced there by passing argument 4 to function
'fastrpc_internal_invoke' at line 847.
drivers/char/adsprpc.c +847 | fastrpc_device_ioctl()

Null pointer 'rpra' that comes from line 672 may be passed
to function and can be dereferenced there by passing argument 2
to function 'inv_args' at line 702.
drivers/char/adsprpc.c +702 | fastrpc_internal_invoke()

Constant NULL may be dereferenced by passing argument 3 to
function 'diag_device_write' at line 165.
drivers/char/diag/diagfwd_hsic.c +165 | diag_hsic_read_complete_callback()
drivers/char/diag/diagfwd.c +585 | diag_device_write()

Change-Id: I30469575c30f3846b449b6c71522f7dfc10c5bc5
Signed-off-by: Binoy Jayan <bjayan@codeaurora.org>
2016-10-29 23:12:34 +08:00
Mitchel Humpherys
bedfff667d msm: ADSPRPC: Add checks for erroneous values
Check for invalid parameters passed in user invocation
and validate the return values using appropriate macros.

Bug: 28767593
Change-Id: I9a067f2ab151084b46e9d4d5fb945320a27bb7ba
Signed-off-by: Yuan Lin <yualin@google.com>
2016-06-02 12:32:11 -07:00
Mitchel Humpherys
15ae2394c1 msm: ADSPRPC: Update driver to create its own device node
Create device node under /dev/adsprpc-smd. Users no longer have to run
mknod after the driver is installed.

Change-Id: I5f5ae4dafc37ce8e87ef2c91358be9bfd5934b8a
Acked-by: Anatoly Yakovenko <anatolyy@qti.qualcomm.com>
Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>
2013-03-15 17:07:42 -07:00
Mitchel Humpherys
402830b08d msm: ADSPRPC: Cleanup header and source.
Cleanup header and source to conform with coding guidelines.

Change-Id: I0fba2a7a758930003d5bce9c8ffc0036574736b8
Acked-by: Anatoly Yakovenko <anatolyy@qti.qualcomm.com>
Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>
2013-03-15 17:07:42 -07:00
Mitchel Humpherys
27d34212e5 msm: adsprpc: Allow zero length buffer
Initialize the arguments being passed to account for zero
length buffer being passed and not invoke flush routines
in these cases.

Change-Id: Ic6b3418f05ea3ca46e7ca758ebbd0a7bda987b51
Acked-by: Sathish Ambley <sambley@qualcomm.com>
Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>
Signed-off-by: Ram Kumar Chakravarthy Chebathini <rcheba@codeaurora.org>
2013-03-15 17:07:03 -07:00
Mitchel Humpherys
10833882f0 msm: Move adsprpc into drivers
Move RPC driver that allows for clients to make remote
invocation calls between apps and adsp into drivers.

Change-Id: I045da6163968066c954f448572c94a133181e1f4
Acked-by: Sathish Ambley <sambley@qualcomm.com>
Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>
Signed-off-by: Ram Kumar Chakravarthy Chebathini <rcheba@codeaurora.org>
2013-03-15 17:07:02 -07:00
Renamed from arch/arm/mach-msm/qdsp6v2/adsprpc.c (Browse further)