Marcin Jurkowski 32f8134514 w1: fix oops when w1_search is called from netlink connector ... commit 9d1817cab2 upstream. On Sat, Mar 02, 2013 at 10:45:10AM +0100, Sven Geggus wrote: > This is the bad commit I found doing git bisect: > 04f482faf5 is the first bad commit > commit 04f482faf5 > Author: Patrick McHardy <kaber@trash.net> > Date: Mon Mar 28 08:39:36 2011 +0000 Good job. I was too lazy to bisect for bad commit;) Reading the code I found problematic kthread_should_stop call from netlink connector which causes the oops. After applying a patch, I've been testing owfs+w1 setup for nearly two days and it seems to work very reliable (no hangs, no memleaks etc). More detailed description and possible fix is given below: Function w1_search can be called from either kthread or netlink callback. While the former works fine, the latter causes oops due to kthread_should_stop invocation. This patch adds a check if w1_search is serving netlink command, skipping kthread_should_stop invocation if so. Signed-off-by: Marcin Jurkowski <marcin1j@gmail.com> Acked-by: Evgeniy Polyakov <zbr@ioremap.net> Cc: Josh Boyer <jwboyer@gmail.com> Tested-by: Sven Geggus <lists@fuchsschwanzdomain.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2013-03-20 13:04:59 -07:00
..
masters	w1: Use linux/gpio.h rather than asm/gpio.h	2012-02-09 08:36:05 -08:00
slaves	DS2781 Maxim Stand-Alone Fuel Gauge battery and w1 slave drivers	2012-03-08 11:15:33 -08:00
Kconfig
Makefile
w1.c	w1: fix oops when w1_search is called from netlink connector	2013-03-20 13:04:59 -07:00
w1.h	MAINTAINERS: Evgeniy has moved	2011-08-25 16:25:33 -07:00
w1_family.c	drivers/w1: Add export.h for EXPORT_SYMBOL/THIS_MODULE	2011-10-31 19:32:00 -04:00
w1_family.h	DS2781 Maxim Stand-Alone Fuel Gauge battery and w1 slave drivers	2012-03-08 11:15:33 -08:00
w1_int.c	Merge branch 'modsplit-Oct31_2011' of git://git.kernel.org/pub/scm/linux/kernel/git/paulg/linux	2011-11-06 19:44:47 -08:00
w1_int.h	MAINTAINERS: Evgeniy has moved	2011-08-25 16:25:33 -07:00
w1_io.c	w1: disable irqs in critical section	2011-11-02 16:07:03 -07:00
w1_log.h	MAINTAINERS: Evgeniy has moved	2011-08-25 16:25:33 -07:00
w1_netlink.c	MAINTAINERS: Evgeniy has moved	2011-08-25 16:25:33 -07:00
w1_netlink.h	MAINTAINERS: Evgeniy has moved	2011-08-25 16:25:33 -07:00