Russ Anderson 6e99f322b5 drivers/base/memory.c: fix show_mem_removable() to handle missing sections ... commit 21ea9f5ace upstream. "cat /sys/devices/system/memory/memory*/removable" crashed the system. The problem is that show_mem_removable() is passing a bad pfn to is_mem_section_removable(), which causes if (!node_online(page_to_nid(page))) to blow up. Why is it passing in a bad pfn? The reason is that show_mem_removable() will loop sections_per_block times. sections_per_block is 16, but mem->section_count is 8, indicating holes in this memory block. Checking that the memory section is present before checking to see if the memory section is removable fixes the problem. harp5-sys:~ # cat /sys/devices/system/memory/memory*/removable 0 1 1 1 1 1 1 1 1 1 1 1 1 1 BUG: unable to handle kernel paging request at ffffea00c3200000 IP: [<ffffffff81117ed1>] is_pageblock_removable_nolock+0x1/0x90 PGD 83ffd4067 PUD 37bdfce067 PMD 0 Oops: 0000 [#1] SMP Modules linked in: autofs4 binfmt_misc rdma_ucm rdma_cm iw_cm ib_addr ib_srp scsi_transport_srp scsi_tgt ib_ipoib ib_cm ib_uverbs ib_umad iw_cxgb3 cxgb3 mdio mlx4_en mlx4_ib ib_sa mlx4_core ib_mthca ib_mad ib_core fuse nls_iso8859_1 nls_cp437 vfat fat joydev loop hid_generic usbhid hid hwperf(O) numatools(O) dm_mod iTCO_wdt ipv6 iTCO_vendor_support igb i2c_i801 ioatdma i2c_algo_bit ehci_pci pcspkr lpc_ich i2c_core ehci_hcd ptp sg mfd_core dca rtc_cmos pps_core mperf button xhci_hcd sd_mod crc_t10dif usbcore usb_common scsi_dh_emc scsi_dh_hp_sw scsi_dh_alua scsi_dh_rdac scsi_dh gru(O) xvma(O) xfs crc32c libcrc32c thermal sata_nv processor piix mptsas mptscsih scsi_transport_sas mptbase megaraid_sas fan thermal_sys hwmon ext3 jbd ata_piix ahci libahci libata scsi_mod CPU: 4 PID: 5991 Comm: cat Tainted: G O 3.11.0-rc5-rja-uv+ #10 Hardware name: SGI UV2000/ROMLEY, BIOS SGI UV 2000/3000 series BIOS 01/15/2013 task: ffff88081f034580 ti: ffff880820022000 task.ti: ffff880820022000 RIP: 0010:[<ffffffff81117ed1>] [<ffffffff81117ed1>] is_pageblock_removable_nolock+0x1/0x90 RSP: 0018:ffff880820023df8 EFLAGS: 00010287 RAX: 0000000000040000 RBX: ffffea00c3200000 RCX: 0000000000000004 RDX: ffffea00c30b0000 RSI: 00000000001c0000 RDI: ffffea00c3200000 RBP: ffff880820023e38 R08: 0000000000000000 R09: 0000000000000001 R10: 0000000000000000 R11: 0000000000000001 R12: ffffea00c33c0000 R13: 0000160000000000 R14: 6db6db6db6db6db7 R15: 0000000000000001 FS: 00007ffff7fb2700(0000) GS:ffff88083fc80000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: ffffea00c3200000 CR3: 000000081b954000 CR4: 00000000000407e0 Call Trace: show_mem_removable+0x41/0x70 dev_attr_show+0x2a/0x60 sysfs_read_file+0xf7/0x1c0 vfs_read+0xc8/0x130 SyS_read+0x5d/0xa0 system_call_fastpath+0x16/0x1b Signed-off-by: Russ Anderson <rja@sgi.com> Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com> Cc: Yinghai Lu <yinghai@kernel.org> Reviewed-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2013-09-07 21:58:14 -07:00
..
power	PM / QoS: fix wrong error-checking condition	2012-12-03 11:47:10 -08:00
regmap	regmap: silence GCC warning	2013-09-07 21:58:14 -07:00
attribute_container.c	[SCSI] attirbute_container: Initialize sysfs attributes with sysfs_attr_init	2010-03-27 15:15:24 -04:00
base.h	driver core: move the deferred probe pointer into the private area	2012-03-08 12:17:22 -08:00
bus.c	Driver core: treat unregistered bus_types as having no devices	2013-02-28 06:59:00 -08:00
class.c	driver-core: implement 'sysdev' functionality for regular devices and buses	2011-12-14 14:29:38 -08:00
core.c	Core device tree changes for Linux v3.4	2012-03-21 10:30:03 -07:00
cpu.c	Merge 3.3-rc6 into driver-core-next	2012-03-09 12:35:53 -08:00
dd.c	drivercore: Fix ordering between deferred_probe and exiting initcalls	2013-02-28 06:59:01 -08:00
devres.c	devres: Fix a typo in devm_kfree comment	2011-12-21 00:31:47 +01:00
devtmpfs.c	Merge branch 'for-linus2' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2012-01-08 12:19:57 -08:00
dma-buf.c	dma-buf: add support for kernel cpu access	2012-03-26 11:33:02 +05:30
dma-coherent.c	drivers/base: dma-coherent.c is a module and needs module.h	2011-10-31 19:31:38 -04:00
dma-mapping.c	drivers/base: Add export.h for EXPORT_SYMBOL/THIS_MODULE as required.	2011-10-31 19:31:38 -04:00
driver.c	Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc	2012-03-21 18:55:10 -07:00
firmware.c
firmware_class.c	firmware_class: Move request_firmware_nowait() to workqueues	2012-03-28 23:31:00 +02:00
hypervisor.c	drivers/base: Add export.h for EXPORT_SYMBOL/THIS_MODULE as required.	2011-10-31 19:31:38 -04:00
init.c	driver-core: implement 'sysdev' functionality for regular devices and buses	2011-12-14 14:29:38 -08:00
isa.c
Kconfig	drivers/base: add bus for System-on-Chip devices	2012-02-10 11:42:25 -08:00
Makefile	drivers/base: add bus for System-on-Chip devices	2012-02-10 11:42:25 -08:00
map.c
memory.c	drivers/base/memory.c: fix show_mem_removable() to handle missing sections	2013-09-07 21:58:14 -07:00
module.c	driver core: module.c: Use kasprintf	2010-05-21 09:37:29 -07:00
node.c	drivers/base/memory.c: fix memory_dev_init() long delay	2012-02-02 15:50:05 -08:00
platform.c	drivercore: Output common devicetree information in uevent	2012-02-01 14:26:30 -07:00
soc.c	drivers/base: fix compiler warning in SoC export driver - idr should be ida	2012-04-09 14:54:22 -07:00
syscore.c	PM: Reintroduce dropped call to check_wakeup_irqs	2011-07-11 10:51:49 +02:00
topology.c	cpu: convert 'cpu' and 'machinecheck' sysdev_class to a regular subsystem	2011-12-21 14:29:42 -08:00
transport_class.c	drivers/base: transport_class explicitly requires EXPORT_SYMBOL	2011-10-31 19:31:15 -04:00