Konrad Rzeszutek Wilk 63f12e8d2b xen/smp/spinlock: Fix leakage of the spinlock interrupt line for every CPU online/offline ... commit 66ff0fe9e7 upstream. While we don't use the spinlock interrupt line (see for details commit f10cd522c5 - xen: disable PV spinlocks on HVM) - we should still do the proper init / deinit sequence. We did not do that correctly and for the CPU init for PVHVM guest we would allocate an interrupt line - but failed to deallocate the old interrupt line. This resulted in leakage of an irq_desc but more importantly this splat as we online an offlined CPU: genirq: Flags mismatch irq 71. 0002cc20 (spinlock1) vs. 0002cc20 (spinlock1) Pid: 2542, comm: init.late Not tainted 3.9.0-rc6upstream #1 Call Trace: [<ffffffff811156de>] __setup_irq+0x23e/0x4a0 [<ffffffff81194191>] ? kmem_cache_alloc_trace+0x221/0x250 [<ffffffff811161bb>] request_threaded_irq+0xfb/0x160 [<ffffffff8104c6f0>] ? xen_spin_trylock+0x20/0x20 [<ffffffff813a8423>] bind_ipi_to_irqhandler+0xa3/0x160 [<ffffffff81303758>] ? kasprintf+0x38/0x40 [<ffffffff8104c6f0>] ? xen_spin_trylock+0x20/0x20 [<ffffffff810cad35>] ? update_max_interval+0x15/0x40 [<ffffffff816605db>] xen_init_lock_cpu+0x3c/0x78 [<ffffffff81660029>] xen_hvm_cpu_notify+0x29/0x33 [<ffffffff81676bdd>] notifier_call_chain+0x4d/0x70 [<ffffffff810bb2a9>] __raw_notifier_call_chain+0x9/0x10 [<ffffffff8109402b>] __cpu_notify+0x1b/0x30 [<ffffffff8166834a>] _cpu_up+0xa0/0x14b [<ffffffff816684ce>] cpu_up+0xd9/0xec [<ffffffff8165f754>] store_online+0x94/0xd0 [<ffffffff8141d15b>] dev_attr_store+0x1b/0x20 [<ffffffff81218f44>] sysfs_write_file+0xf4/0x170 [<ffffffff811a2864>] vfs_write+0xb4/0x130 [<ffffffff811a302a>] sys_write+0x5a/0xa0 [<ffffffff8167ada9>] system_call_fastpath+0x16/0x1b cpu 1 spinlock event irq -16 smpboot: Booting Node 0 Processor 1 APIC 0x2 And if one looks at the /proc/interrupts right after offlining (CPU1): 70: 0 0 xen-percpu-ipi spinlock0 71: 0 0 xen-percpu-ipi spinlock1 77: 0 0 xen-percpu-ipi spinlock2 There is the oddity of the 'spinlock1' still being present. Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> [bwh: Backported to 3.2: adjust context] Signed-off-by: Ben Hutchings <ben@decadent.org.uk> Cc: Yijing Wang <wangyijing@huawei.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2014-03-11 16:10:06 -07:00
..
debugfs.c
debugfs.h
enlighten.c	xen/boot: Disable BIOS SMP MP table search.	2014-03-11 16:10:06 -07:00
grant-table.c
irq.c	xen: use this_cpu_xxx replace percpu_xxx funcs	2012-01-24 12:20:24 -05:00
Kconfig
Makefile
mmu.c	x86, mm: Patch out arch_flush_lazy_mmu_mode() when running on bare metal	2013-04-16 21:27:27 -07:00
mmu.h
multicalls.c
multicalls.h	xen: use this_cpu_xxx replace percpu_xxx funcs	2012-01-24 12:20:24 -05:00
p2m.c	xen/m2p: do not reuse kmap_op->dev_bus_addr	2012-10-02 10:30:06 -07:00
pci-swiotlb-xen.c	X86 & IA64: adapt for dma_map_ops changes	2012-03-28 16:36:31 +02:00
platform-pci-unplug.c
setup.c	x86/xen: do not identity map UNUSABLE regions in the machine E820	2013-08-29 09:50:14 -07:00
smp.c	xen/smp/spinlock: Fix leakage of the spinlock interrupt line for every CPU online/offline	2014-03-11 16:10:06 -07:00
spinlock.c	xen: Send spinlock IPI to all waiters	2013-02-28 06:59:00 -08:00
suspend.c
time.c	xen/time: remove blocked time accounting from xen "clockchip"	2013-07-21 18:19:01 -07:00
trace.c
vdso.h
vga.c
xen-asm.h
xen-asm.S	xen: correctly check for pending events when restoring irq flags	2012-04-27 16:04:21 -04:00
xen-asm_32.S	x86/xen: don't assume %ds is usable in xen_iret for 32-bit PVOPS.	2013-02-17 10:49:26 -08:00
xen-asm_64.S
xen-head.S
xen-ops.h