android_kernel_google_msm/drivers/hid
Anssi Hannula f129ea6d1e HID: fix a lockup regression when using force feedback on a PID device
Commit 8006479c9b introduced a spinlock in
input_dev->event_lock, which is locked when handling input events.
However, the hid-pidff driver sleeps when handling events as it waits for
reports being sent to the device before changing the report contents
again.
This causes a system lockup when trying to use force feedback with a PID
device, a regression introduced in 2.6.24 and 2.6.23.15.

Fix it by extracting the raw report data from struct hid_report
immediately when hid_submit_report() is called, therefore allowing
drivers to change the contents of struct hid_report immediately without
affecting the already-queued transfer.

In hid-pidff, re-add the removed usbhid_wait_io() to
pidff_erase_effect() instead, to prevent a full report queue from causing
the submission to fail, thus not freeing up device memory.
pidff_erase_effect() is not called while dev->event_lock is held.

Signed-off-by: Anssi Hannula <anssi.hannula@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
2008-10-14 23:51:02 +02:00
..
usbhid HID: fix a lockup regression when using force feedback on a PID device 2008-10-14 23:51:02 +02:00
hid-a4tech.c HID: move connect quirks 2008-10-14 23:50:56 +02:00
hid-apple.c HID: report descriptor fix for remaining MacBook JIS keyboards 2008-10-14 23:50:59 +02:00
hid-belkin.c HID: move connect quirks 2008-10-14 23:50:56 +02:00
hid-cherry.c HID: move cherry quirks 2008-10-14 23:50:52 +02:00
hid-chicony.c HID: move chicony quirks 2008-10-14 23:50:53 +02:00
hid-core.c HID: move zeroplus FF processing 2008-10-14 23:51:01 +02:00
hid-cypress.c HID: move connect quirks 2008-10-14 23:50:56 +02:00
hid-debug.c HID: remove CVS keywords 2008-05-20 16:44:43 +02:00
hid-dell.c HID: move reset leds quirk 2008-10-14 23:50:56 +02:00
hid-dummy.c HID: move zeroplus FF processing 2008-10-14 23:51:01 +02:00
hid-ezkey.c HID: move ezkey quirks 2008-10-14 23:50:52 +02:00
hid-gyration.c HID: move gyration quirks 2008-10-14 23:50:54 +02:00
hid-ids.h HID: move zeroplus FF processing 2008-10-14 23:51:01 +02:00
hid-input.c HID: move connect quirks 2008-10-14 23:50:56 +02:00
hid-lg.c HID: move logitech FF processing 2008-10-14 23:50:56 +02:00
hid-lg.h HID: move logitech FF processing 2008-10-14 23:50:56 +02:00
hid-lg2ff.c HID: convert to dev_* prints 2008-10-14 23:51:01 +02:00
hid-lgff.c HID: Autocentering support for Logitech MOMO Racing Wheel 2008-10-14 23:50:58 +02:00
hid-microsoft.c HID: move connect quirks 2008-10-14 23:50:56 +02:00
hid-monterey.c HID: move monterey quirks 2008-10-14 23:50:53 +02:00
hid-petalynx.c HID: move connect quirks 2008-10-14 23:50:56 +02:00
hid-pl.c HID: convert to dev_* prints 2008-10-14 23:51:01 +02:00
hid-samsung.c HID: move connect quirks 2008-10-14 23:50:56 +02:00
hid-sony.c HID: move connect quirks 2008-10-14 23:50:56 +02:00
hid-sunplus.c HID: move sunplus quirks 2008-10-14 23:50:51 +02:00
hid-tmff.c HID: convert to dev_* prints 2008-10-14 23:51:01 +02:00
hid-zpff.c HID: convert to dev_* prints 2008-10-14 23:51:01 +02:00
hidraw.c HID: fix incorrent length condition in hidraw_write() 2008-10-14 23:51:00 +02:00
Kconfig HID: move zeroplus FF processing 2008-10-14 23:51:01 +02:00
Makefile HID: move zeroplus FF processing 2008-10-14 23:51:01 +02:00