tmpfs: fix uninitialized return value in shmem_link
[ Upstream commit 29b00e609960ae0fcff382f4c7079dd0874a5311 ] When we made the shmem_reserve_inode call in shmem_link conditional, we forgot to update the declaration for ret so that it always has a known value. Dan Carpenter pointed out this deficiency in the original patch. [aviraxp: Adjust context for 3.10] Fixes: 1062af920c07 ("tmpfs: fix link accounting when a tmpfile is linked in") Change-Id: Ib91581d0f1ffbfb1ebe2f827aa125684a844eded Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> Signed-off-by: Hugh Dickins <hughd@google.com> Cc: Matej Kupljen <matej.kupljen@gmail.com> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
adcc84d7f2
commit
b7697bead6
|
@ -1685,7 +1685,7 @@ static int shmem_create(struct inode *dir, struct dentry *dentry, umode_t mode,
|
|||
static int shmem_link(struct dentry *old_dentry, struct inode *dir, struct dentry *dentry)
|
||||
{
|
||||
struct inode *inode = old_dentry->d_inode;
|
||||
int ret;
|
||||
int ret = 0;
|
||||
|
||||
/*
|
||||
* No ordinary (disk based) filesystem counts links as inodes;
|
||||
|
|
Loading…
Reference in New Issue