2008-01-29 13:53:40 +00:00
|
|
|
/*
|
|
|
|
* Functions related to io context handling
|
|
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/init.h>
|
|
|
|
#include <linux/bio.h>
|
|
|
|
#include <linux/blkdev.h>
|
|
|
|
#include <linux/bootmem.h> /* for max_pfn/max_low_pfn */
|
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 08:04:11 +00:00
|
|
|
#include <linux/slab.h>
|
2008-01-29 13:53:40 +00:00
|
|
|
|
|
|
|
#include "blk.h"
|
|
|
|
|
|
|
|
/*
|
|
|
|
* For io context allocations
|
|
|
|
*/
|
|
|
|
static struct kmem_cache *iocontext_cachep;
|
|
|
|
|
block: make ioc get/put interface more conventional and fix race on alloction
Ignoring copy_io() during fork, io_context can be allocated from two
places - current_io_context() and set_task_ioprio(). The former is
always called from local task while the latter can be called from
different task. The synchornization between them are peculiar and
dubious.
* current_io_context() doesn't grab task_lock() and assumes that if it
saw %NULL ->io_context, it would stay that way until allocation and
assignment is complete. It has smp_wmb() between alloc/init and
assignment.
* set_task_ioprio() grabs task_lock() for assignment and does
smp_read_barrier_depends() between "ioc = task->io_context" and "if
(ioc)". Unfortunately, this doesn't achieve anything - the latter
is not a dependent load of the former. ie, if ioc itself were being
dereferenced "ioc->xxx", it would mean something (not sure what tho)
but as the code currently stands, the dependent read barrier is
noop.
As only one of the the two test-assignment sequences is task_lock()
protected, the task_lock() can't do much about race between the two.
Nothing prevents current_io_context() and set_task_ioprio() allocating
its own ioc for the same task and overwriting the other's.
Also, set_task_ioprio() can race with exiting task and create a new
ioc after exit_io_context() is finished.
ioc get/put doesn't have any reason to be complex. The only hot path
is accessing the existing ioc of %current, which is simple to achieve
given that ->io_context is never destroyed as long as the task is
alive. All other paths can happily go through task_lock() like all
other task sub structures without impacting anything.
This patch updates ioc get/put so that it becomes more conventional.
* alloc_io_context() is replaced with get_task_io_context(). This is
the only interface which can acquire access to ioc of another task.
On return, the caller has an explicit reference to the object which
should be put using put_io_context() afterwards.
* The functionality of current_io_context() remains the same but when
creating a new ioc, it shares the code path with
get_task_io_context() and always goes through task_lock().
* get_io_context() now means incrementing ref on an ioc which the
caller already has access to (be that an explicit refcnt or implicit
%current one).
* PF_EXITING inhibits creation of new io_context and once
exit_io_context() is finished, it's guaranteed that both ioc
acquisition functions return %NULL.
* All users are updated. Most are trivial but
smp_read_barrier_depends() removal from cfq_get_io_context() needs a
bit of explanation. I suppose the original intention was to ensure
ioc->ioprio is visible when set_task_ioprio() allocates new
io_context and installs it; however, this wouldn't have worked
because set_task_ioprio() doesn't have wmb between init and install.
There are other problems with this which will be fixed in another
patch.
* While at it, use NUMA_NO_NODE instead of -1 for wildcard node
specification.
-v2: Vivek spotted contamination from debug patch. Removed.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2011-12-13 23:33:38 +00:00
|
|
|
/**
|
|
|
|
* get_io_context - increment reference count to io_context
|
|
|
|
* @ioc: io_context to get
|
|
|
|
*
|
|
|
|
* Increment reference count to @ioc.
|
|
|
|
*/
|
|
|
|
void get_io_context(struct io_context *ioc)
|
|
|
|
{
|
|
|
|
BUG_ON(atomic_long_read(&ioc->refcount) <= 0);
|
|
|
|
atomic_long_inc(&ioc->refcount);
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(get_io_context);
|
|
|
|
|
2011-12-13 23:33:39 +00:00
|
|
|
/*
|
|
|
|
* Releasing ioc may nest into another put_io_context() leading to nested
|
|
|
|
* fast path release. As the ioc's can't be the same, this is okay but
|
|
|
|
* makes lockdep whine. Keep track of nesting and use it as subclass.
|
|
|
|
*/
|
|
|
|
#ifdef CONFIG_LOCKDEP
|
|
|
|
#define ioc_release_depth(q) ((q) ? (q)->ioc_release_depth : 0)
|
|
|
|
#define ioc_release_depth_inc(q) (q)->ioc_release_depth++
|
|
|
|
#define ioc_release_depth_dec(q) (q)->ioc_release_depth--
|
|
|
|
#else
|
|
|
|
#define ioc_release_depth(q) 0
|
|
|
|
#define ioc_release_depth_inc(q) do { } while (0)
|
|
|
|
#define ioc_release_depth_dec(q) do { } while (0)
|
|
|
|
#endif
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Slow path for ioc release in put_io_context(). Performs double-lock
|
2011-12-13 23:33:41 +00:00
|
|
|
* dancing to unlink all icq's and then frees ioc.
|
2011-12-13 23:33:39 +00:00
|
|
|
*/
|
|
|
|
static void ioc_release_fn(struct work_struct *work)
|
2008-01-29 13:53:40 +00:00
|
|
|
{
|
2011-12-13 23:33:39 +00:00
|
|
|
struct io_context *ioc = container_of(work, struct io_context,
|
|
|
|
release_work);
|
|
|
|
struct request_queue *last_q = NULL;
|
|
|
|
|
|
|
|
spin_lock_irq(&ioc->lock);
|
|
|
|
|
2011-12-13 23:33:41 +00:00
|
|
|
while (!hlist_empty(&ioc->icq_list)) {
|
|
|
|
struct io_cq *icq = hlist_entry(ioc->icq_list.first,
|
|
|
|
struct io_cq, ioc_node);
|
|
|
|
struct request_queue *this_q = icq->q;
|
2011-12-13 23:33:39 +00:00
|
|
|
|
|
|
|
if (this_q != last_q) {
|
|
|
|
/*
|
|
|
|
* Need to switch to @this_q. Once we release
|
|
|
|
* @ioc->lock, it can go away along with @cic.
|
|
|
|
* Hold on to it.
|
|
|
|
*/
|
|
|
|
__blk_get_queue(this_q);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* blk_put_queue() might sleep thanks to kobject
|
|
|
|
* idiocy. Always release both locks, put and
|
|
|
|
* restart.
|
|
|
|
*/
|
|
|
|
if (last_q) {
|
|
|
|
spin_unlock(last_q->queue_lock);
|
|
|
|
spin_unlock_irq(&ioc->lock);
|
|
|
|
blk_put_queue(last_q);
|
|
|
|
} else {
|
|
|
|
spin_unlock_irq(&ioc->lock);
|
|
|
|
}
|
|
|
|
|
|
|
|
last_q = this_q;
|
|
|
|
spin_lock_irq(this_q->queue_lock);
|
|
|
|
spin_lock(&ioc->lock);
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
ioc_release_depth_inc(this_q);
|
2011-12-13 23:33:41 +00:00
|
|
|
icq->exit(icq);
|
|
|
|
icq->release(icq);
|
2011-12-13 23:33:39 +00:00
|
|
|
ioc_release_depth_dec(this_q);
|
|
|
|
}
|
2008-02-19 09:02:29 +00:00
|
|
|
|
2011-12-13 23:33:39 +00:00
|
|
|
if (last_q) {
|
|
|
|
spin_unlock(last_q->queue_lock);
|
|
|
|
spin_unlock_irq(&ioc->lock);
|
|
|
|
blk_put_queue(last_q);
|
|
|
|
} else {
|
|
|
|
spin_unlock_irq(&ioc->lock);
|
2008-02-19 09:02:29 +00:00
|
|
|
}
|
2011-12-13 23:33:39 +00:00
|
|
|
|
|
|
|
kmem_cache_free(iocontext_cachep, ioc);
|
2008-01-29 13:53:40 +00:00
|
|
|
}
|
|
|
|
|
2011-12-13 23:33:37 +00:00
|
|
|
/**
|
|
|
|
* put_io_context - put a reference of io_context
|
|
|
|
* @ioc: io_context to put
|
2011-12-13 23:33:39 +00:00
|
|
|
* @locked_q: request_queue the caller is holding queue_lock of (hint)
|
2011-12-13 23:33:37 +00:00
|
|
|
*
|
|
|
|
* Decrement reference count of @ioc and release it if the count reaches
|
2011-12-13 23:33:39 +00:00
|
|
|
* zero. If the caller is holding queue_lock of a queue, it can indicate
|
|
|
|
* that with @locked_q. This is an optimization hint and the caller is
|
|
|
|
* allowed to pass in %NULL even when it's holding a queue_lock.
|
2008-01-29 13:53:40 +00:00
|
|
|
*/
|
2011-12-13 23:33:39 +00:00
|
|
|
void put_io_context(struct io_context *ioc, struct request_queue *locked_q)
|
2008-01-29 13:53:40 +00:00
|
|
|
{
|
2011-12-13 23:33:39 +00:00
|
|
|
struct request_queue *last_q = locked_q;
|
|
|
|
unsigned long flags;
|
|
|
|
|
2008-01-29 13:53:40 +00:00
|
|
|
if (ioc == NULL)
|
2011-12-13 23:33:37 +00:00
|
|
|
return;
|
2008-01-29 13:53:40 +00:00
|
|
|
|
2011-12-13 23:33:37 +00:00
|
|
|
BUG_ON(atomic_long_read(&ioc->refcount) <= 0);
|
2011-12-13 23:33:39 +00:00
|
|
|
if (locked_q)
|
|
|
|
lockdep_assert_held(locked_q->queue_lock);
|
2008-01-29 13:53:40 +00:00
|
|
|
|
2011-12-13 23:33:37 +00:00
|
|
|
if (!atomic_long_dec_and_test(&ioc->refcount))
|
|
|
|
return;
|
2008-01-29 13:53:40 +00:00
|
|
|
|
2011-12-13 23:33:39 +00:00
|
|
|
/*
|
2011-12-13 23:33:41 +00:00
|
|
|
* Destroy @ioc. This is a bit messy because icq's are chained
|
2011-12-13 23:33:39 +00:00
|
|
|
* from both ioc and queue, and ioc->lock nests inside queue_lock.
|
2011-12-13 23:33:41 +00:00
|
|
|
* The inner ioc->lock should be held to walk our icq_list and then
|
|
|
|
* for each icq the outer matching queue_lock should be grabbed.
|
2011-12-13 23:33:39 +00:00
|
|
|
* ie. We need to do reverse-order double lock dancing.
|
|
|
|
*
|
|
|
|
* Another twist is that we are often called with one of the
|
|
|
|
* matching queue_locks held as indicated by @locked_q, which
|
|
|
|
* prevents performing double-lock dance for other queues.
|
|
|
|
*
|
|
|
|
* So, we do it in two stages. The fast path uses the queue_lock
|
|
|
|
* the caller is holding and, if other queues need to be accessed,
|
|
|
|
* uses trylock to avoid introducing locking dependency. This can
|
|
|
|
* handle most cases, especially if @ioc was performing IO on only
|
|
|
|
* single device.
|
|
|
|
*
|
|
|
|
* If trylock doesn't cut it, we defer to @ioc->release_work which
|
|
|
|
* can do all the double-locking dancing.
|
|
|
|
*/
|
|
|
|
spin_lock_irqsave_nested(&ioc->lock, flags,
|
|
|
|
ioc_release_depth(locked_q));
|
|
|
|
|
2011-12-13 23:33:41 +00:00
|
|
|
while (!hlist_empty(&ioc->icq_list)) {
|
|
|
|
struct io_cq *icq = hlist_entry(ioc->icq_list.first,
|
|
|
|
struct io_cq, ioc_node);
|
|
|
|
struct request_queue *this_q = icq->q;
|
2011-12-13 23:33:39 +00:00
|
|
|
|
|
|
|
if (this_q != last_q) {
|
|
|
|
if (last_q && last_q != locked_q)
|
|
|
|
spin_unlock(last_q->queue_lock);
|
|
|
|
last_q = NULL;
|
|
|
|
|
|
|
|
if (!spin_trylock(this_q->queue_lock))
|
|
|
|
break;
|
|
|
|
last_q = this_q;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
ioc_release_depth_inc(this_q);
|
2011-12-13 23:33:41 +00:00
|
|
|
icq->exit(icq);
|
|
|
|
icq->release(icq);
|
2011-12-13 23:33:39 +00:00
|
|
|
ioc_release_depth_dec(this_q);
|
|
|
|
}
|
2008-01-29 13:53:40 +00:00
|
|
|
|
2011-12-13 23:33:39 +00:00
|
|
|
if (last_q && last_q != locked_q)
|
|
|
|
spin_unlock(last_q->queue_lock);
|
2008-01-29 13:53:40 +00:00
|
|
|
|
2011-12-13 23:33:39 +00:00
|
|
|
spin_unlock_irqrestore(&ioc->lock, flags);
|
2008-02-19 09:02:29 +00:00
|
|
|
|
2011-12-13 23:33:41 +00:00
|
|
|
/* if no icq is left, we're done; otherwise, kick release_work */
|
|
|
|
if (hlist_empty(&ioc->icq_list))
|
2011-12-13 23:33:39 +00:00
|
|
|
kmem_cache_free(iocontext_cachep, ioc);
|
|
|
|
else
|
|
|
|
schedule_work(&ioc->release_work);
|
2008-01-29 13:53:40 +00:00
|
|
|
}
|
2011-12-13 23:33:39 +00:00
|
|
|
EXPORT_SYMBOL(put_io_context);
|
2008-01-29 13:53:40 +00:00
|
|
|
|
2010-12-21 14:07:45 +00:00
|
|
|
/* Called by the exiting task */
|
2009-12-04 13:52:42 +00:00
|
|
|
void exit_io_context(struct task_struct *task)
|
2008-01-29 13:53:40 +00:00
|
|
|
{
|
|
|
|
struct io_context *ioc;
|
|
|
|
|
block: make ioc get/put interface more conventional and fix race on alloction
Ignoring copy_io() during fork, io_context can be allocated from two
places - current_io_context() and set_task_ioprio(). The former is
always called from local task while the latter can be called from
different task. The synchornization between them are peculiar and
dubious.
* current_io_context() doesn't grab task_lock() and assumes that if it
saw %NULL ->io_context, it would stay that way until allocation and
assignment is complete. It has smp_wmb() between alloc/init and
assignment.
* set_task_ioprio() grabs task_lock() for assignment and does
smp_read_barrier_depends() between "ioc = task->io_context" and "if
(ioc)". Unfortunately, this doesn't achieve anything - the latter
is not a dependent load of the former. ie, if ioc itself were being
dereferenced "ioc->xxx", it would mean something (not sure what tho)
but as the code currently stands, the dependent read barrier is
noop.
As only one of the the two test-assignment sequences is task_lock()
protected, the task_lock() can't do much about race between the two.
Nothing prevents current_io_context() and set_task_ioprio() allocating
its own ioc for the same task and overwriting the other's.
Also, set_task_ioprio() can race with exiting task and create a new
ioc after exit_io_context() is finished.
ioc get/put doesn't have any reason to be complex. The only hot path
is accessing the existing ioc of %current, which is simple to achieve
given that ->io_context is never destroyed as long as the task is
alive. All other paths can happily go through task_lock() like all
other task sub structures without impacting anything.
This patch updates ioc get/put so that it becomes more conventional.
* alloc_io_context() is replaced with get_task_io_context(). This is
the only interface which can acquire access to ioc of another task.
On return, the caller has an explicit reference to the object which
should be put using put_io_context() afterwards.
* The functionality of current_io_context() remains the same but when
creating a new ioc, it shares the code path with
get_task_io_context() and always goes through task_lock().
* get_io_context() now means incrementing ref on an ioc which the
caller already has access to (be that an explicit refcnt or implicit
%current one).
* PF_EXITING inhibits creation of new io_context and once
exit_io_context() is finished, it's guaranteed that both ioc
acquisition functions return %NULL.
* All users are updated. Most are trivial but
smp_read_barrier_depends() removal from cfq_get_io_context() needs a
bit of explanation. I suppose the original intention was to ensure
ioc->ioprio is visible when set_task_ioprio() allocates new
io_context and installs it; however, this wouldn't have worked
because set_task_ioprio() doesn't have wmb between init and install.
There are other problems with this which will be fixed in another
patch.
* While at it, use NUMA_NO_NODE instead of -1 for wildcard node
specification.
-v2: Vivek spotted contamination from debug patch. Removed.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2011-12-13 23:33:38 +00:00
|
|
|
/* PF_EXITING prevents new io_context from being attached to @task */
|
|
|
|
WARN_ON_ONCE(!(current->flags & PF_EXITING));
|
|
|
|
|
2009-12-04 13:52:42 +00:00
|
|
|
task_lock(task);
|
|
|
|
ioc = task->io_context;
|
|
|
|
task->io_context = NULL;
|
|
|
|
task_unlock(task);
|
2008-01-29 13:53:40 +00:00
|
|
|
|
2011-12-13 23:33:39 +00:00
|
|
|
atomic_dec(&ioc->nr_tasks);
|
|
|
|
put_io_context(ioc, NULL);
|
2008-01-29 13:53:40 +00:00
|
|
|
}
|
|
|
|
|
2011-12-13 23:33:40 +00:00
|
|
|
void create_io_context_slowpath(struct task_struct *task, gfp_t gfp_flags,
|
|
|
|
int node)
|
2008-01-29 13:53:40 +00:00
|
|
|
{
|
2011-06-06 03:11:34 +00:00
|
|
|
struct io_context *ioc;
|
2008-01-29 13:53:40 +00:00
|
|
|
|
2011-12-13 23:33:37 +00:00
|
|
|
ioc = kmem_cache_alloc_node(iocontext_cachep, gfp_flags | __GFP_ZERO,
|
|
|
|
node);
|
|
|
|
if (unlikely(!ioc))
|
2011-12-13 23:33:40 +00:00
|
|
|
return;
|
2011-12-13 23:33:37 +00:00
|
|
|
|
|
|
|
/* initialize */
|
|
|
|
atomic_long_set(&ioc->refcount, 1);
|
|
|
|
atomic_set(&ioc->nr_tasks, 1);
|
|
|
|
spin_lock_init(&ioc->lock);
|
2011-12-13 23:33:41 +00:00
|
|
|
INIT_RADIX_TREE(&ioc->icq_tree, GFP_ATOMIC | __GFP_HIGH);
|
|
|
|
INIT_HLIST_HEAD(&ioc->icq_list);
|
2011-12-13 23:33:39 +00:00
|
|
|
INIT_WORK(&ioc->release_work, ioc_release_fn);
|
2008-01-29 13:53:40 +00:00
|
|
|
|
block: make ioc get/put interface more conventional and fix race on alloction
Ignoring copy_io() during fork, io_context can be allocated from two
places - current_io_context() and set_task_ioprio(). The former is
always called from local task while the latter can be called from
different task. The synchornization between them are peculiar and
dubious.
* current_io_context() doesn't grab task_lock() and assumes that if it
saw %NULL ->io_context, it would stay that way until allocation and
assignment is complete. It has smp_wmb() between alloc/init and
assignment.
* set_task_ioprio() grabs task_lock() for assignment and does
smp_read_barrier_depends() between "ioc = task->io_context" and "if
(ioc)". Unfortunately, this doesn't achieve anything - the latter
is not a dependent load of the former. ie, if ioc itself were being
dereferenced "ioc->xxx", it would mean something (not sure what tho)
but as the code currently stands, the dependent read barrier is
noop.
As only one of the the two test-assignment sequences is task_lock()
protected, the task_lock() can't do much about race between the two.
Nothing prevents current_io_context() and set_task_ioprio() allocating
its own ioc for the same task and overwriting the other's.
Also, set_task_ioprio() can race with exiting task and create a new
ioc after exit_io_context() is finished.
ioc get/put doesn't have any reason to be complex. The only hot path
is accessing the existing ioc of %current, which is simple to achieve
given that ->io_context is never destroyed as long as the task is
alive. All other paths can happily go through task_lock() like all
other task sub structures without impacting anything.
This patch updates ioc get/put so that it becomes more conventional.
* alloc_io_context() is replaced with get_task_io_context(). This is
the only interface which can acquire access to ioc of another task.
On return, the caller has an explicit reference to the object which
should be put using put_io_context() afterwards.
* The functionality of current_io_context() remains the same but when
creating a new ioc, it shares the code path with
get_task_io_context() and always goes through task_lock().
* get_io_context() now means incrementing ref on an ioc which the
caller already has access to (be that an explicit refcnt or implicit
%current one).
* PF_EXITING inhibits creation of new io_context and once
exit_io_context() is finished, it's guaranteed that both ioc
acquisition functions return %NULL.
* All users are updated. Most are trivial but
smp_read_barrier_depends() removal from cfq_get_io_context() needs a
bit of explanation. I suppose the original intention was to ensure
ioc->ioprio is visible when set_task_ioprio() allocates new
io_context and installs it; however, this wouldn't have worked
because set_task_ioprio() doesn't have wmb between init and install.
There are other problems with this which will be fixed in another
patch.
* While at it, use NUMA_NO_NODE instead of -1 for wildcard node
specification.
-v2: Vivek spotted contamination from debug patch. Removed.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2011-12-13 23:33:38 +00:00
|
|
|
/* try to install, somebody might already have beaten us to it */
|
|
|
|
task_lock(task);
|
2011-12-13 23:33:40 +00:00
|
|
|
if (!task->io_context && !(task->flags & PF_EXITING))
|
block: make ioc get/put interface more conventional and fix race on alloction
Ignoring copy_io() during fork, io_context can be allocated from two
places - current_io_context() and set_task_ioprio(). The former is
always called from local task while the latter can be called from
different task. The synchornization between them are peculiar and
dubious.
* current_io_context() doesn't grab task_lock() and assumes that if it
saw %NULL ->io_context, it would stay that way until allocation and
assignment is complete. It has smp_wmb() between alloc/init and
assignment.
* set_task_ioprio() grabs task_lock() for assignment and does
smp_read_barrier_depends() between "ioc = task->io_context" and "if
(ioc)". Unfortunately, this doesn't achieve anything - the latter
is not a dependent load of the former. ie, if ioc itself were being
dereferenced "ioc->xxx", it would mean something (not sure what tho)
but as the code currently stands, the dependent read barrier is
noop.
As only one of the the two test-assignment sequences is task_lock()
protected, the task_lock() can't do much about race between the two.
Nothing prevents current_io_context() and set_task_ioprio() allocating
its own ioc for the same task and overwriting the other's.
Also, set_task_ioprio() can race with exiting task and create a new
ioc after exit_io_context() is finished.
ioc get/put doesn't have any reason to be complex. The only hot path
is accessing the existing ioc of %current, which is simple to achieve
given that ->io_context is never destroyed as long as the task is
alive. All other paths can happily go through task_lock() like all
other task sub structures without impacting anything.
This patch updates ioc get/put so that it becomes more conventional.
* alloc_io_context() is replaced with get_task_io_context(). This is
the only interface which can acquire access to ioc of another task.
On return, the caller has an explicit reference to the object which
should be put using put_io_context() afterwards.
* The functionality of current_io_context() remains the same but when
creating a new ioc, it shares the code path with
get_task_io_context() and always goes through task_lock().
* get_io_context() now means incrementing ref on an ioc which the
caller already has access to (be that an explicit refcnt or implicit
%current one).
* PF_EXITING inhibits creation of new io_context and once
exit_io_context() is finished, it's guaranteed that both ioc
acquisition functions return %NULL.
* All users are updated. Most are trivial but
smp_read_barrier_depends() removal from cfq_get_io_context() needs a
bit of explanation. I suppose the original intention was to ensure
ioc->ioprio is visible when set_task_ioprio() allocates new
io_context and installs it; however, this wouldn't have worked
because set_task_ioprio() doesn't have wmb between init and install.
There are other problems with this which will be fixed in another
patch.
* While at it, use NUMA_NO_NODE instead of -1 for wildcard node
specification.
-v2: Vivek spotted contamination from debug patch. Removed.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2011-12-13 23:33:38 +00:00
|
|
|
task->io_context = ioc;
|
2011-12-13 23:33:40 +00:00
|
|
|
else
|
block: make ioc get/put interface more conventional and fix race on alloction
Ignoring copy_io() during fork, io_context can be allocated from two
places - current_io_context() and set_task_ioprio(). The former is
always called from local task while the latter can be called from
different task. The synchornization between them are peculiar and
dubious.
* current_io_context() doesn't grab task_lock() and assumes that if it
saw %NULL ->io_context, it would stay that way until allocation and
assignment is complete. It has smp_wmb() between alloc/init and
assignment.
* set_task_ioprio() grabs task_lock() for assignment and does
smp_read_barrier_depends() between "ioc = task->io_context" and "if
(ioc)". Unfortunately, this doesn't achieve anything - the latter
is not a dependent load of the former. ie, if ioc itself were being
dereferenced "ioc->xxx", it would mean something (not sure what tho)
but as the code currently stands, the dependent read barrier is
noop.
As only one of the the two test-assignment sequences is task_lock()
protected, the task_lock() can't do much about race between the two.
Nothing prevents current_io_context() and set_task_ioprio() allocating
its own ioc for the same task and overwriting the other's.
Also, set_task_ioprio() can race with exiting task and create a new
ioc after exit_io_context() is finished.
ioc get/put doesn't have any reason to be complex. The only hot path
is accessing the existing ioc of %current, which is simple to achieve
given that ->io_context is never destroyed as long as the task is
alive. All other paths can happily go through task_lock() like all
other task sub structures without impacting anything.
This patch updates ioc get/put so that it becomes more conventional.
* alloc_io_context() is replaced with get_task_io_context(). This is
the only interface which can acquire access to ioc of another task.
On return, the caller has an explicit reference to the object which
should be put using put_io_context() afterwards.
* The functionality of current_io_context() remains the same but when
creating a new ioc, it shares the code path with
get_task_io_context() and always goes through task_lock().
* get_io_context() now means incrementing ref on an ioc which the
caller already has access to (be that an explicit refcnt or implicit
%current one).
* PF_EXITING inhibits creation of new io_context and once
exit_io_context() is finished, it's guaranteed that both ioc
acquisition functions return %NULL.
* All users are updated. Most are trivial but
smp_read_barrier_depends() removal from cfq_get_io_context() needs a
bit of explanation. I suppose the original intention was to ensure
ioc->ioprio is visible when set_task_ioprio() allocates new
io_context and installs it; however, this wouldn't have worked
because set_task_ioprio() doesn't have wmb between init and install.
There are other problems with this which will be fixed in another
patch.
* While at it, use NUMA_NO_NODE instead of -1 for wildcard node
specification.
-v2: Vivek spotted contamination from debug patch. Removed.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2011-12-13 23:33:38 +00:00
|
|
|
kmem_cache_free(iocontext_cachep, ioc);
|
|
|
|
task_unlock(task);
|
2008-01-29 13:53:40 +00:00
|
|
|
}
|
2011-12-13 23:33:40 +00:00
|
|
|
EXPORT_SYMBOL(create_io_context_slowpath);
|
2008-01-29 13:53:40 +00:00
|
|
|
|
block: make ioc get/put interface more conventional and fix race on alloction
Ignoring copy_io() during fork, io_context can be allocated from two
places - current_io_context() and set_task_ioprio(). The former is
always called from local task while the latter can be called from
different task. The synchornization between them are peculiar and
dubious.
* current_io_context() doesn't grab task_lock() and assumes that if it
saw %NULL ->io_context, it would stay that way until allocation and
assignment is complete. It has smp_wmb() between alloc/init and
assignment.
* set_task_ioprio() grabs task_lock() for assignment and does
smp_read_barrier_depends() between "ioc = task->io_context" and "if
(ioc)". Unfortunately, this doesn't achieve anything - the latter
is not a dependent load of the former. ie, if ioc itself were being
dereferenced "ioc->xxx", it would mean something (not sure what tho)
but as the code currently stands, the dependent read barrier is
noop.
As only one of the the two test-assignment sequences is task_lock()
protected, the task_lock() can't do much about race between the two.
Nothing prevents current_io_context() and set_task_ioprio() allocating
its own ioc for the same task and overwriting the other's.
Also, set_task_ioprio() can race with exiting task and create a new
ioc after exit_io_context() is finished.
ioc get/put doesn't have any reason to be complex. The only hot path
is accessing the existing ioc of %current, which is simple to achieve
given that ->io_context is never destroyed as long as the task is
alive. All other paths can happily go through task_lock() like all
other task sub structures without impacting anything.
This patch updates ioc get/put so that it becomes more conventional.
* alloc_io_context() is replaced with get_task_io_context(). This is
the only interface which can acquire access to ioc of another task.
On return, the caller has an explicit reference to the object which
should be put using put_io_context() afterwards.
* The functionality of current_io_context() remains the same but when
creating a new ioc, it shares the code path with
get_task_io_context() and always goes through task_lock().
* get_io_context() now means incrementing ref on an ioc which the
caller already has access to (be that an explicit refcnt or implicit
%current one).
* PF_EXITING inhibits creation of new io_context and once
exit_io_context() is finished, it's guaranteed that both ioc
acquisition functions return %NULL.
* All users are updated. Most are trivial but
smp_read_barrier_depends() removal from cfq_get_io_context() needs a
bit of explanation. I suppose the original intention was to ensure
ioc->ioprio is visible when set_task_ioprio() allocates new
io_context and installs it; however, this wouldn't have worked
because set_task_ioprio() doesn't have wmb between init and install.
There are other problems with this which will be fixed in another
patch.
* While at it, use NUMA_NO_NODE instead of -1 for wildcard node
specification.
-v2: Vivek spotted contamination from debug patch. Removed.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2011-12-13 23:33:38 +00:00
|
|
|
/**
|
|
|
|
* get_task_io_context - get io_context of a task
|
|
|
|
* @task: task of interest
|
|
|
|
* @gfp_flags: allocation flags, used if allocation is necessary
|
|
|
|
* @node: allocation node, used if allocation is necessary
|
|
|
|
*
|
|
|
|
* Return io_context of @task. If it doesn't exist, it is created with
|
|
|
|
* @gfp_flags and @node. The returned io_context has its reference count
|
|
|
|
* incremented.
|
2008-01-29 13:53:40 +00:00
|
|
|
*
|
block: make ioc get/put interface more conventional and fix race on alloction
Ignoring copy_io() during fork, io_context can be allocated from two
places - current_io_context() and set_task_ioprio(). The former is
always called from local task while the latter can be called from
different task. The synchornization between them are peculiar and
dubious.
* current_io_context() doesn't grab task_lock() and assumes that if it
saw %NULL ->io_context, it would stay that way until allocation and
assignment is complete. It has smp_wmb() between alloc/init and
assignment.
* set_task_ioprio() grabs task_lock() for assignment and does
smp_read_barrier_depends() between "ioc = task->io_context" and "if
(ioc)". Unfortunately, this doesn't achieve anything - the latter
is not a dependent load of the former. ie, if ioc itself were being
dereferenced "ioc->xxx", it would mean something (not sure what tho)
but as the code currently stands, the dependent read barrier is
noop.
As only one of the the two test-assignment sequences is task_lock()
protected, the task_lock() can't do much about race between the two.
Nothing prevents current_io_context() and set_task_ioprio() allocating
its own ioc for the same task and overwriting the other's.
Also, set_task_ioprio() can race with exiting task and create a new
ioc after exit_io_context() is finished.
ioc get/put doesn't have any reason to be complex. The only hot path
is accessing the existing ioc of %current, which is simple to achieve
given that ->io_context is never destroyed as long as the task is
alive. All other paths can happily go through task_lock() like all
other task sub structures without impacting anything.
This patch updates ioc get/put so that it becomes more conventional.
* alloc_io_context() is replaced with get_task_io_context(). This is
the only interface which can acquire access to ioc of another task.
On return, the caller has an explicit reference to the object which
should be put using put_io_context() afterwards.
* The functionality of current_io_context() remains the same but when
creating a new ioc, it shares the code path with
get_task_io_context() and always goes through task_lock().
* get_io_context() now means incrementing ref on an ioc which the
caller already has access to (be that an explicit refcnt or implicit
%current one).
* PF_EXITING inhibits creation of new io_context and once
exit_io_context() is finished, it's guaranteed that both ioc
acquisition functions return %NULL.
* All users are updated. Most are trivial but
smp_read_barrier_depends() removal from cfq_get_io_context() needs a
bit of explanation. I suppose the original intention was to ensure
ioc->ioprio is visible when set_task_ioprio() allocates new
io_context and installs it; however, this wouldn't have worked
because set_task_ioprio() doesn't have wmb between init and install.
There are other problems with this which will be fixed in another
patch.
* While at it, use NUMA_NO_NODE instead of -1 for wildcard node
specification.
-v2: Vivek spotted contamination from debug patch. Removed.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2011-12-13 23:33:38 +00:00
|
|
|
* This function always goes through task_lock() and it's better to use
|
2011-12-13 23:33:40 +00:00
|
|
|
* %current->io_context + get_io_context() for %current.
|
2008-01-29 13:53:40 +00:00
|
|
|
*/
|
block: make ioc get/put interface more conventional and fix race on alloction
Ignoring copy_io() during fork, io_context can be allocated from two
places - current_io_context() and set_task_ioprio(). The former is
always called from local task while the latter can be called from
different task. The synchornization between them are peculiar and
dubious.
* current_io_context() doesn't grab task_lock() and assumes that if it
saw %NULL ->io_context, it would stay that way until allocation and
assignment is complete. It has smp_wmb() between alloc/init and
assignment.
* set_task_ioprio() grabs task_lock() for assignment and does
smp_read_barrier_depends() between "ioc = task->io_context" and "if
(ioc)". Unfortunately, this doesn't achieve anything - the latter
is not a dependent load of the former. ie, if ioc itself were being
dereferenced "ioc->xxx", it would mean something (not sure what tho)
but as the code currently stands, the dependent read barrier is
noop.
As only one of the the two test-assignment sequences is task_lock()
protected, the task_lock() can't do much about race between the two.
Nothing prevents current_io_context() and set_task_ioprio() allocating
its own ioc for the same task and overwriting the other's.
Also, set_task_ioprio() can race with exiting task and create a new
ioc after exit_io_context() is finished.
ioc get/put doesn't have any reason to be complex. The only hot path
is accessing the existing ioc of %current, which is simple to achieve
given that ->io_context is never destroyed as long as the task is
alive. All other paths can happily go through task_lock() like all
other task sub structures without impacting anything.
This patch updates ioc get/put so that it becomes more conventional.
* alloc_io_context() is replaced with get_task_io_context(). This is
the only interface which can acquire access to ioc of another task.
On return, the caller has an explicit reference to the object which
should be put using put_io_context() afterwards.
* The functionality of current_io_context() remains the same but when
creating a new ioc, it shares the code path with
get_task_io_context() and always goes through task_lock().
* get_io_context() now means incrementing ref on an ioc which the
caller already has access to (be that an explicit refcnt or implicit
%current one).
* PF_EXITING inhibits creation of new io_context and once
exit_io_context() is finished, it's guaranteed that both ioc
acquisition functions return %NULL.
* All users are updated. Most are trivial but
smp_read_barrier_depends() removal from cfq_get_io_context() needs a
bit of explanation. I suppose the original intention was to ensure
ioc->ioprio is visible when set_task_ioprio() allocates new
io_context and installs it; however, this wouldn't have worked
because set_task_ioprio() doesn't have wmb between init and install.
There are other problems with this which will be fixed in another
patch.
* While at it, use NUMA_NO_NODE instead of -1 for wildcard node
specification.
-v2: Vivek spotted contamination from debug patch. Removed.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2011-12-13 23:33:38 +00:00
|
|
|
struct io_context *get_task_io_context(struct task_struct *task,
|
|
|
|
gfp_t gfp_flags, int node)
|
2008-01-29 13:53:40 +00:00
|
|
|
{
|
block: make ioc get/put interface more conventional and fix race on alloction
Ignoring copy_io() during fork, io_context can be allocated from two
places - current_io_context() and set_task_ioprio(). The former is
always called from local task while the latter can be called from
different task. The synchornization between them are peculiar and
dubious.
* current_io_context() doesn't grab task_lock() and assumes that if it
saw %NULL ->io_context, it would stay that way until allocation and
assignment is complete. It has smp_wmb() between alloc/init and
assignment.
* set_task_ioprio() grabs task_lock() for assignment and does
smp_read_barrier_depends() between "ioc = task->io_context" and "if
(ioc)". Unfortunately, this doesn't achieve anything - the latter
is not a dependent load of the former. ie, if ioc itself were being
dereferenced "ioc->xxx", it would mean something (not sure what tho)
but as the code currently stands, the dependent read barrier is
noop.
As only one of the the two test-assignment sequences is task_lock()
protected, the task_lock() can't do much about race between the two.
Nothing prevents current_io_context() and set_task_ioprio() allocating
its own ioc for the same task and overwriting the other's.
Also, set_task_ioprio() can race with exiting task and create a new
ioc after exit_io_context() is finished.
ioc get/put doesn't have any reason to be complex. The only hot path
is accessing the existing ioc of %current, which is simple to achieve
given that ->io_context is never destroyed as long as the task is
alive. All other paths can happily go through task_lock() like all
other task sub structures without impacting anything.
This patch updates ioc get/put so that it becomes more conventional.
* alloc_io_context() is replaced with get_task_io_context(). This is
the only interface which can acquire access to ioc of another task.
On return, the caller has an explicit reference to the object which
should be put using put_io_context() afterwards.
* The functionality of current_io_context() remains the same but when
creating a new ioc, it shares the code path with
get_task_io_context() and always goes through task_lock().
* get_io_context() now means incrementing ref on an ioc which the
caller already has access to (be that an explicit refcnt or implicit
%current one).
* PF_EXITING inhibits creation of new io_context and once
exit_io_context() is finished, it's guaranteed that both ioc
acquisition functions return %NULL.
* All users are updated. Most are trivial but
smp_read_barrier_depends() removal from cfq_get_io_context() needs a
bit of explanation. I suppose the original intention was to ensure
ioc->ioprio is visible when set_task_ioprio() allocates new
io_context and installs it; however, this wouldn't have worked
because set_task_ioprio() doesn't have wmb between init and install.
There are other problems with this which will be fixed in another
patch.
* While at it, use NUMA_NO_NODE instead of -1 for wildcard node
specification.
-v2: Vivek spotted contamination from debug patch. Removed.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2011-12-13 23:33:38 +00:00
|
|
|
struct io_context *ioc;
|
2008-01-29 13:53:40 +00:00
|
|
|
|
block: make ioc get/put interface more conventional and fix race on alloction
Ignoring copy_io() during fork, io_context can be allocated from two
places - current_io_context() and set_task_ioprio(). The former is
always called from local task while the latter can be called from
different task. The synchornization between them are peculiar and
dubious.
* current_io_context() doesn't grab task_lock() and assumes that if it
saw %NULL ->io_context, it would stay that way until allocation and
assignment is complete. It has smp_wmb() between alloc/init and
assignment.
* set_task_ioprio() grabs task_lock() for assignment and does
smp_read_barrier_depends() between "ioc = task->io_context" and "if
(ioc)". Unfortunately, this doesn't achieve anything - the latter
is not a dependent load of the former. ie, if ioc itself were being
dereferenced "ioc->xxx", it would mean something (not sure what tho)
but as the code currently stands, the dependent read barrier is
noop.
As only one of the the two test-assignment sequences is task_lock()
protected, the task_lock() can't do much about race between the two.
Nothing prevents current_io_context() and set_task_ioprio() allocating
its own ioc for the same task and overwriting the other's.
Also, set_task_ioprio() can race with exiting task and create a new
ioc after exit_io_context() is finished.
ioc get/put doesn't have any reason to be complex. The only hot path
is accessing the existing ioc of %current, which is simple to achieve
given that ->io_context is never destroyed as long as the task is
alive. All other paths can happily go through task_lock() like all
other task sub structures without impacting anything.
This patch updates ioc get/put so that it becomes more conventional.
* alloc_io_context() is replaced with get_task_io_context(). This is
the only interface which can acquire access to ioc of another task.
On return, the caller has an explicit reference to the object which
should be put using put_io_context() afterwards.
* The functionality of current_io_context() remains the same but when
creating a new ioc, it shares the code path with
get_task_io_context() and always goes through task_lock().
* get_io_context() now means incrementing ref on an ioc which the
caller already has access to (be that an explicit refcnt or implicit
%current one).
* PF_EXITING inhibits creation of new io_context and once
exit_io_context() is finished, it's guaranteed that both ioc
acquisition functions return %NULL.
* All users are updated. Most are trivial but
smp_read_barrier_depends() removal from cfq_get_io_context() needs a
bit of explanation. I suppose the original intention was to ensure
ioc->ioprio is visible when set_task_ioprio() allocates new
io_context and installs it; however, this wouldn't have worked
because set_task_ioprio() doesn't have wmb between init and install.
There are other problems with this which will be fixed in another
patch.
* While at it, use NUMA_NO_NODE instead of -1 for wildcard node
specification.
-v2: Vivek spotted contamination from debug patch. Removed.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2011-12-13 23:33:38 +00:00
|
|
|
might_sleep_if(gfp_flags & __GFP_WAIT);
|
|
|
|
|
2011-12-13 23:33:40 +00:00
|
|
|
do {
|
|
|
|
task_lock(task);
|
|
|
|
ioc = task->io_context;
|
|
|
|
if (likely(ioc)) {
|
|
|
|
get_io_context(ioc);
|
|
|
|
task_unlock(task);
|
|
|
|
return ioc;
|
|
|
|
}
|
block: make ioc get/put interface more conventional and fix race on alloction
Ignoring copy_io() during fork, io_context can be allocated from two
places - current_io_context() and set_task_ioprio(). The former is
always called from local task while the latter can be called from
different task. The synchornization between them are peculiar and
dubious.
* current_io_context() doesn't grab task_lock() and assumes that if it
saw %NULL ->io_context, it would stay that way until allocation and
assignment is complete. It has smp_wmb() between alloc/init and
assignment.
* set_task_ioprio() grabs task_lock() for assignment and does
smp_read_barrier_depends() between "ioc = task->io_context" and "if
(ioc)". Unfortunately, this doesn't achieve anything - the latter
is not a dependent load of the former. ie, if ioc itself were being
dereferenced "ioc->xxx", it would mean something (not sure what tho)
but as the code currently stands, the dependent read barrier is
noop.
As only one of the the two test-assignment sequences is task_lock()
protected, the task_lock() can't do much about race between the two.
Nothing prevents current_io_context() and set_task_ioprio() allocating
its own ioc for the same task and overwriting the other's.
Also, set_task_ioprio() can race with exiting task and create a new
ioc after exit_io_context() is finished.
ioc get/put doesn't have any reason to be complex. The only hot path
is accessing the existing ioc of %current, which is simple to achieve
given that ->io_context is never destroyed as long as the task is
alive. All other paths can happily go through task_lock() like all
other task sub structures without impacting anything.
This patch updates ioc get/put so that it becomes more conventional.
* alloc_io_context() is replaced with get_task_io_context(). This is
the only interface which can acquire access to ioc of another task.
On return, the caller has an explicit reference to the object which
should be put using put_io_context() afterwards.
* The functionality of current_io_context() remains the same but when
creating a new ioc, it shares the code path with
get_task_io_context() and always goes through task_lock().
* get_io_context() now means incrementing ref on an ioc which the
caller already has access to (be that an explicit refcnt or implicit
%current one).
* PF_EXITING inhibits creation of new io_context and once
exit_io_context() is finished, it's guaranteed that both ioc
acquisition functions return %NULL.
* All users are updated. Most are trivial but
smp_read_barrier_depends() removal from cfq_get_io_context() needs a
bit of explanation. I suppose the original intention was to ensure
ioc->ioprio is visible when set_task_ioprio() allocates new
io_context and installs it; however, this wouldn't have worked
because set_task_ioprio() doesn't have wmb between init and install.
There are other problems with this which will be fixed in another
patch.
* While at it, use NUMA_NO_NODE instead of -1 for wildcard node
specification.
-v2: Vivek spotted contamination from debug patch. Removed.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2011-12-13 23:33:38 +00:00
|
|
|
task_unlock(task);
|
2011-12-13 23:33:40 +00:00
|
|
|
} while (create_io_context(task, gfp_flags, node));
|
block: make ioc get/put interface more conventional and fix race on alloction
Ignoring copy_io() during fork, io_context can be allocated from two
places - current_io_context() and set_task_ioprio(). The former is
always called from local task while the latter can be called from
different task. The synchornization between them are peculiar and
dubious.
* current_io_context() doesn't grab task_lock() and assumes that if it
saw %NULL ->io_context, it would stay that way until allocation and
assignment is complete. It has smp_wmb() between alloc/init and
assignment.
* set_task_ioprio() grabs task_lock() for assignment and does
smp_read_barrier_depends() between "ioc = task->io_context" and "if
(ioc)". Unfortunately, this doesn't achieve anything - the latter
is not a dependent load of the former. ie, if ioc itself were being
dereferenced "ioc->xxx", it would mean something (not sure what tho)
but as the code currently stands, the dependent read barrier is
noop.
As only one of the the two test-assignment sequences is task_lock()
protected, the task_lock() can't do much about race between the two.
Nothing prevents current_io_context() and set_task_ioprio() allocating
its own ioc for the same task and overwriting the other's.
Also, set_task_ioprio() can race with exiting task and create a new
ioc after exit_io_context() is finished.
ioc get/put doesn't have any reason to be complex. The only hot path
is accessing the existing ioc of %current, which is simple to achieve
given that ->io_context is never destroyed as long as the task is
alive. All other paths can happily go through task_lock() like all
other task sub structures without impacting anything.
This patch updates ioc get/put so that it becomes more conventional.
* alloc_io_context() is replaced with get_task_io_context(). This is
the only interface which can acquire access to ioc of another task.
On return, the caller has an explicit reference to the object which
should be put using put_io_context() afterwards.
* The functionality of current_io_context() remains the same but when
creating a new ioc, it shares the code path with
get_task_io_context() and always goes through task_lock().
* get_io_context() now means incrementing ref on an ioc which the
caller already has access to (be that an explicit refcnt or implicit
%current one).
* PF_EXITING inhibits creation of new io_context and once
exit_io_context() is finished, it's guaranteed that both ioc
acquisition functions return %NULL.
* All users are updated. Most are trivial but
smp_read_barrier_depends() removal from cfq_get_io_context() needs a
bit of explanation. I suppose the original intention was to ensure
ioc->ioprio is visible when set_task_ioprio() allocates new
io_context and installs it; however, this wouldn't have worked
because set_task_ioprio() doesn't have wmb between init and install.
There are other problems with this which will be fixed in another
patch.
* While at it, use NUMA_NO_NODE instead of -1 for wildcard node
specification.
-v2: Vivek spotted contamination from debug patch. Removed.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2011-12-13 23:33:38 +00:00
|
|
|
|
2011-12-13 23:33:40 +00:00
|
|
|
return NULL;
|
2008-01-29 13:53:40 +00:00
|
|
|
}
|
block: make ioc get/put interface more conventional and fix race on alloction
Ignoring copy_io() during fork, io_context can be allocated from two
places - current_io_context() and set_task_ioprio(). The former is
always called from local task while the latter can be called from
different task. The synchornization between them are peculiar and
dubious.
* current_io_context() doesn't grab task_lock() and assumes that if it
saw %NULL ->io_context, it would stay that way until allocation and
assignment is complete. It has smp_wmb() between alloc/init and
assignment.
* set_task_ioprio() grabs task_lock() for assignment and does
smp_read_barrier_depends() between "ioc = task->io_context" and "if
(ioc)". Unfortunately, this doesn't achieve anything - the latter
is not a dependent load of the former. ie, if ioc itself were being
dereferenced "ioc->xxx", it would mean something (not sure what tho)
but as the code currently stands, the dependent read barrier is
noop.
As only one of the the two test-assignment sequences is task_lock()
protected, the task_lock() can't do much about race between the two.
Nothing prevents current_io_context() and set_task_ioprio() allocating
its own ioc for the same task and overwriting the other's.
Also, set_task_ioprio() can race with exiting task and create a new
ioc after exit_io_context() is finished.
ioc get/put doesn't have any reason to be complex. The only hot path
is accessing the existing ioc of %current, which is simple to achieve
given that ->io_context is never destroyed as long as the task is
alive. All other paths can happily go through task_lock() like all
other task sub structures without impacting anything.
This patch updates ioc get/put so that it becomes more conventional.
* alloc_io_context() is replaced with get_task_io_context(). This is
the only interface which can acquire access to ioc of another task.
On return, the caller has an explicit reference to the object which
should be put using put_io_context() afterwards.
* The functionality of current_io_context() remains the same but when
creating a new ioc, it shares the code path with
get_task_io_context() and always goes through task_lock().
* get_io_context() now means incrementing ref on an ioc which the
caller already has access to (be that an explicit refcnt or implicit
%current one).
* PF_EXITING inhibits creation of new io_context and once
exit_io_context() is finished, it's guaranteed that both ioc
acquisition functions return %NULL.
* All users are updated. Most are trivial but
smp_read_barrier_depends() removal from cfq_get_io_context() needs a
bit of explanation. I suppose the original intention was to ensure
ioc->ioprio is visible when set_task_ioprio() allocates new
io_context and installs it; however, this wouldn't have worked
because set_task_ioprio() doesn't have wmb between init and install.
There are other problems with this which will be fixed in another
patch.
* While at it, use NUMA_NO_NODE instead of -1 for wildcard node
specification.
-v2: Vivek spotted contamination from debug patch. Removed.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2011-12-13 23:33:38 +00:00
|
|
|
EXPORT_SYMBOL(get_task_io_context);
|
2008-01-29 13:53:40 +00:00
|
|
|
|
2011-12-13 23:33:42 +00:00
|
|
|
/**
|
|
|
|
* ioc_lookup_icq - lookup io_cq from ioc
|
|
|
|
* @ioc: the associated io_context
|
|
|
|
* @q: the associated request_queue
|
|
|
|
*
|
|
|
|
* Look up io_cq associated with @ioc - @q pair from @ioc. Must be called
|
|
|
|
* with @q->queue_lock held.
|
|
|
|
*/
|
|
|
|
struct io_cq *ioc_lookup_icq(struct io_context *ioc, struct request_queue *q)
|
|
|
|
{
|
|
|
|
struct io_cq *icq;
|
|
|
|
|
|
|
|
lockdep_assert_held(q->queue_lock);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* icq's are indexed from @ioc using radix tree and hint pointer,
|
|
|
|
* both of which are protected with RCU. All removals are done
|
|
|
|
* holding both q and ioc locks, and we're holding q lock - if we
|
|
|
|
* find a icq which points to us, it's guaranteed to be valid.
|
|
|
|
*/
|
|
|
|
rcu_read_lock();
|
|
|
|
icq = rcu_dereference(ioc->icq_hint);
|
|
|
|
if (icq && icq->q == q)
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
icq = radix_tree_lookup(&ioc->icq_tree, q->id);
|
|
|
|
if (icq && icq->q == q)
|
|
|
|
rcu_assign_pointer(ioc->icq_hint, icq); /* allowed to race */
|
|
|
|
else
|
|
|
|
icq = NULL;
|
|
|
|
out:
|
|
|
|
rcu_read_unlock();
|
|
|
|
return icq;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(ioc_lookup_icq);
|
|
|
|
|
2011-12-13 23:33:38 +00:00
|
|
|
void ioc_set_changed(struct io_context *ioc, int which)
|
|
|
|
{
|
2011-12-13 23:33:41 +00:00
|
|
|
struct io_cq *icq;
|
2011-12-13 23:33:38 +00:00
|
|
|
struct hlist_node *n;
|
|
|
|
|
2011-12-13 23:33:41 +00:00
|
|
|
hlist_for_each_entry(icq, n, &ioc->icq_list, ioc_node)
|
|
|
|
set_bit(which, &icq->changed);
|
2011-12-13 23:33:38 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* ioc_ioprio_changed - notify ioprio change
|
|
|
|
* @ioc: io_context of interest
|
|
|
|
* @ioprio: new ioprio
|
|
|
|
*
|
2011-12-13 23:33:41 +00:00
|
|
|
* @ioc's ioprio has changed to @ioprio. Set %ICQ_IOPRIO_CHANGED for all
|
|
|
|
* icq's. iosched is responsible for checking the bit and applying it on
|
2011-12-13 23:33:38 +00:00
|
|
|
* request issue path.
|
|
|
|
*/
|
|
|
|
void ioc_ioprio_changed(struct io_context *ioc, int ioprio)
|
|
|
|
{
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&ioc->lock, flags);
|
|
|
|
ioc->ioprio = ioprio;
|
2011-12-13 23:33:41 +00:00
|
|
|
ioc_set_changed(ioc, ICQ_IOPRIO_CHANGED);
|
2011-12-13 23:33:38 +00:00
|
|
|
spin_unlock_irqrestore(&ioc->lock, flags);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* ioc_cgroup_changed - notify cgroup change
|
|
|
|
* @ioc: io_context of interest
|
|
|
|
*
|
2011-12-13 23:33:41 +00:00
|
|
|
* @ioc's cgroup has changed. Set %ICQ_CGROUP_CHANGED for all icq's.
|
2011-12-13 23:33:38 +00:00
|
|
|
* iosched is responsible for checking the bit and applying it on request
|
|
|
|
* issue path.
|
|
|
|
*/
|
|
|
|
void ioc_cgroup_changed(struct io_context *ioc)
|
|
|
|
{
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&ioc->lock, flags);
|
2011-12-13 23:33:41 +00:00
|
|
|
ioc_set_changed(ioc, ICQ_CGROUP_CHANGED);
|
2011-12-13 23:33:38 +00:00
|
|
|
spin_unlock_irqrestore(&ioc->lock, flags);
|
|
|
|
}
|
|
|
|
|
2008-02-18 12:45:53 +00:00
|
|
|
static int __init blk_ioc_init(void)
|
2008-01-29 13:53:40 +00:00
|
|
|
{
|
|
|
|
iocontext_cachep = kmem_cache_create("blkdev_ioc",
|
|
|
|
sizeof(struct io_context), 0, SLAB_PANIC, NULL);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
subsys_initcall(blk_ioc_init);
|