hwmon: (lm78) Fix overflow problems seen when writing large temperature limits
commit 1074d683a51f1aded3562add9ef313e75d557327 upstream. On platforms with sizeof(int) < sizeof(long), writing a temperature limit larger than MAXINT will result in unpredictable limit values written to the chip. Avoid auto-conversion from long to int to fix the problem. Cc: Axel Lin <axel.lin@ingics.com> Reviewed-by: Axel Lin <axel.lin@ingics.com> Signed-off-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
5fafb69d98
commit
070d6526cc
|
@ -108,7 +108,7 @@ static inline int FAN_FROM_REG(u8 val, int div)
|
|||
* TEMP: mC (-128C to +127C)
|
||||
* REG: 1C/bit, two's complement
|
||||
*/
|
||||
static inline s8 TEMP_TO_REG(int val)
|
||||
static inline s8 TEMP_TO_REG(long val)
|
||||
{
|
||||
int nval = clamp_val(val, -128000, 127000) ;
|
||||
return nval < 0 ? (nval - 500) / 1000 : (nval + 500) / 1000;
|
||||
|
|
Loading…
Reference in New Issue