ext[34]: fix double put in tmpfile
d_tmpfile() already swallowed the inode ref. Change-Id: I22411f145d675948cff55b5a8cc3c0cd3a0d484c Signed-off-by: Miklos Szeredi <mszeredi@suse.cz> Cc: stable@vger.kernel.org Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
parent
2a5d64d372
commit
1a75c3190f
|
@ -1783,7 +1783,7 @@ retry:
|
|||
d_tmpfile(dentry, inode);
|
||||
err = ext3_orphan_add(handle, inode);
|
||||
if (err)
|
||||
goto err_drop_inode;
|
||||
goto err_unlock_inode;
|
||||
mark_inode_dirty(inode);
|
||||
unlock_new_inode(inode);
|
||||
}
|
||||
|
@ -1791,10 +1791,9 @@ retry:
|
|||
if (err == -ENOSPC && ext3_should_retry_alloc(dir->i_sb, &retries))
|
||||
goto retry;
|
||||
return err;
|
||||
err_drop_inode:
|
||||
err_unlock_inode:
|
||||
ext3_journal_stop(handle);
|
||||
unlock_new_inode(inode);
|
||||
iput(inode);
|
||||
return err;
|
||||
}
|
||||
|
||||
|
|
|
@ -2329,7 +2329,7 @@ retry:
|
|||
d_tmpfile(dentry, inode);
|
||||
err = ext4_orphan_add(handle, inode);
|
||||
if (err)
|
||||
goto err_drop_inode;
|
||||
goto err_unlock_inode;
|
||||
mark_inode_dirty(inode);
|
||||
unlock_new_inode(inode);
|
||||
}
|
||||
|
@ -2338,10 +2338,9 @@ retry:
|
|||
if (err == -ENOSPC && ext4_should_retry_alloc(dir->i_sb, &retries))
|
||||
goto retry;
|
||||
return err;
|
||||
err_drop_inode:
|
||||
err_unlock_inode:
|
||||
ext4_journal_stop(handle);
|
||||
unlock_new_inode(inode);
|
||||
iput(inode);
|
||||
return err;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in New Issue