Piteball
/
android_kernel_samsung_msm8976
mirror of https://github.com/team-infusion-developers/android_kernel_samsung_msm8976.git
1
1
Fork 0
Code Issues Projects Releases Wiki Activity

checkpatch: warn on subject line not followed by blank line 

Fixed case when no warning generated for long subject line that is
wrapped to more than one line, and all lines are less than line limit.

New warning message added:
"non-blank line after summary line"
Now there are two warnings possible for the subject line, the original
line over limit and the new one. Depending on the error(s) any
combination of the two warnings are possible.

Commit text requirements now:
1) Must be less than 75 characters
2) Must be followed by blank line.

Signed-off-by: Richard Adams <c_adams@quicinc.com>
(cherry picked from commit 78d0db4aa1212e00696e25b7daa9fc4ecd86f954)
Signed-off-by: Stepan Moskovchenko <stepanm@codeaurora.org>
This commit is contained in:
Richard Adams 2010-01-04 13:06:09 -08:00 committed by Stepan Moskovchenko
parent 2b7a4e2acd
commit 3a00583cf9
1 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
scripts/checkpatch.pl
View File

@ -11,6 +11,7 @@ use POSIX;
use constant BEFORE_SHORTTEXT => 0;
use constant IN_SHORTTEXT => 1;
use constant AFTER_SHORTTEXT => 2;
use constant CHECK_NEXT_SHORTTEXT => 3;
use constant SHORTTEXT_LIMIT => 75;
my $P = $0;
@ -1832,6 +1833,8 @@ sub process {
my $prevrawline="";
my $stashline="";
my $stashrawline="";
my $subjectline="";
my $sublinenr="";
my $length;
my $indent;
@ -2080,8 +2083,21 @@ sub process {
SHORTTEXT_LIMIT .
" characters\n" . $herecurr);
}
} elsif ($line=~/^Subject: \[[^\]]*\] (.*)/) {
} elsif ($shorttext == CHECK_NEXT_SHORTTEXT) {
$shorttext = IN_SHORTTEXT;
# Check for Subject line followed by a blank line.
if (length($line) != 0) {
WARN("NONBLANK_AFTER_SUMMARY",
"non-blank line after summary " .
"line\n" . $sublinenr . $here .
"\n" . $subjectline . "\n" .
$line . "\n");
}
} elsif ($line=~/^Subject: \[[^\]]*\] (.*)/) {
$shorttext = CHECK_NEXT_SHORTTEXT;
$subjectline = $line;
$sublinenr = "#$linenr & ";
# Check for Subject line less than line limit
if (length($1) > SHORTTEXT_LIMIT) {
WARN("LONG_SUMMARY_LINE",
"summary line over " .