diff --git a/drivers/android/binder.c b/drivers/android/binder.c index 9e9d2475051a..c24e29a96afd 100644 --- a/drivers/android/binder.c +++ b/drivers/android/binder.c @@ -680,6 +680,11 @@ static int __binder_update_page_range(struct binder_proc *proc, int allocate, if (mm) { down_write(&mm->mmap_sem); + if (!mmget_still_valid(mm)) { + if (allocate == 0) + goto free_range; + goto err_no_vma; + } vma = proc->vma; if (vma && mm != proc->vma_vm_mm) { pr_err("%d: vma mm and task mm mismatch\n", diff --git a/include/linux/sched.h b/include/linux/sched.h index 27553cffd728..78e96275d0bc 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -2407,6 +2407,27 @@ static inline void mmdrop(struct mm_struct * mm) __mmdrop(mm); } +/* + * This has to be called after a get_task_mm()/mmget_not_zero() + * followed by taking the mmap_sem for writing before modifying the + * vmas or anything the coredump pretends not to change from under it. + * + * NOTE: find_extend_vma() called from GUP context is the only place + * that can modify the "mm" (notably the vm_start/end) under mmap_sem + * for reading and outside the context of the process, so it is also + * the only case that holds the mmap_sem for reading that must call + * this function. Generally if the mmap_sem is hold for reading + * there's no need of this check after get_task_mm()/mmget_not_zero(). + * + * This function can be obsoleted and the check can be removed, after + * the coredump code will hold the mmap_sem for writing before + * invoking the ->core_dump methods. + */ +static inline bool mmget_still_valid(struct mm_struct *mm) +{ + return likely(!mm->core_state); +} + /* mmput gets rid of the mappings and all user-space */ extern void mmput(struct mm_struct *); /* Grab a reference to a task's mm, if it is not already going away */ diff --git a/mm/mmap.c b/mm/mmap.c index 7598c2598f72..03a16d87e764 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -40,6 +40,7 @@ #include #include #include +#include #include #include @@ -2353,7 +2354,8 @@ find_extend_vma(struct mm_struct *mm, unsigned long addr) vma = find_vma_prev(mm, addr, &prev); if (vma && (vma->vm_start <= addr)) return vma; - if (!prev || expand_stack(prev, addr)) + /* don't alter vm_end if the coredump is running */ + if (!prev || !mmget_still_valid(mm) || expand_stack(prev, addr)) return NULL; if (prev->vm_flags & VM_LOCKED) __mlock_vma_pages_range(prev, addr, prev->vm_end, NULL); @@ -2379,6 +2381,9 @@ find_extend_vma(struct mm_struct * mm, unsigned long addr) return vma; if (!(vma->vm_flags & VM_GROWSDOWN)) return NULL; + /* don't alter vm_start if the coredump is running */ + if (!mmget_still_valid(mm)) + return NULL; start = vma->vm_start; if (expand_stack(vma, addr)) return NULL;