qcacld-2.0: Remove redundant MTRACE logs

prima to qcacld-2.0 propagation

Currently few MTRACE logs captured repetitively which leads to
overwriting of other important MTRACE logs.
To avoid this,
1. Remove MTRACE logs which are seen repetitively in scan,
connect/disconnect path and few timer functions.
2. MTRACE log captured for few enums in both limProcessMessages() and
limProcessMlmReqMessages(). To avoid redundancy remove MTRACE in
limProcessMlmReqMessages() and add in limPostMlmMessage() for which
are not captured in limProcessMessages.
3. Similar way for limProcessSmeReqMessages() also, remove MTRACE in
limProcessSmeReqMessages() and add in limPostSmeMessage()

Change-Id: I1478f3e9ab8fb57d8b8b2f65cf2eb3450eb7b64c
CRs-Fixed: 855840
This commit is contained in:
Sreelakshmi Konamki 2016-01-27 17:23:01 +05:30 committed by syphyr
parent ca8f29a0b3
commit 4fc80d541b
8 changed files with 18 additions and 30 deletions

View File

@ -1375,12 +1375,6 @@ VOS_STATUS peHandleMgmtFrame( v_PVOID_t pvosGCtx, v_PVOID_t vosBuff)
WDA_GET_RX_MPDU_HEADER_LEN(pRxPacketInfo),
WDA_GET_RX_PAYLOAD_LEN(pRxPacketInfo));
MTRACE(macTrace(pMac, TRACE_CODE_RX_MGMT,
WDA_GET_RX_PAYLOAD_LEN(pRxPacketInfo),
LIM_TRACE_MAKE_RXMGMT(mHdr->fc.subType,
(tANI_U16) (((tANI_U16)(mHdr->seqControl.seqNumHi << 4))
| mHdr->seqControl.seqNumLo)));)
#ifdef WLAN_FEATURE_ROAM_SCAN_OFFLOAD
if (WDA_GET_ROAMCANDIDATEIND(pRxPacketInfo))
limLog(pMac, LOG1, FL("roamCandidateInd %d"),

View File

@ -1180,7 +1180,16 @@ limProcessMessages(tpAniSirGlobal pMac, tpSirMsgQ limMsg)
pMac->lim.numTot++;
#endif
MTRACE(macTraceMsgRx(pMac, NO_SESSION, LIM_TRACE_MAKE_RXMSG(limMsg->type, LIM_MSG_PROCESSED));)
/* Omitting below message types as these are too frequent and when crash
* happens we loose critical trace logs if these are also logged
*/
if (limMsg->type != SIR_LIM_MAX_CHANNEL_TIMEOUT &&
limMsg->type != SIR_LIM_MIN_CHANNEL_TIMEOUT &&
limMsg->type != SIR_LIM_PERIODIC_PROBE_REQ_TIMEOUT &&
limMsg->type != SIR_CFG_PARAM_UPDATE_IND &&
limMsg->type != SIR_BB_XPORT_MGMT_MSG)
MTRACE(macTraceMsgRx(pMac, NO_SESSION,
LIM_TRACE_MAKE_RXMSG(limMsg->type, LIM_MSG_PROCESSED));)
switch (limMsg->type)
{

View File

@ -126,7 +126,6 @@ limSetChannel(tpAniSirGlobal pMac, tANI_U8 channel, tANI_U8 secChannelOffset, tP
void
limProcessMlmReqMessages(tpAniSirGlobal pMac, tpSirMsgQ Msg)
{
MTRACE(macTraceMsgRx(pMac, NO_SESSION, Msg->type));
switch (Msg->type)
{
case LIM_MLM_START_REQ: limProcessMlmStartReq(pMac, Msg->bodyptr); break;
@ -471,9 +470,6 @@ void limContinuePostChannelScan(tpAniSirGlobal pMac)
/// Activate minChannelTimer
limDeactivateAndChangeTimer(pMac, eLIM_MIN_CHANNEL_TIMER);
MTRACE(macTrace(pMac, TRACE_CODE_TIMER_ACTIVATE, NO_SESSION, eLIM_MIN_CHANNEL_TIMER));
if (tx_timer_activate(&pMac->lim.limTimers.gLimMinChannelTimer) != TX_SUCCESS)
{
limLog(pMac, LOGP, FL("could not start min channel timer"));
@ -491,7 +487,6 @@ void limContinuePostChannelScan(tpAniSirGlobal pMac)
#endif
//No Need to start Min channel timer. Start Max Channel timer.
limDeactivateAndChangeTimer(pMac, eLIM_MAX_CHANNEL_TIMER);
MTRACE(macTrace(pMac, TRACE_CODE_TIMER_ACTIVATE, pMac->lim.limTimers.gLimMaxChannelTimer.sessionId, eLIM_MAX_CHANNEL_TIMER));
if (tx_timer_activate(&pMac->lim.limTimers.gLimMaxChannelTimer)
== TX_TIMER_ERROR)
{
@ -514,7 +509,6 @@ void limContinuePostChannelScan(tpAniSirGlobal pMac)
return;
}
periodicScanTimer->sessionId = channelNum;
MTRACE(macTrace(pMac, TRACE_CODE_TIMER_ACTIVATE, periodicScanTimer->sessionId, eLIM_PERIODIC_PROBE_REQ_TIMER));
}
else
{
@ -522,7 +516,6 @@ void limContinuePostChannelScan(tpAniSirGlobal pMac)
PELOG2(limLog(pMac, LOG2, FL("START PASSIVE Scan chan %d"), channelNum);)
/// Passive Scanning. Activate maxChannelTimer
MTRACE(macTrace(pMac, TRACE_CODE_TIMER_DEACTIVATE, NO_SESSION, eLIM_MAX_CHANNEL_TIMER));
if (tx_timer_deactivate(&pMac->lim.limTimers.gLimMaxChannelTimer)
!= TX_SUCCESS)
{
@ -3888,7 +3881,6 @@ limProcessPeriodicProbeReqTimer(tpAniSirGlobal pMac)
} while (i < pLimMlmScanReq->numSsid);
/* Activate timer again */
MTRACE(macTrace(pMac, TRACE_CODE_TIMER_ACTIVATE, pPeriodicProbeReqTimer->sessionId, eLIM_PERIODIC_PROBE_REQ_TIMER));
if (tx_timer_activate(pPeriodicProbeReqTimer) != TX_SUCCESS)
{
limLog(pMac, LOGP, FL("could not start periodic probe"

View File

@ -5861,7 +5861,6 @@ limProcessSmeReqMessages(tpAniSirGlobal pMac, tpSirMsgQ pMsg)
* want to insert NOA before processing those msgs. These msgs will be processed later when
* start event happens
*/
MTRACE(macTraceMsgRx(pMac, NO_SESSION, pMsg->type));
switch (pMsg->type)
{
case eWNI_SME_SCAN_REQ:

View File

@ -1,5 +1,5 @@
/*
* Copyright (c) 2011-2015 The Linux Foundation. All rights reserved.
* Copyright (c) 2011-2016 The Linux Foundation. All rights reserved.
*
* Previously licensed under the ISC license by Qualcomm Atheros, Inc.
*
@ -82,7 +82,6 @@ limDeactivateMinChannelTimerDuringScan(tpAniSirGlobal pMac)
*/
limDeactivateAndChangeTimer(pMac,eLIM_MIN_CHANNEL_TIMER);
MTRACE(macTrace(pMac, TRACE_CODE_TIMER_ACTIVATE, NO_SESSION, eLIM_MAX_CHANNEL_TIMER));
if (tx_timer_activate(&pMac->lim.limTimers.gLimMaxChannelTimer)
== TX_TIMER_ERROR)
{

View File

@ -1046,8 +1046,6 @@ limDeactivateAndChangeTimer(tpAniSirGlobal pMac, tANI_U32 timerId)
tANI_U32 val=0, val1=0;
tpPESession session_entry;
MTRACE(macTrace(pMac, TRACE_CODE_TIMER_DEACTIVATE, NO_SESSION, timerId));
switch (timerId)
{
case eLIM_ADDTS_RSP_TIMER:
@ -1739,7 +1737,6 @@ limHeartBeatDeactivateAndChangeTimer(tpAniSirGlobal pMac, tpPESession psessionEn
return;
}
MTRACE(macTrace(pMac, TRACE_CODE_TIMER_DEACTIVATE, psessionEntry->peSessionId, eLIM_HEART_BEAT_TIMER));
#ifdef WLAN_ACTIVEMODE_OFFLOAD_FEATURE
if(IS_ACTIVEMODE_OFFLOAD_FEATURE_ENABLE)
return;
@ -1806,7 +1803,6 @@ limReactivateHeartBeatTimer(tpAniSirGlobal pMac, tpPESession psessionEntry)
#endif
limHeartBeatDeactivateAndChangeTimer(pMac, psessionEntry);
MTRACE(macTrace(pMac, TRACE_CODE_TIMER_ACTIVATE, psessionEntry->peSessionId, eLIM_HEART_BEAT_TIMER));
/* Only start the heartbeat-timer if the timeout value is non-zero */
if(pMac->lim.limTimers.gLimHeartBeatTimer.initScheduleTimeInMsecs > 0)
@ -1948,7 +1944,6 @@ void
limDeactivateAndChangePerStaIdTimer(tpAniSirGlobal pMac, tANI_U32 timerId, tANI_U16 staId)
{
tANI_U32 val;
MTRACE(macTrace(pMac, TRACE_CODE_TIMER_DEACTIVATE, NO_SESSION, timerId));
switch (timerId)
{
@ -2059,7 +2054,6 @@ limDeactivateAndChangePerStaIdTimer(tpAniSirGlobal pMac, tANI_U32 timerId, tANI_
void limActivateCnfTimer(tpAniSirGlobal pMac, tANI_U16 staId, tpPESession psessionEntry)
{
MTRACE(macTrace(pMac, TRACE_CODE_TIMER_ACTIVATE, psessionEntry->peSessionId, eLIM_CNF_WAIT_TIMER));
pMac->lim.limTimers.gpLimCnfWaitTimer[staId].sessionId = psessionEntry->peSessionId;
if (tx_timer_activate(&pMac->lim.limTimers.gpLimCnfWaitTimer[staId])
!= TX_SUCCESS)
@ -2091,7 +2085,6 @@ void limActivateCnfTimer(tpAniSirGlobal pMac, tANI_U16 staId, tpPESession psessi
void limActivateAuthRspTimer(tpAniSirGlobal pMac, tLimPreAuthNode *pAuthNode)
{
MTRACE(macTrace(pMac, TRACE_CODE_TIMER_ACTIVATE, NO_SESSION, eLIM_AUTH_RESP_TIMER));
if (tx_timer_activate(&pAuthNode->timer) != TX_SUCCESS)
{
/// Could not activate auth rsp timer.

View File

@ -1,5 +1,5 @@
/*
* Copyright (c) 2012-2014, 2016 The Linux Foundation. All rights reserved.
* Copyright (c) 2012-2016 The Linux Foundation. All rights reserved.
*
* Previously licensed under the ISC license by Qualcomm Atheros, Inc.
*
@ -47,6 +47,7 @@
#include "limApi.h"
#include "limDebug.h"
#include "limTrace.h"
#include "limSendSmeRspMessages.h"
#include "sysGlobal.h"
#include "dphGlobal.h"
@ -884,10 +885,12 @@ limPostSmeMessage(tpAniSirGlobal pMac, tANI_U32 msgType, tANI_U32 *pMsgBuf)
msg.type = (tANI_U16)msgType;
msg.bodyptr = pMsgBuf;
msg.bodyval = 0;
if (msgType > eWNI_SME_MSG_TYPES_BEGIN)
if (msgType > eWNI_SME_MSG_TYPES_BEGIN) {
MTRACE(macTrace(pMac, TRACE_CODE_TX_SME_MSG, NO_SESSION, msg.type));
limProcessSmeReqMessages(pMac, &msg);
else
} else {
limProcessMlmRspMessages(pMac, msgType, pMsgBuf);
}
} /*** end limPostSmeMessage() ***/
/**
@ -928,6 +931,7 @@ limPostMlmMessage(tpAniSirGlobal pMac, tANI_U32 msgType, tANI_U32 *pMsgBuf)
msg.type = (tANI_U16) msgType;
msg.bodyptr = pMsgBuf;
msg.bodyval = 0;
MTRACE(macTraceMsgRx(pMac, NO_SESSION, msg.type));
limProcessMlmReqMessages(pMac, &msg);
} /*** end limPostMlmMessage() ***/

View File

@ -3903,8 +3903,6 @@ tCsrScanResultInfo *sme_ScanResultGetNext(tHalHandle hHal,
tpAniSirGlobal pMac = PMAC_STRUCT( hHal );
tCsrScanResultInfo *pRet = NULL;
MTRACE(vos_trace(VOS_MODULE_ID_SME ,
TRACE_CODE_SME_RX_HDD_MSG_SCAN_RESULT_GETNEXT, NO_SESSION,0 ));
status = sme_AcquireGlobalLock( &pMac->sme );
if ( HAL_STATUS_SUCCESS( status ) )
{