Piteball/android_kernel_samsung_msm8976
1
1
Fork 0
mirror of https://github.com/team-infusion-developers/android_kernel_samsung_msm8976.git synced 2024-09-21 03:43:03 +00:00
Code Issues Projects Releases Wiki Activity

input: touchscreen: synaptics_dsx: Fix buffer overflow

Browse source 
Limit the index to buffer length while copying from
'strptr' to 'firmware_id'.

Change-Id: I1d7cb7a3d9593ca213c7f7341776632e635eb0df
Signed-off-by: Venkata Prahlad Valluru <vvalluru@codeaurora.org>
This commit is contained in:
Venkata Prahlad Valluru 2018-05-01 11:23:32 +05:30 committed by syphyr
parent 0812b3144e
commit 54ca267406
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/input/touchscreen/synaptics_dsx/synaptics_dsx_fw_update.c
View file

@ -681,10 +681,12 @@ static enum flash_area fwu_go_nogo(struct image_header_data *header)
goto exit;
}
while (strptr[index] >= '0' && strptr[index] <= '9') {
while ((index < MAX_FIRMWARE_ID_LEN - 1) && strptr[index] >= '0'
&& strptr[index] <= '9') {
firmware_id[index] = strptr[index];
index++;
}
firmware_id[index] = '\0';
retval = sstrtoul(firmware_id, 10, &image_fw_id);
kfree(firmware_id);