wm831x_power: Use IRQF_ONESHOT to request threaded IRQs
commit 90adf98d9530054b8e665ba5a928de4307231d84 upstream. Since commit1c6c69525b
("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail. scripts/coccinelle/misc/irqf_oneshot.cocci detected this issue. Fixes:b5874f33bb
("wm831x_power: Use genirq") Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com> Signed-off-by: Sebastian Reichel <sre@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
736652169c
commit
621264c889
|
@ -567,7 +567,7 @@ static int wm831x_power_probe(struct platform_device *pdev)
|
|||
|
||||
irq = wm831x_irq(wm831x, platform_get_irq_byname(pdev, "SYSLO"));
|
||||
ret = request_threaded_irq(irq, NULL, wm831x_syslo_irq,
|
||||
IRQF_TRIGGER_RISING, "System power low",
|
||||
IRQF_TRIGGER_RISING | IRQF_ONESHOT, "System power low",
|
||||
power);
|
||||
if (ret != 0) {
|
||||
dev_err(&pdev->dev, "Failed to request SYSLO IRQ %d: %d\n",
|
||||
|
@ -577,7 +577,7 @@ static int wm831x_power_probe(struct platform_device *pdev)
|
|||
|
||||
irq = wm831x_irq(wm831x, platform_get_irq_byname(pdev, "PWR SRC"));
|
||||
ret = request_threaded_irq(irq, NULL, wm831x_pwr_src_irq,
|
||||
IRQF_TRIGGER_RISING, "Power source",
|
||||
IRQF_TRIGGER_RISING | IRQF_ONESHOT, "Power source",
|
||||
power);
|
||||
if (ret != 0) {
|
||||
dev_err(&pdev->dev, "Failed to request PWR SRC IRQ %d: %d\n",
|
||||
|
@ -590,7 +590,7 @@ static int wm831x_power_probe(struct platform_device *pdev)
|
|||
platform_get_irq_byname(pdev,
|
||||
wm831x_bat_irqs[i]));
|
||||
ret = request_threaded_irq(irq, NULL, wm831x_bat_irq,
|
||||
IRQF_TRIGGER_RISING,
|
||||
IRQF_TRIGGER_RISING | IRQF_ONESHOT,
|
||||
wm831x_bat_irqs[i],
|
||||
power);
|
||||
if (ret != 0) {
|
||||
|
|
Loading…
Reference in New Issue