l2tp: use rcu_dereference_sk_user_data() in l2tp_udp_encap_recv()
commit c1c477217882c610a2ba0268f5faf36c9c092528 upstream. Canonical way to fetch sk_user_data from an encap_rcv() handler called from UDP stack in rcu protected section is to use rcu_dereference_sk_user_data(), otherwise compiler might read it multiple times. Fixes: d00fa9adc528 ("il2tp: fix races with tunnel socket close") Change-Id: I0d5e0cd043ece35d41f5c815576de73e8930fe52 Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: James Chapman <jchapman@katalix.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
This commit is contained in:
parent
62dea4f846
commit
6dfb6c988a
|
@ -1011,7 +1011,7 @@ int l2tp_udp_encap_recv(struct sock *sk, struct sk_buff *skb)
|
|||
{
|
||||
struct l2tp_tunnel *tunnel;
|
||||
|
||||
tunnel = l2tp_tunnel(sk);
|
||||
tunnel = rcu_dereference_sk_user_data(sk);
|
||||
if (tunnel == NULL)
|
||||
goto pass_up;
|
||||
|
||||
|
|
Loading…
Reference in New Issue