KEYS: Change the name of the dead type to ".dead" to prevent user access

commit c1644fe041ebaf6519f6809146a77c3ead9193af upstream.

This fixes CVE-2017-6951.

Userspace should not be able to do things with the "dead" key type as it
doesn't have some of the helper functions set upon it that the kernel
needs.  Attempting to use it may cause the kernel to crash.

Fix this by changing the name of the type to ".dead" so that it's rejected
up front on userspace syscalls by key_get_type_from_user().

Though this doesn't seem to affect recent kernels, it does affect older
ones, certainly those prior to:

	commit c06cfb08b88dfbe13be44a69ae2fdc3a7c902d81
	Author: David Howells <dhowells@redhat.com>
	Date:   Tue Sep 16 17:36:06 2014 +0100
	KEYS: Remove key_type::match in favour of overriding default by match_preparse

which went in before 3.18-rc1.

Change-Id: I9712edfaadb0ff92f623f094eb187a1e23c829a4
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This commit is contained in:

David Howells

2017-04-18 15:31:08 +01:00

committed by

Luca Stefani

parent e60680f245

commit 75af596754

1 changed files with 1 additions and 1 deletions

									
										2

security/keys/gc.c

										View File
									
				@ -46,7 +46,7 @@ static unsigned long key_gc_flags;

				 * immediately unlinked.

				 */

				struct key_type key_type_dead = {

					.name = "dead",

					.name = ".dead",

				};

				/*

KEYS: Change the name of the dead type to ".dead" to prevent user access

2 security/keys/gc.c Unescape Escape View File

2

security/keys/gc.c

View File