diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index f3a19c7de8c3..057412842b02 100644 --- a/net/packet/af_packet.c +++ b/net/packet/af_packet.c @@ -1304,13 +1304,16 @@ static int fanout_add(struct sock *sk, u16 id, u16 type_flags) return -EINVAL; } - if (!po->running) - return -EINVAL; - - if (po->fanout) - return -EALREADY; - mutex_lock(&fanout_mutex); + + err = -EINVAL; + if (!po->running) + goto out; + + err = -EALREADY; + if (po->fanout) + goto out; + match = NULL; list_for_each_entry(f, &fanout_list, list) { if (f->id == id && @@ -1366,17 +1369,16 @@ static void fanout_release(struct sock *sk) struct packet_sock *po = pkt_sk(sk); struct packet_fanout *f; - f = po->fanout; - if (!f) - return; - mutex_lock(&fanout_mutex); - po->fanout = NULL; + f = po->fanout; + if (f) { + po->fanout = NULL; - if (atomic_dec_and_test(&f->sk_ref)) { - list_del(&f->list); - dev_remove_pack(&f->prot_hook); - kfree(f); + if (atomic_dec_and_test(&f->sk_ref)) { + list_del(&f->list); + dev_remove_pack(&f->prot_hook); + kfree(f); + } } mutex_unlock(&fanout_mutex); }