From a2ea4234ebbb5af1ac9b1601093f3e02b4322c7c Mon Sep 17 00:00:00 2001 From: Corinna Vinschen Date: Thu, 26 Apr 2018 22:41:39 +0200 Subject: [PATCH] ALSA: timer: fix a missing goto "ALSA: timer: Handle disconnection more safely" was applied after "ALSA: timer: Fix race at concurrent reads", which left a break in place of the correct goto _error. Fix that. Thanks to Elektroschmock for pointing out the problem. Change-Id: I85252c1d40c4bd88ca86fa8c0bb228d7ed6b12ed Signed-off-by: Corinna Vinschen --- sound/core/timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/core/timer.c b/sound/core/timer.c index 593deebd9da6..253773fc5049 100644 --- a/sound/core/timer.c +++ b/sound/core/timer.c @@ -2004,7 +2004,7 @@ static ssize_t snd_timer_user_read(struct file *file, char __user *buffer, if (tu->disconnected) { err = -ENODEV; - break; + goto _error; } if (signal_pending(current)) { err = -ERESTARTSYS;