Piteball
/
android_kernel_samsung_msm8976
mirror of https://github.com/team-infusion-developers/android_kernel_samsung_msm8976.git
1
1
Fork 0
Code Issues Projects Releases Wiki Activity

block/fs: make tracking dirty task debug only 

Adding a new element "tsk_dirty" to struct page increases the size
of mem_map/vmemmap, restrict this to a debug only functionality to
save few MB of memory.

Considering a system with 1G of RAM, there will be nearly 262144
pages and thus that many number of page structures in mem_map/vmemmap.
With pointer size of 8 bytes on a 64 bit system, adding this
pointer to "struct page" means an increase of "2MB" for mem_map.

CRs-Fixed: 738692
Change-Id: Idf3217dcbe17cf1ab4d462d2aa8d39da1ffd8b13
Signed-off-by: Venkat Gopalakrishnan <venkatg@codeaurora.org>
This commit is contained in:
Venkat Gopalakrishnan 2014-10-27 18:04:22 -07:00
parent 7f4d3c0f76
commit b015fc41eb
3 changed files with 38 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
block/blk-core.c
View File

@ -1923,6 +1923,27 @@ void generic_make_request(struct bio *bio)
}
EXPORT_SYMBOL(generic_make_request);
#ifdef CONFIG_BLK_DEV_IO_TRACE
static inline struct task_struct *get_dirty_task(struct bio *bio)
{
/*
* Not all the pages in the bio are dirtied by the
* same task but most likely it will be, since the
* sectors accessed on the device must be adjacent.
*/
if (bio->bi_io_vec && bio->bi_io_vec->bv_page &&
bio->bi_io_vec->bv_page->tsk_dirty)
return bio->bi_io_vec->bv_page->tsk_dirty;
else
return current;
}
#else
static inline struct task_struct *get_dirty_task(struct bio *bio)
{
return current;
}
#endif
/**
* submit_bio - submit a bio to the block device layer for I/O
* @rw: whether to %READ or %WRITE, or maybe to %READA (read ahead)
@ -1935,7 +1956,6 @@ EXPORT_SYMBOL(generic_make_request);
*/
void submit_bio(int rw, struct bio *bio)
{
struct task_struct *tsk = current;
bio->bi_rw |= rw;
/*
@ -1959,16 +1979,9 @@ void submit_bio(int rw, struct bio *bio)
if (unlikely(block_dump)) {
char b[BDEVNAME_SIZE];
struct task_struct *tsk;
/*
* Not all the pages in the bio are dirtied by the
* same task but most likely it will be, since the
* sectors accessed on the device must be adjacent.
*/
if (bio->bi_io_vec && bio->bi_io_vec->bv_page &&
bio->bi_io_vec->bv_page->tsk_dirty)
tsk = bio->bi_io_vec->bv_page->tsk_dirty;
tsk = get_dirty_task(bio);
printk(KERN_DEBUG "%s(%d): %s block %Lu on %s (%u sectors)\n",
tsk->comm, task_pid_nr(tsk),
(rw & WRITE) ? "WRITE" : "READ",

15
fs/buffer.c
View File

@ -610,6 +610,18 @@ void mark_buffer_dirty_inode(struct buffer_head *bh, struct inode *inode)
}
EXPORT_SYMBOL(mark_buffer_dirty_inode);
#ifdef CONFIG_BLK_DEV_IO_TRACE
static inline void save_dirty_task(struct page *page)
{
/* Save the task that is dirtying this page */
page->tsk_dirty = current;
}
#else
static inline void save_dirty_task(struct page *page)
{
}
#endif
/*
* Mark the page dirty, and set it dirty in the radix tree, and mark the inode
* dirty.
@ -628,8 +640,7 @@ static void __set_page_dirty(struct page *page,
account_page_dirtied(page, mapping);
radix_tree_tag_set(&mapping->page_tree,
page_index(page), PAGECACHE_TAG_DIRTY);
/* Save the task that is dirtying this page */
page->tsk_dirty = current;
save_dirty_task(page);
}
spin_unlock_irqrestore(&mapping->tree_lock, flags);
__mark_inode_dirty(mapping->host, I_DIRTY_PAGES);

2
include/linux/mm_types.h
View File

@ -166,7 +166,9 @@ struct page {
#ifdef CONFIG_WANT_PAGE_DEBUG_FLAGS
unsigned long debug_flags; /* Use atomic bitops on this */
#endif
#ifdef CONFIG_BLK_DEV_IO_TRACE
struct task_struct *tsk_dirty; /* task that sets this page dirty */
#endif
#ifdef CONFIG_KMEMCHECK
/*