kernel/hung_task.c: change hung_task.c to use for_each_process_thread()
In check_hung_uninterruptible_tasks() avoid the use of deprecated while_each_thread(). The "max_count" logic will prevent a livelock - see commit 0c740d0a ("introduce for_each_thread() to replace the buggy while_each_thread()"). Having said this let's use for_each_process_thread(). Change-Id: I607d1819ab824d072f73363b1e429e2d0952b93d Signed-off-by: Aaron Tomlin <atomlin@redhat.com> Acked-by: Oleg Nesterov <oleg@redhat.com> Cc: David Rientjes <rientjes@google.com> Cc: Dave Wysochanski <dwysocha@redhat.com> Cc: Aaron Tomlin <atomlin@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
parent
d4acf11fb1
commit
b433431aca
|
@ -156,7 +156,7 @@ static void check_hung_uninterruptible_tasks(unsigned long timeout)
|
||||||
return;
|
return;
|
||||||
|
|
||||||
rcu_read_lock();
|
rcu_read_lock();
|
||||||
do_each_thread(g, t) {
|
for_each_process_thread(g, t) {
|
||||||
if (!max_count--)
|
if (!max_count--)
|
||||||
goto unlock;
|
goto unlock;
|
||||||
if (time_after(jiffies, last_break + HUNG_TASK_LOCK_BREAK)) {
|
if (time_after(jiffies, last_break + HUNG_TASK_LOCK_BREAK)) {
|
||||||
|
@ -167,7 +167,7 @@ static void check_hung_uninterruptible_tasks(unsigned long timeout)
|
||||||
/* use "==" to skip the TASK_KILLABLE tasks waiting on NFS */
|
/* use "==" to skip the TASK_KILLABLE tasks waiting on NFS */
|
||||||
if (t->state == TASK_UNINTERRUPTIBLE)
|
if (t->state == TASK_UNINTERRUPTIBLE)
|
||||||
check_hung_task(t, timeout);
|
check_hung_task(t, timeout);
|
||||||
} while_each_thread(g, t);
|
}
|
||||||
unlock:
|
unlock:
|
||||||
rcu_read_unlock();
|
rcu_read_unlock();
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue