Piteball/android_kernel_samsung_msm8976
1
1
Fork 0
mirror of https://github.com/team-infusion-developers/android_kernel_samsung_msm8976.git synced 2024-11-01 10:33:27 +00:00
Code Issues Projects Releases Wiki Activity

[media] media: info leak in media_device_enum_entities()

Browse source 
The last part of the "u_ent.name" buffer isn't cleared so it still has
uninitialized stack memory.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Dan Carpenter 2013-04-21 07:10:03 -03:00 committed by Mauro Carvalho Chehab
parent 59501bb792
commit c06ca8f92b
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
drivers/media/media-device.c
View file

@ -102,9 +102,12 @@ static long media_device_enum_entities(struct media_device *mdev,
return -EINVAL; return -EINVAL;
u_ent.id = ent->id; u_ent.id = ent->id;
u_ent.name[0] = '\0'; if (ent->name) {
if (ent->name) strncpy(u_ent.name, ent->name, sizeof(u_ent.name));
strlcpy(u_ent.name, ent->name, sizeof(u_ent.name)); u_ent.name[sizeof(u_ent.name) - 1] = '\0';
} else {
memset(u_ent.name, 0, sizeof(u_ent.name));
}
u_ent.type = ent->type; u_ent.type = ent->type;
u_ent.revision = ent->revision; u_ent.revision = ent->revision;
u_ent.flags = ent->flags; u_ent.flags = ent->flags;