Squashfs: fix failure to unlock pages on decompress error
Direct decompression into the page cache. If we fall back to using an intermediate buffer (because we cannot grab all the page cache pages) and we get a decompress fail, we forgot to release the pages. Reported-by: Roman Peniaev <r.peniaev@gmail.com> Signed-off-by: Phillip Lougher <phillip@squashfs.org.uk> Git-commit: 3a2109763d60cf4d0d92f7ae3c6e2c268fb7de04 Git-repo: https://android.googlesource.com/kernel/common.git Signed-off-by: Kaushal Kumar <kaushalk@codeaurora.org>
This commit is contained in:
parent
b2ec786654
commit
c7a0eb59a6
|
@ -84,6 +84,9 @@ int squashfs_readpage_block(struct page *target_page, u64 block, int bsize)
|
|||
*/
|
||||
res = squashfs_read_cache(target_page, block, bsize, pages,
|
||||
page);
|
||||
if (res < 0)
|
||||
goto mark_errored;
|
||||
|
||||
goto out;
|
||||
}
|
||||
|
||||
|
@ -119,7 +122,7 @@ mark_errored:
|
|||
* dealt with by the caller
|
||||
*/
|
||||
for (i = 0; i < pages; i++) {
|
||||
if (page[i] == target_page)
|
||||
if (page[i] == NULL || page[i] == target_page)
|
||||
continue;
|
||||
flush_dcache_page(page[i]);
|
||||
SetPageError(page[i]);
|
||||
|
|
Loading…
Reference in New Issue