svcrpc: fix failures to handle -1 uid's
commit 0979292bfa301cb87d936b69af428090d2feea1b upstream. As off025adf191
"sunrpc: Properly decode kuids and kgids in RPC_AUTH_UNIX credentials" any rpc containing a -1 (0xffff) uid or gid would fail with a badcred error. Commitafe3c3fd53
"svcrpc: fix failures to handle -1 uid's and gid's" fixed part of the problem, but overlooked the gid upcall--the kernel can request supplementary gid's for the -1 uid, but mountd's attempt write a response will get -EINVAL. Symptoms were nfsd failing to reply to the first attempt to use a newly negotiated krb5 context. Reported-by: Sven Geggus <lists@fuchsschwanzdomain.de> Tested-by: Sven Geggus <lists@fuchsschwanzdomain.de> Signed-off-by: J. Bruce Fields <bfields@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
3873153a61
commit
c814208bb3
|
@ -493,8 +493,6 @@ static int unix_gid_parse(struct cache_detail *cd,
|
|||
if (rv)
|
||||
return -EINVAL;
|
||||
uid = make_kuid(&init_user_ns, id);
|
||||
if (!uid_valid(uid))
|
||||
return -EINVAL;
|
||||
ug.uid = uid;
|
||||
|
||||
expiry = get_expiry(&mesg);
|
||||
|
|
Loading…
Reference in New Issue