iscsi-target: avoid NULL pointer in iscsi_copy_param_list failure
commit 8ae757d09c45102b347a1bc2867f54ffc1ab8fda upstream. In iscsi_copy_param_list() a failed iscsi_param_list memory allocation currently invokes iscsi_release_param_list() to cleanup, and will promptly trigger a NULL pointer dereference. Instead, go ahead and return for the first iscsi_copy_param_list() failure case. Found by coverity. Signed-off-by: Joern Engel <joern@logfs.org> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
b997982f68
commit
c9049bb0aa
|
@ -603,7 +603,7 @@ int iscsi_copy_param_list(
|
|||
param_list = kzalloc(sizeof(struct iscsi_param_list), GFP_KERNEL);
|
||||
if (!param_list) {
|
||||
pr_err("Unable to allocate memory for struct iscsi_param_list.\n");
|
||||
goto err_out;
|
||||
return -1;
|
||||
}
|
||||
INIT_LIST_HEAD(¶m_list->param_list);
|
||||
INIT_LIST_HEAD(¶m_list->extra_response_list);
|
||||
|
|
Loading…
Reference in New Issue