UPSTREAM: ANDROID: binder: remove waitqueue when thread exits.
binder_poll() passes the thread->wait waitqueue that can be slept on for work. When a thread that uses epoll explicitly exits using BINDER_THREAD_EXIT, the waitqueue is freed, but it is never removed from the corresponding epoll data structure. When the process subsequently exits, the epoll cleanup code tries to access the waitlist, which results in a use-after-free. Prevent this by using POLLFREE when the thread exits. (cherry picked from commit f5cb779ba16334b45ba8946d6bfa6d9834d1527f) Change-Id: Ib34b1cbb8ab2192d78c3d9956b2f963a66ecad2e Signed-off-by: Martijn Coenen <maco@android.com> Reported-by: syzbot <syzkaller@googlegroups.com> Cc: stable <stable@vger.kernel.org> # 4.14 Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
5e16f3b8f0
commit
ccbf8c8202
|
@ -366,7 +366,8 @@ enum {
|
|||
BINDER_LOOPER_STATE_EXITED = 0x04,
|
||||
BINDER_LOOPER_STATE_INVALID = 0x08,
|
||||
BINDER_LOOPER_STATE_WAITING = 0x10,
|
||||
BINDER_LOOPER_STATE_NEED_RETURN = 0x20
|
||||
BINDER_LOOPER_STATE_NEED_RETURN = 0x20,
|
||||
BINDER_LOOPER_STATE_POLL = 0x40,
|
||||
};
|
||||
|
||||
struct binder_thread {
|
||||
|
@ -3239,6 +3240,18 @@ static int binder_free_thread(struct binder_proc *proc,
|
|||
} else
|
||||
BUG();
|
||||
}
|
||||
|
||||
/*
|
||||
* If this thread used poll, make sure we remove the waitqueue
|
||||
* from any epoll data structures holding it with POLLFREE.
|
||||
* waitqueue_active() is safe to use here because we're holding
|
||||
* the inner lock.
|
||||
*/
|
||||
if ((thread->looper & BINDER_LOOPER_STATE_POLL) &&
|
||||
waitqueue_active(&thread->wait)) {
|
||||
wake_up_poll(&thread->wait, POLLHUP | POLLFREE);
|
||||
}
|
||||
|
||||
if (send_reply)
|
||||
binder_send_failed_reply(send_reply, BR_DEAD_REPLY);
|
||||
binder_release_work(&thread->todo);
|
||||
|
@ -3262,6 +3275,8 @@ static unsigned int binder_poll(struct file *filp,
|
|||
return POLLERR;
|
||||
}
|
||||
|
||||
thread->looper |= BINDER_LOOPER_STATE_POLL;
|
||||
|
||||
wait_for_proc_work = thread->transaction_stack == NULL &&
|
||||
list_empty(&thread->todo) && thread->return_error == BR_OK;
|
||||
|
||||
|
|
Loading…
Reference in New Issue