nl80211: fix nl80211_send_iface() error paths
commit 4564b187c16327045d87596e8980c65ba7b84c50 upstream. Evidently I introduced a locking bug in my change here, the nla_put_failure sometimes needs to unlock. Fix it. Fixes: 44905265bc15 ("nl80211: don't expose wdev->ssid for most interfaces") Change-Id: I10e56d2a47ec402597a603e0abb3e1335dfb8be3 Signed-off-by: Johannes Berg <johannes.berg@intel.com> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
This commit is contained in:
parent
4afa7c249b
commit
ef2a414dd5
|
@ -2315,7 +2315,7 @@ static int nl80211_send_iface(struct sk_buff *msg, u32 portid, u32 seq, int flag
|
|||
case NL80211_IFTYPE_AP:
|
||||
if (wdev->ssid_len &&
|
||||
nla_put(msg, NL80211_ATTR_SSID, wdev->ssid_len, wdev->ssid))
|
||||
goto nla_put_failure;
|
||||
goto nla_put_failure_locked;
|
||||
break;
|
||||
case NL80211_IFTYPE_STATION:
|
||||
case NL80211_IFTYPE_P2P_CLIENT:
|
||||
|
@ -2328,7 +2328,7 @@ static int nl80211_send_iface(struct sk_buff *msg, u32 portid, u32 seq, int flag
|
|||
if (!ssid_ie)
|
||||
break;
|
||||
if (nla_put(msg, NL80211_ATTR_SSID, ssid_ie[1], ssid_ie + 2))
|
||||
goto nla_put_failure;
|
||||
goto nla_put_failure_locked;
|
||||
break;
|
||||
}
|
||||
default:
|
||||
|
@ -2339,6 +2339,8 @@ static int nl80211_send_iface(struct sk_buff *msg, u32 portid, u32 seq, int flag
|
|||
|
||||
return genlmsg_end(msg, hdr);
|
||||
|
||||
nla_put_failure_locked:
|
||||
wdev_unlock(wdev);
|
||||
nla_put_failure:
|
||||
genlmsg_cancel(msg, hdr);
|
||||
return -EMSGSIZE;
|
||||
|
|
Loading…
Reference in New Issue