ipv4 igmp: use in_dev_put in timer handlers instead of __in_dev_put
[ Upstream commit e2401654dd0f5f3fb7a8d80dad9554d73d7ca394 ] It is possible for the timer handlers to run after the call to ip_mc_down so use in_dev_put instead of __in_dev_put in the handler function in order to do proper cleanup when the refcnt reaches 0. Otherwise, the refcnt can reach zero without the in_device being destroyed and we end up leaking a reference to the net_device and see messages like the following, unregister_netdevice: waiting for eth0 to become free. Usage count = 1 Tested on linux-3.4.43. Signed-off-by: Salam Noureddine <noureddine@aristanetworks.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
102ce961c8
commit
fbf96d75f4
|
@ -709,7 +709,7 @@ static void igmp_gq_timer_expire(unsigned long data)
|
|||
|
||||
in_dev->mr_gq_running = 0;
|
||||
igmpv3_send_report(in_dev, NULL);
|
||||
__in_dev_put(in_dev);
|
||||
in_dev_put(in_dev);
|
||||
}
|
||||
|
||||
static void igmp_ifc_timer_expire(unsigned long data)
|
||||
|
@ -721,7 +721,7 @@ static void igmp_ifc_timer_expire(unsigned long data)
|
|||
in_dev->mr_ifc_count--;
|
||||
igmp_ifc_start_timer(in_dev, IGMP_Unsolicited_Report_Interval);
|
||||
}
|
||||
__in_dev_put(in_dev);
|
||||
in_dev_put(in_dev);
|
||||
}
|
||||
|
||||
static void igmp_ifc_event(struct in_device *in_dev)
|
||||
|
|
Loading…
Reference in New Issue