Subsystem will restart within short timeframe.
Synchronise subsytem up/down callback notifications
to avoid functionality failures.
Use mutex locks to achieve synchronization.
Change-Id: I5881c7d468507bb8402a2e9f8178b9c31e57e8a5
Signed-off-by: Dilip Kota <dkota@codeaurora.org>
Make sure to use pipe handle from the TX
endpoint rather than using a stored handle.
The stored handle may become invalid if SSR
happens between storing of that handle
and locking the mutex.
Change-Id: I53e8f860c2d50061b6c4e6ce2f944c1e2ed8dff2
Signed-off-by: Dilip Kota <dkota@codeaurora.org>
If a bulk message times out due to interrupt starvation, a late
coming interrupt may access structures that are not valid.
Improve timeout error handling by resetting variables, and changing
relevant logging.
Change-Id: Ie0ee2fd9c2ce1628c69e1975fe713a2a26d9e716
Signed-off-by: Sagar Dharia <sdharia@codeaurora.org>
Framer is responsible for clocking slimbus, and when it reboots, state
of all associated data channels is reset to be consistent with HW
state.
Change-Id: Ie74ace2b20ad6c255440ff6ce593f7d5503bf388
Signed-off-by: Sagar Dharia <sdharia@codeaurora.org>
Every bus instance can have 2 NGD devices. Fix the instance number
determination based on NGD device-id.
Change-Id: I515f4f09d58a7abc0c0322ca714b88fb847a0909
Signed-off-by: Sagar Dharia <sdharia@codeaurora.org>
During SSR, all channels are removed and ports are disconnected since
slimbus HW is not functional. Return success to clients for such
calls so that client can mark channel/port state constistent with HW
Change-Id: I9b18f8e7ffe233090c9612d0811a7d36645d0329
Signed-off-by: Sagar Dharia <sdharia@codeaurora.org>
If low-power mode is not entered due to timeout, it is possible that
HW has actually been turned off by ADSP but the response was not
received by driver on apps on time.
Change device state to sleep to make sure HW is woken up for
subsequent runtime-resume operation.
Change-Id: I4e454f7e90e1244985c86286b95202eecfc50a7e
Signed-off-by: Sagar Dharia <sdharia@codeaurora.org>
QMI timeout can happen if other processor doesn't respond within the
time expected by slimbus driver on apps. It has been noticed that QMI
call to power-on slimbus rarely takes more than 500msec. Timeout
is increased to allow that possibility. Additionally, QMI channel is
drained out of left-over messages and runtime-PM state check is
modified to allow graceful handling of timeout if at all any timeout
still happens.
Change-Id: I392a4fa761735135a261fb543815823cee5eba41
Signed-off-by: Sagar Dharia <sdharia@codeaurora.org>
For a Slimbus transaction through QMI, timeout
if there is no response within 500ms and return
timeout to the slimbus client.
Transactions through QMI will complete within milli
seconds. So it is better to timeout for 500ms
instead of 5 seconds.
Change-Id: I818b7c6ff7941d183e1975b21a092f37a0d94264
Signed-off-by: Dilip Kota <dkota@codeaurora.org>
Read and process as many RX DMA descriptors as possible
in a single callback. Handle the case where partial messages
are received and process them later when the complete message
arrives.
Change-Id: I40beb701874d1d2fafc3acf69c144b654ebae74b
Signed-off-by: Naveen Kaje <nkaje@codeaurora.org>
If SSR happens, deinitialize and reinitialize BAM pipes used for
TX and RX messaging.
Change-Id: Ia025aafac9072eac887603bccb1acf5465dfb805
Signed-off-by: Sagar Dharia <sdharia@codeaurora.org>
Signed-off-by: Naveen Kaje <nkaje@codeaurora.org>
NO MERGE
This is to avoid the NS WDT issues because of the
excessive logging from tasha codec write failures.
Change-Id: I3502c21de6f4147fb47b1e2224d5a074143747ce
Signed-off-by: Ramesh Gupta Guntha <rgguntha@codeaurora.org>
HW status in config register will provide consistent information
in case HW status changes due to unexpected noise on the lines.
Use that status to initiate capability negotiation rather than
SW status.
This means the negotiation may take place during runtime if HW
experiences noise. Ensure completion objects don't get re-initialized
accidentally due to this since thread responsible for exchanging this
capability can be waiting on it.
Change-Id: Ifee39473b7b4b63de44a392bb4040bcd9b98e2ff
Signed-off-by: Sagar Dharia <sdharia@codeaurora.org>
Signed-off-by: Dilip Kota <dkota@codeaurora.org>
Allocate bulk-write transactions in advance for most-commonly
used bulk sizes, and reallocate only if size greater than that is
requested by client.
Change-Id: Ib5a80f3713fe5b94bd6dcf45ffe61e498fada192
Signed-off-by: Sagar Dharia <sdharia@codeaurora.org>
Signed-off-by: Dilip Kota <dkota@codeaurora.org>
Make sure BAM resources are initialized
before de-initialization.
Change-Id: I32d5de5abc90995b9732bf565eca35efe0915004
Signed-off-by: Dilip Kota <dkota@codeaurora.org>
Slimbus transactions are process-completed in interrupt context.
This involves signaling appropriate transaction from transaction table
and/or invalidating transaction in error case. Due to this, the
transaction need to be accessed from interrupt context as well. Use
irq-safe methods to avoid interrupt accessing the lock while thread
has acquired it.
Change-Id: Ibe800a64a7594cc435d229e05dda91baea8c9b6e
Signed-off-by: Naveen Kaje <nkaje@codeaurora.org>
Signed-off-by: Sagar Dharia <sdharia@codeaurora.org>
During SSR down, work is queued for shutdown
sequence. Sometimes work is getting scheduled
on one CPU while SSR up sequence is running
on other CPU. This is leading to unexpecpted
scenarios and ending with crash.
To overcome this, serialize shutdown sequence
by doing function call instead of workqueue.
And remove ctrl_up signal reset in the shutdown
sequence as it is affecting the transactions
initiated by client.
Change-Id: If73999ad19441e2090c4ad181dbc90e62ad3d9d4
Signed-off-by: Dilip Kota <dkota@codeaurora.org>
Bandwidth intensive operations (such as firmware download) need
lot of messages to be sent over the bus. This API adds support to
queue multiple messages to HW and provides controller implementation
using BAM.
The API can also be used in places where slimbus slaves have strict
ordering/timing restrictions (e.g. send 2 specific register-writes
back-to-back).
Change-Id: I9a0779e0c4b957d4f4e3b31567b983457d367193
Signed-off-by: Sagar Dharia <sdharia@codeaurora.org>
NGD interrupt can be handled in the interrupt
context as an ISR to process the rx messages faster.
Change-Id: Iaf615520617448160901d0b5de03efc9708d8437
Signed-off-by: Naveen Kaje <nkaje@codeaurora.org>
Optimize RX path by handling small message responses, and
satellite acknowledgements in interrupt context to avoid multiple
context switches.
Change-Id: I111c7ad81e8023a811854632f165185b06157822
Signed-off-by: Sagar Dharia <sdharia@codeaurora.org>
Add support to let the client specify the slimbus port
configuration.
Change-Id: I314a5b8562d098b8eeb504e89ebdc3f83c64b975
Signed-off-by: Naveen Kaje <nkaje@codeaurora.org>
In the TX message queue handler, update the TX head such that
it correctly points to the next message to be processed. Fix
the logic such that all the processed IO vectors are handled, even
when the packets arrive out of order.
Change-Id: Iee45c5acb45f9a8eb475667cc4a87d13b62adc7a
Signed-off-by: Naveen Kaje <nkaje@codeaurora.org>
When the port is disconnected, reset the interrupt enable
status bit corresponding to that port.
Change-Id: I3cff18ea205e9ce9a992cfa2b90bddf5da1d361a
Signed-off-by: Naveen Kaje <nkaje@codeaurora.org>
Configures push pull protocol parameters on
MSM controller. It makes sure to program the
push pull protocol per channel in the framework.
Irresepective of client request, configure to
ISO protocol if channel frequency is multiple
of super frame frequency.
Change-Id: I7f9fc4d7af682d27f617d0220bab2d9b79ade6c8
Signed-off-by: Dilip Kota <dkota@codeaurora.org>
Rx/Tx pipe resources are freed during DSP down.
Simultaneously BAM ISR due to Rx/Tx interrupt
may access the Rx/Tx pipe resources leading to
pagingfault.
To overcome this, Rx/Tx activity is reorganised by
disabling the interrupt during ADSP down and
freeing, allocating resources during ADSP up.
Change-Id: Id1b77a05a042ef9ca194f78e700670edf6146db6
Signed-off-by: Dilip Kota <dkota@codeaurora.org>
Transaction ID is used by slimbus for reply-information or
reply-value messages. Ensure transaction ID assignment is protected
to avoid race condition between 2 or more transactions.
Change-Id: Ie8943de0bcbb9d7fddc22025af051d74e6c9901a
Signed-off-by: Sagar Dharia <sdharia@codeaurora.org>
Client should be able to specify port configuration if it differs
from the default configuration
Change-Id: Iecc019de0b10c6931f5c1e521efd4f6fee178fe9
Signed-off-by: Sagar Dharia <sdharia@codeaurora.org>
Ensure that master-side port disconnection messages are
sent over the slimbus rather than only disabling the port
itself.
Change-Id: Ica2351a325245531349af7b62b2e9d691c569ff2
Signed-off-by: Naveen Kaje <nkaje@codeaurora.org>
Master component expects data-length instead of segment length and
those two may differ for some protocols.
Change-Id: Idf48f856f7c58d80304f9f13b642d1bccdb09e83
Signed-off-by: Sagar Dharia <sdharia@codeaurora.org>
The 'addr' member of the sps_iovec struct only contains the bottom
32 bits of the physical address. Use the DESC_FULL_ADDR() macro to
extract the full address (the upper 4 bits of which are encoded in the
'flags' struct member).
Change-Id: I47e4a72df7b39888680e4f8931d030da576d03e2
Signed-off-by: Matt Wagantall <mattw@codeaurora.org>
Avoid overhead of allocating/freeing structure for transaction
if that transaction is synchronous. For synchronous transactions,
structure is defined on stack using a macro for simplicity. Since
structure is not allocated per transaction and locking is required
only for a few simple instructons, spinlock can be
used to protect the transaction table.
Change-Id: I79ea64b98907ab71fd727d76cf78a2d6feaf0eb0
Signed-off-by: Sagar Dharia <sdharia@codeaurora.org>
Command only BAM pipes may fail to initialize post-SSR. We can still
use register-interface for sending commands to/from Slimbus.
In that case, do not deregister BAM handle since it is possible that
other BAM usecases (e.g. apps channels) will still need BAM.
Change-Id: I6c74394402c45933b4cde694e998c0d88e126114
Signed-off-by: Sagar Dharia <sdharia@codeaurora.org>
Start supporting push-pull data channel protocol in slimbus driver
since the slimbus HW supports it now.
Change-Id: If6b26a696cd2a459a5c5215588711ea037e778ac
Signed-off-by: Sagar Dharia <sdharia@codeaurora.org>
Read complete message at a time instead of
4bytes of a message.Hardware Rx timeout
feature helps to achieve it.
Change-Id: I42d4dc63438816c8ce800c86f359e93cddd5bad3
Signed-off-by: Dilip Kota <c_dkota@codeaurora.org>
Dilip Kota
LuK1337
Sagar Dharia
Linux Build Service Account
Naveen Kaje
Ramesh Gupta Guntha
Dilip Kota
Matt Wagantall