Send the correct uevent after setting a CPU core online or offline.
This allows ueventd to set correct SELinux labels for newly created
sysfs CPU device nodes.
Bug: 28887345
Change-Id: If31b8529b31de9544914e27514aca571039abb60
Signed-off-by: Siqi Lin <siqilin@google.com>
Signed-off-by: Thierry Strudel <tstrudel@google.com>
commit f37fabb8643eaf8e3b613333a72f683770c85eca upstream.
In the critical sysfs entry the thermal hwmon was returning wrong
temperature to the user-space. It was reporting the temperature of the
first trip point instead of the temperature of critical trip point.
For example:
/sys/class/hwmon/hwmon0/temp1_crit:50000
/sys/class/thermal/thermal_zone0/trip_point_0_temp:50000
/sys/class/thermal/thermal_zone0/trip_point_0_type:active
/sys/class/thermal/thermal_zone0/trip_point_3_temp:120000
/sys/class/thermal/thermal_zone0/trip_point_3_type:critical
Since commit e68b16abd9 ("thermal: add hwmon sysfs I/F") the driver
have been registering a sysfs entry if get_crit_temp() callback was
provided. However when accessed, it was calling get_trip_temp() instead
of the get_crit_temp().
Fixes: e68b16abd9 ("thermal: add hwmon sysfs I/F")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
[wt: s/thermal_hwmon.c/thermal_core.c in 3.10]
Signed-off-by: Willy Tarreau <w@1wt.eu>
There is a possibility that the thermal ioctl interface can be accessed
simultaneously in a multi-threaded environment. In those cases the
calls to fetch the frequency and voltage table can result in an
undefined behavior due to race condition.
Use mutex to protect the IOCTL interface from multi-thread access race
condition.
Change-Id: I325695f38753a4d4bc732987cf514e8616273aca
Signed-off-by: Ram Chandrasekar <rkumbako@codeaurora.org>
KTM frequency mitigation thread initializes during late init call.
Prior to this, client can request frequency mitigation. But request
will not be processed, since frequency mitigation thread won't be
initialized. Notify frequency mitigation thread to aggregate clients
current request immediately after thread initialization.
Change-Id: Id2425041b14554d58f944794e1b5db273f5ded26
Signed-off-by: Manaf Meethalavalappu Pallikunhi <manafm@codeaurora.org>
Thermal driver don't acquire get_online_cpus() lock before
evaluating to hotplug or online a core. This will introduce
a corner case where thermal determines to keep an offline core
hotplugged but will be brought online by other driver due to race
condition.
Thermal driver after evaluating to hotplug a core will see if it
is online. if it is online, it will proceed to hotplug it, otherwise
it will evaluate for the next core. If another driver initiates to
online a core when thermal is evaluating hotplug status, we will end up
onlining a core when thermal has a request to hotplug. Explained the
scenario below,
1. | Driver X initiates cpu 'A' online
2. Thermal gets CPU_UP_PREPARE |
Notification and allows CPU |
'A' to be online. |
3. Thermal driver evaluates |
hotplug status and sees cpu |
'A' being offline and skips |
to next CPU. |
4. | CPU 'A' online is complete and CPU
| online mask is updated.
Fix this corner case, by listening for CPU_ONLINE notification and
initiate a re-evaluation to retry hotplug, if a CPU online was supposed
to be hotplugged by thermal driver.
CRs-Fixed: 928985
Change-Id: Icc6c6bcbc2656c0712550b884b9a9b17e3fea9d1
Signed-off-by: Ram Chandrasekar <rkumbako@codeaurora.org>
User input data is passed in from userspace through debugfs interface
of supply lm core to validate supply lm core functionality. Ensure
user buffer size is not greater than expected stack buffer size
to avoid out of bounds array accesses.
Change-Id: I5a93774855241b50895c5e2b3ff939e4c33a0185
Signed-off-by: Manaf Meethalavalappu Pallikunhi <manafm@codeaurora.org>
Currently VDD MX restriction feature monitors all tsens for low
temperature condition. Some targets which has higher MX restriction
thresholds shows frequent interrupts from multiple sensors causing
power impact.
Add support to monitor only one sensor for VDD MX restriction feature.
Add an optional device tree property "qcom,mx-restriction-sensor_id"
to specify sensor id for monitor. If not defined, monitor all tsens
for VDD MX restriction.
Change-Id: Ib709b00c27f43c2603ac8a08b75f2fbd5800983b
Signed-off-by: Manaf Meethalavalappu Pallikunhi <manafm@codeaurora.org>
If KTM get a trip threshold trigger notification and if the
temperature stays the same as the recent trip threshold, KTM will
re-activate the recently triggered threshold, resulting in back to
back interrupts. To avoid this add support in KTM to maintain the
recently triggered threshold state and then re-active the threshold
based on the last threshold trip.
This state is updated for mitigation features like VDD MX retention,
CX phase control, VDD restriction, OCR monitor and external clients
like CPR low temperature monitor etc.
CRs-Fixed: 969112 972634
Change-Id: I44c0a93e1507a9f0b8a65e5c2ce5a98962bb335b
Signed-off-by: Manaf Meethalavalappu Pallikunhi <manafm@codeaurora.org>
The cluster id flag is passed in from the userspace through ioctl
interface. Ensure correctness of cluster id to avoid out of bounds array
accesses.
CRS-fixed: 977508
Change-Id: I778b962d347b90488b983a15087b13e90ad06688
Signed-off-by: Mahesh Sivasubramanian <msivasub@codeaurora.org>
Use proper size for dma memory free call API while saving lmh sensors
list in lmh hardware driver otherwise it leads to memory leak or
unexpected crash if scm_call error path is executed.
CRs-Fixed: 982320
Change-Id: I31ac79585c8899b44ece745676d9af79fe8bca78
Signed-off-by: Manaf Meethalavalappu Pallikunhi <manafm@codeaurora.org>
Add support for efuse based conditional vdd MX restriction for
KTM vdd restriction feature. If digital rail is vdd-mx and if
pre-specified efuse data and config data are matching, then
enable vdd mx restriction feature for preset low temperature
thresholds.
Change-Id: I551869a139d263f57712a5dde07277002260f8c2
Signed-off-by: Manaf Meethalavalappu Pallikunhi <manafm@codeaurora.org>
If userspace request to disable progressive mitigation, it removes
threshold settings and clear device mitigation, but it keeps
progressive config list. But request to disable comes more than once
from userspace, it retries above clean up which may leads to crash due
to use after free. Clean up KTM progressive mitigation exit properly.
Change-Id: I2083411361c943612293a403e5f4c6a7cd31e281
Signed-off-by: Manaf Meethalavalappu Pallikunhi <manafm@codeaurora.org>
After the interrupt mode is initialized, KTM starts the progressive
algorithm based frequency mitigation for multiple sensors based on
thermal sensor information devicetree configuration. This mitigation
will be disabled when thermal-engine starts and disables the KTM
boot up polling mode mitigation.
By default progressive mitigation is in monitor state. In monitor
state algorithm waits for sensor high threshold trigger. If sensor
temperature reaches high threshold, progressive mitigation algorithm
starts in polling mode. In each polling iteration, if current
temperature is greater than or equal to high threshold, it mitigates
by one level down of supported frequency table from fmax. If current
temperature is less than high threshold in a particular sample,
it reduces mitigation by one level up from previous mitigation state
and at this condition if mitigation is fully cleared, then algorithm
moves from polling mode to monitor mode. In polling mode if the
temperature is less than low threshold then algorithm will clear all
mitigations and will switch to monitor mode.
Add an optional devicetree entry "qcom,ktm-prog-mitigation-config"
to thermal sensor info node which takes cluster id to be mitigated,
high threshold, low threshold and progressive mitigation algo
sampling as input.
Change-Id: Ic609e5beb603c3dec1f7de8f64d1c35516eed057
Signed-off-by: Ram Chandrasekar <rkumbako@codeaurora.org>
Signed-off-by: Manaf Meethalavalappu Pallikunhi <manafm@codeaurora.org>
Check if the valid bit is set as part of reading the ADC data from the
status register. The valid bit is used to avoid possibility of reading
invalid ADC data as the controller is updating the readings.
Change-Id: I03832a1ffb6bb47525a5ab9afc28682034a50c69
Signed-off-by: Rama Krishna Phani A <rphani@codeaurora.org>
Fix error handling to free up allocated memory before
returning back the function call.
CRs-Fixed: 869192
Change-Id: I38c9543baa98a941ee09fd34211fa77445b0e096
Signed-off-by: Ram Chandrasekar <rkumbako@codeaurora.org>
Add support to thermal driver to handle partial
goods.
In this case, it is possible that some physical
CPUs may not be brought online and it can be
decided runtime. This behavior changes the physical
CPU to logical CPU numbering dynamic.
Thermal driver should be capable to map the
temperature sensor with the correct logical CPU number.
This is achieved by creating different mitigation
profiles and associating each physical CPU to one
profile using device tree phandle. Thus thermal driver
identifies the thermal profile associated with the
logical CPU and then determines the mitigation
information. The mitigation profile has a phandle to the
temperature sensor and devicetree properties to
enable or disable various type of mitigation.
A single device can have multiple sensors mapped in
array of phandles or even multiple sensors mapping
to a single sensor.
Partial goods cpu feature will be enabled only if
'qcom,mitigation-profile-enable' DT node is defined
in msm_thermal node.
CRs-Fixed: 756322
Change-Id: If0196a9a3a03c117f67bae3591d1f5050d32b59b
Signed-off-by: Ram Chandrasekar <rkumbako@codeaurora.org>
Signed-off-by: Manaf Meethalavalappu Pallikunhi <manafm@codeaurora.org>
Multi-Zone Temperature Control (MTC) provides an interface to
clients to enable or disable thresholds for supported zone of
sensors and to get log of recent commands. Update the MTC
sysfs functionality.
Change-Id: I171c799ea11f4ec2e86f881555fd2014de803a1e
Signed-off-by: Rama Krishna Phani A <rphani@codeaurora.org>
Multi-Zone Temperature Control (MTC) provides an interface to
clients to enable or disable thresholds for supported zone of sensors
and to get log of recent commands. Upate sysfs nodes to print the values
in the shell.
Change-Id: I74cdfba6cb7c235cb3939b7286771edd2a02a6fa
Signed-off-by: Rama Krishna Phani A <rphani@codeaurora.org>
Support new device tree properties to selectively disable a feature in KTM.
Do not generate error if properties for this feature are not defined.
Change-Id: I2891ff25291d62e7de53b192af93081fa16a8d1d
Acked-by: Jim Granitzki <jamesg@qti.qualcomm.com>
Signed-off-by: Kranthikumar Kurapati <kkurap@codeaurora.org>
Fix the LMH throttling intensity calculation to report
the intensity in percentage.
Change-Id: I64ac5855b4e9b9cb5ef7dde939102a31d2a08e52
Signed-off-by: Ram Chandrasekar <rkumbako@codeaurora.org>
Interrupt enable code is outside the critical section and
this can lead to race condition between multiple threads.
This race condition can result in enabling the interrupt,
which is disabled by the interrupt service routine. This
can lead to interrupt storm.
To avoid this, the interrupt enable is done inside critical
section to avoid any race condition.
CRs-Fixed: 850290
Change-Id: Ifeea212601e39b554740d88da0c662e4a9be0d87
Signed-off-by: Ram Chandrasekar <rkumbako@codeaurora.org>
vph_pwr channel should be supported for VADC_TM for pm8950 2.0.
Add version check to detect the PMIC used and support channel
accordingly.
Change-Id: I6f62604e0050a245acd0f65732ef5b3aca9180ec
Signed-off-by: Rama Krishna Phani A <rphani@codeaurora.org>
Additional per-sensor offets are being observed after factory
calibration. Fuse-based correction factors are implemented to the
existing 30 / 120 deg C calibration fuses.
Change-Id: I0415932c424da119c03b773e425ef50a02dfc119
Signed-off-by: Rama Krishna Phani A <rphani@codeaurora.org>
Add support to read the EEPROM fuse data for calibration
to calculate the gain and offset that is used to compute
the final temperature.
Update the DT document to add missing DT compatible strings
along with the addition for 9x40v2 compatible string support.
Change-Id: Ib39388e1db92b3d18878abf67a28f598ca004f96
Signed-off-by: Siddartha Mohanadoss <smohanad@codeaurora.org>
Fix issue in msm_thermal_process_voltage_table_request.
For voltage tables bigger than 16 it is not correclty
passing the partial table size to user space.
The full size is passed instead of the partial size.
For example if reading a table of 18 values the
first read returns 16, and the partial read returns 18
but it should return 2.
Signed-off-by: Jeff Bernard <jbernard@codeaurora.org>
Change-Id: I75943e94341388cca772ee45bc1275fb5d2091d2
Normalize the throttling intensity reading for a LMH sensor
based on the maximum throttling intensity value.
Change-Id: I48567d5c1f027b244a296c96f1ca8ddd5ae4846a
Signed-off-by: Ram Chandrasekar <rkumbako@codeaurora.org>
Add support in KTM to parse early kernel boot command.
Below is an example to disable KTM.
fastboot -c "<existing_kernel_bootcmd> qcomthermal=disable" boot boot.img
Change-Id: I268e652239573ff368f8ccbfdff354eb6c24a90a
Signed-off-by: Shiju Mathew <shijum@codeaurora.org>
This patch will add support in KTM to disable its
temperature monitoring and mitigations from debugfs
interface. Below is the command to disable all
KTM mitigation.
echo -n disable > /sys/kernel/debug/msm_thermal/config
Change-Id: I46d880bad043897e088bdd156305ce61aa2ea452
Signed-off-by: Shiju Mathew <shijum@codeaurora.org>
Add support in KTM to read thermal threshold
configurations through debugfs interface. Below
is the command to read KTM configuration from shell.
cat /sys/kernel/debug/msm_thermal/config
Change-Id: I3ff937875e8b5136584ab10af75dbed71b1443ac
Signed-off-by: Shiju Mathew <shijum@codeaurora.org>
Multi-Zone Temperature Control (MTC) provides an interface to
clients to enable or disable thresholds for supported zone of sensors
and to get log of recent commands. Create sysfs nodes to access
MTC tsens.
Change-Id: Id42baef39442a8e30f40e2cd98c50611ed1cdf27
Signed-off-by: Rama Krishna Phani A <rphani@codeaurora.org>
Nick Desaulniers
Siqi Lin
syphyr
Krzysztof Kozlowski
LuK1337
Ram Chandrasekar
Linux Build Service Account
Manaf Meethalavalappu Pallikunhi
Mahesh Sivasubramanian
Rama Krishna Phani A
Kranthikumar Kurapati
Shiju Mathew
Siddartha Mohanadoss
Jeff Bernard