commit ad608fbcf166fec809e402d548761768f602702c upstream.
The event subscriptions are added to the subscribed event list while
holding a spinlock, but that lock is subsequently released while still
accessing the subscription object. This makes it possible to unsubscribe
the event --- and freeing the subscription object's memory --- while
the subscription object is simultaneously accessed.
Prevent this by adding a mutex to serialise the event subscription and
unsubscription. This also gives a guarantee to the callback ops that the
add op has returned before the del op is called.
This change also results in making the elems field less special:
subscriptions are only added to the event list once they are fully
initialised.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Hans Verkuil <hans.verkuil@cisco.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: stable@vger.kernel.org # for 4.14 and up
Fixes: c3b5b0241f ("V4L/DVB: V4L: Events: Add backend")
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Validate eeprom_name string length before copying into
the userspace buffer.
If more data than required is copied, userspace has the access to
some of kernel data which is not intended.
This change will fix this issue.
CRs-Fixed: 1090007
Change-Id: Id40a287e0b1a93cc15d9b02c757fe9f347e285f2
Signed-off-by: Rajesh Bondugula <rajeshb@codeaurora.org>
Signed-off-by: VijayaKumar T M <vtmuni@codeaurora.org>
Modify macro MAX_CID_CH to 3 as vfe can support maximum 3
CID_CH at an instance.
CRs-Fixed: 1064689
Change-Id: Ibb993839c1057fb62f43e99df3bee8328a4c702f
Signed-off-by: Trishansh Bhardwaj <tbhardwa@codeaurora.org>
Signed-off-by: VijayaKumar T M <vtmuni@codeaurora.org>
Add changes to track buffer being added to list. Add error
messages if buffer is found to be added twice.
Change-Id: I1e10324710e9d6bc0eb594d289b123d78b035d3e
Signed-off-by: Venu Yeshala <vyeshala@codeaurora.org>
In Offline reprocess, HAL sends reprocess frame id, which is
tagged with each offline request. When offline ISP sends
buffer to CPP/HAL they rely on tagged frame id to asssociate
the frame with meta/settings buffer. Change takes care of
using HAL sent frame id in offline request.
Change-Id: I138f0d2ad7350cc613f222b11b5cfb492166fb3e
Signed-off-by: Sagar Gore <sgore@codeaurora.org>
Adding support to map buffer in fetch engine driver on the fly.
This is needed for Offline reprocess mode of offline ISP.
Added ioctl to unmap buffer after fetch read done, which are
not part of any bufq/stream.
Change-Id: I25eb7e3fe6218b51f94a7f835393aa40eb1ad611
Signed-off-by: Sagar Gore <sgore@codeaurora.org>
Incase of offline isp Raw frame ID need to synchronized with
pixel frame id.
Change-Id: I95280fd96855a4dedb9cb0c64014e08beb4661f0
Signed-off-by: Rajeev Kulkarni <krajeev@codeaurora.org>
To distinguish between offline/online vfe stats
set a unique bit in offline stats stream id.
Change-Id: I960a63a19e5c65ba71e5bf53a0381213c1ad541d
Signed-off-by: Sagar Gore <sgore@codeaurora.org>
This change gives way to read svs freq for certain targets
for which VFE's have svs freq defined.
Change-Id: I749327861e4392c6f3f24235c1e9b47b684f1362
Signed-off-by: Rajeev Kulkarni <krajeev@codeaurora.org>
This gerrit adds the MM eeprom implementation.
This reverts commit 36dae9889b.
Change-Id: I6befeb4b6dc05dbea6de29db5aada102d1018ce8
Signed-off-by: Rajesh Bondugula <rajeshb@codeaurora.org>
Add eeprom slave related information in userspace driver
and propagate it to kernel for device probe. Probe happens
from camera daemon. This helps in reducing the boot time.
Change-Id: I92ab450cedece2b145f6c180009dcb7bcce85964
Signed-off-by: Viswanadha Raju Thotakura <viswanad@codeaurora.org>
Calculate the AB/IB values in userspace and update in kernel.
Change-Id: I13c83e5e98f61a0552408e641b774a147a395baf
Signed-off-by: Alok Kediya <kediya@codeaurora.org>
iface was doing multiple ioctls during camera preview start;
Changed to bundle all ioctl subscription into one single call
Change-Id: I60cbf9d957608ec1f437b42ec3a671c77280aa0c
Signed-off-by: Senthil Kumar Rajagopal <skrajago@codeaurora.org>
Signed-off-by: Alok Kediya <kediya@codeaurora.org>
In Dual VFE mode, the 2 VFE can assign different WM to same user stream.
So when updating ping pong address, the pingpong_status can be different
for the 2 VFE. Use just the pingpong_bit along with each VFE WM number
to config ping pong to resolve the split in such a scenario.
Change-Id: I41a1ea8d443d061c5c2ee40d4ea0922456021192
Signed-off-by: Harsh Shah <harshs@codeaurora.org>
Free the registered buffers when closing instead of stopping
session to avoid NULL pointer access error if client tries to
dequeue buffer while stopping session.
Change-Id: Iecce727fe7f5afc0287e38904beb5855a6e11e02
Signed-off-by: Maheshwar Ajja <majja@codeaurora.org>
delta_info and output_info are both structures in a union that
are piggybacked to SOF event. Combine them so we can send all the info.
Add additional comments to the header files. Move the dual_vfe_res
to common_data as it is also shared resource between 2 VFE.
Change-Id: I6289625336fe4486508c2d32fb42bbd55214b941
Signed-off-by: Harsh Shah <harshs@codeaurora.org>
Call deinit to put actuator in standby mode before
actuator power down which helps in reducing power
consumption.
Change-Id: I13b996b2aedff69ba9380629ff29f536bfe0b9a7
Signed-off-by: Mayank Parashar <mayankp@codeaurora.org>
This reverts commit I6dbaf74a7f7939ae6aa516d01ede3d7119307818.
In new firmware version extn_userdata size has adjusted from 8240 bytes
to 7728 bytes. Hence decreasing default extradata size to 8k.
Change-Id: Id6965cc74b3b1d22e3a4240aad7fc8cb7bac9222
Signed-off-by: Srinu Gorle <sgorle@codeaurora.org>
Stream info holds information about various axi outputs
but maximum streams VFE can output is limited by write masters.
Use correct macros to differentiate between two.
Change-Id: I264e8ef6b77e0f5a1fff1c7114d53d017375aa78
Signed-off-by: Sagar Gore <sgore@codeaurora.org>
Signed-off-by: Harsh Shah <harshs@codeaurora.org>
In master-slave mode, set Slave frame id = master frame id,
if the delta between the timestamp is < Threshold. If delta is
higher than threshold, slave frame_id = master + 1.
Change-Id: I68f1c5354334bc11795739836a9a75436bde38be
Signed-off-by: Harsh Shah <harshs@codeaurora.org>
Add dual_hw MASTER and SLAVE tags to vfe_src.
Add info to src on ioctl and remove it during stop_axi.
Also maintain the same info in common_data.
This change adds the framework needed to use VFE src in
Master-Slave mode.
Change-Id: I41b210ed1ff7a7d26510a78590e62f46f4a3ca1c
Signed-off-by: Harsh Shah <harshs@codeaurora.org>
Adding header changes for passing dual vfe info from userspace to
kernel.
Change-Id: I0fa03a4b87847d19ea63df4b7a188cc110801c4a
Signed-off-by: Senthil Kumar Rajagopal <skrajago@codeaurora.org>
correct the direction register for the reset_lense
Change-Id: Iebe362c514602247bced18d994cce41288f34565
Signed-off-by: Soundrapandian Jeyaprakash <jsoundra@codeaurora.org>
The striping algorithm header does not need to have kernel dependency.
The striping code / headers can be enclosed in camera backend.
Change-Id: I35b99ec1dad5f9591ca5e5bdc1d44a991de47036
Signed-off-by: Krishnankutty Kolathappilly <kkolatha@codeaurora.org>
Drop frame request and report error to user space if
reg update is missing.
Change-Id: Ie5b1bf265e12e8e5da676ac93de8b044fd63cc17
Signed-off-by: Konstantin Motov <kmotov@codeaurora.org>
There can be situations when opening camera will fail, not
due to an error but due to the fact that the current hardware
configuration can only support either the front or back camera
and can't support opening another the camera at the moment.
In such cases, rather than returning -EFAULT to user space, camera
should return -EBUSY so as to distinguish between a genuine failure
to open the camera and a failure due to current configuration which
precludes from opening another instance of the camera.
So, correct the return code in the camera open failure handling code.
Change-Id: Ib99ed919be44b40a1b0270a3d2a8a1794a0373cb
Signed-off-by: Seemanta Dutta <seemanta@codeaurora.org>
Make header changes for structures/defines to enable unified probe.
Make provision for shared data between 2 HW.
Define IOCTL for setting master and slave HW.
Create separate probe methods for parent and child nodes.
Link common_data to all child nodes.
Create module and driver in msm_ispxx.c files.
This framework enables the parent device to control both HW
to achieve better sync and the common data enables sharing of data
between 2 HW.
Change-Id: Ic3ac8151ed6a89e3934b1cd2429261beec6f0c04
Signed-off-by: Harsh Shah <harshs@codeaurora.org>
Remove is_flash_supported flag. This flag is redundant
existence of flash is cheked with flash_name variable.
Change-Id: I91c34cd3b78be225f751a47356ad7f0dc1db9bdf
Signed-off-by: Rajesh Bondugula <rajeshb@codeaurora.org>
Signed-off-by: Xu Han <hanxu@codeaurora.org>
Add support to get sensor output info as a part of
slave info.
Change-Id: I821c76d42fc91bcdd9b5f8df7f64a85f36fc4a51
Signed-off-by: Mayank Parashar <mayankp@codeaurora.org>
Each slave can have a different I2C frequency.
The frequency is configured for each write / read if changed.
Change-Id: I6ae71686d41e85c8686d6871d7870b178da5905d
Signed-off-by: Rajesh Bondugula <rajeshb@codeaurora.org>
Signed-off-by: Xu Han <hanxu@codeaurora.org>
Copy all ringing parameters for all regions of actuator.
Region can be changed in kernel.
Change-Id: Iad2484ffb5a498b03db655193bd8344a40973858
Signed-off-by: Rajesh Bondugula <rajeshb@codeaurora.org>
Signed-off-by: Xu Han <hanxu@codeaurora.org>
Add logic to fix same sensor at one board compatibility
issue.
Change-Id: I6c6721e8ff890feaf2d618c8170e346367a68c28
Signed-off-by: Wei Ding <weiding@codeaurora.org>
Sakari Ailus
LuK1337
VijayaKumar T M
Abhishek Kondaveeti
Venu Yeshala
Linux Build Service Account
Sagar Gore
Rajeev Kulkarni
Rajesh Bondugula
Manikandan Anbu
Viswanadha Raju Thotakura
Alok Kediya
Senthil Kumar Rajagopal
Harsh Shah
Maheshwar Ajja
Mayank Parashar
Srinu Gorle
Soundrapandian Jeyaprakash
Krishnankutty Kolathappilly
Konstantin Motov
Seemanta Dutta
Wei Ding