Commit graph

104 commits

Author SHA1 Message Date
Eugene Teo
d61975fc6b [ALSA] Fix gus_pcm dereference before NULL
Modules: GUS Library

The NULL check of substream is simply superfluous. It is
guaranteed to receive non-NULL substream. Thanks Takashi.

Coverity bug #861

Signed-off-by: Eugene Teo <eugene.teo@eugeneteo.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-03-22 10:39:25 +01:00
Adrian Bunk
202728d783 [ALSA] fix some memory leaks
Modules: Generic drivers,ES18xx driver,CS46xx driver

This patch fixes two memory leaks spotted by the Coverity checker.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-03-22 10:38:23 +01:00
Dave Jones
3de4414e79 [ALSA] ad1848 double free
Modules: AD1848 driver

Same again, snd_ctl_add() already kfree's on error.

Coverity #956

Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-03-22 10:36:08 +01:00
Dave Jones
bcc54f9a56 [ALSA] sound/isa/sb/sb_mixer.c double kfree
Modules: SB drivers

snd_ctl_add() already does the free on error.

Coverity bug #957

Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-03-22 10:35:57 +01:00
Takashi Iwai
0bbbc4ca7e [ALSA] opti9x - Fix compile without CONFIG_PNP
Modules: Opti9xx drivers

Fix compile errors without CONFIG_PNP.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-03-22 10:31:40 +01:00
Takashi Iwai
a5a6bbd9b2 [ALSA] cs4236 - Fix a typo
Modules: CS4236+ driver

Fixed a typo in snd_cs4236_put_master_digital(), resulting in silence
right channel.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-03-22 10:31:37 +01:00
Takashi Iwai
8278ca8feb [ALSA] Fix check of enable module option
Fix the check of enable module option in probe of platform_device drivers.
It shouldn't break the loop but just ignore if enable[i] is false.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-03-22 10:30:43 +01:00
Ken Arromdee
d08a23e250 [ALSA] ad1816a - Fix PCM trigger direction
Modules: AD1816A driver

Fixed the bug of capture with Shark Predator ISA resulting in:
	arecord: pcm_read:1196: read error: Input/output error

Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-03-22 10:28:58 +01:00
Ingo Molnar
8b7547f95c [ALSA] semaphore -> mutex (ISA part)
Semaphore to mutex conversion.

The conversion was generated via scripts, and the result was validated
automatically via a script as well.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-03-22 10:25:03 +01:00
Mark Salazar
95b712965f [ALSA] #4/4 for Zoom Video - add Zoom Video support
Modules: ES18xx driver

Forth of 4 es18xx.c patches culminating in Zoom Video support.

This patch adds Zoom Video support for those chipsets that support it.

Testing:
This work was initially done on the source from the Debian Sarge ALSA
package, then tested
on an ES1879. I could not test the Zoom Video function for an ES1878 or
ES1869.
Patches were created against the Sarge code and then edited to apply
correctly to the
ALSA cvs code. Lastly the patched ALSA cvs code was test for successful
compilation.
No additional testing was done on the ALSA cvs version.

One quirk (noted in my comments below) is that apparently the datasheet
is wrong
for one of the ES1879 Zoom Video 'enable' bits, because
 1) if you set this bit it messes up PCM playback (speaker_test play a
lower frequency)
 2) even if you don't set this bit Zoom Video still works.
I added a control to toggle the bit on just in case there might be a
version of the
ES1879 that requires it, but I expect noone will need it.

Signed-off-by: Mark Salazar <markTheCoder@justmyself.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-03-22 10:24:17 +01:00
Mark Salazar
14086771c0 [ALSA] #3/4 for Zoom Video - change Hardware Volume interrupt handling
Modules: ES18xx driver

Third of 4 es18xx.c patches culminating in Zoom Video support.

This patch changes the Hardware Volume support to reflect the fact that
not all of the
supported chipsets have seperate registers dedicated to the Hardware
Volume inputs. Although
all the chipsets can generate an HWV interrupt whenever a Hardware
Volume input is received
only those with seperate HWV registers can split the HWV registers from
the Master volume
registers.

Testing:
This work was initially done on the source from the Debian Sarge ALSA
package, then tested
on an ES1879 and an ES1878 machine. Patches were created against the
Sarge code and then edited
to apply correctly to the ALSA cvs code. Lastly the patched ALSA cvs
code was test for
successful compilation. No additional testing was done on the ALSA cvs
version.

Signed-off-by: Mark Salazar <markTheCoder@justmyself.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-03-22 10:24:08 +01:00
Mark Salazar
f4df221f8f [ALSA] #2/4 for Zoom Video - resolve number of record sources
Modules: ES18xx driver

Second of 4 es18xx.c patches culminating in Zoom Video support.

This patch changes the 'record source' mux routines to reflect the fact
that not all of the
supported chipsets have 8 possible inputs. Some have 4 and some have 5.

Testing:
This work was initially done on the source from the Debian Sarge ALSA
package, then tested
on an ES1879 and an ES1878 machine. Patches were created against the
Sarge code and then edited
to apply correctly to the ALSA cvs code. Lastly the patched ALSA cvs
code was test for
successful compilation. No additional testing was done on the ALSA cvs
version.

Signed-off-by: Mark Salazar <markTheCoder@justmyself.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-03-22 10:24:04 +01:00
Mark Salazar
c1f6d41593 [ALSA] #1/4 for Zoom Video - resolve common vs chipset specific mixer controls
Modules: ES18xx driver

First of 4 es18xx.c patches culminating in Zoom Video support.
While adding support for Zoom Video to the es18xx driver I found some of
the mixer controls
were wrong. Since you guys went to the trouble of supplying the
datasheets for the supported
chipsets I did a review of all of them and tried to get es18xx.c to
accurately reflect the
proper mixer controls for each chipset. If the datasheets are wrong then
so are my patches.

This first patch moves some controls from the common-to-all-chipsets array
'snd_es18xx_base_controls' to a chipset-specific array and adds code to
manage that new array.
Also while testing on my ES1878 test machine I discovered it needed a
couple of udelays in
the identify function so those are in this patch as well.

Testing:
This work was initially done on the source from the Debian Sarge ALSA
package, then tested
on an ES1879 and an ES1878 machine. Patches were created against the
Sarge code and then edited
to apply correctly to the ALSA cvs code. Lastly the patched ALSA cvs
code was test for
successful compilation. No additional testing was done on the ALSA cvs
version.

Signed-off-by: Mark Salazar <markTheCoder@justmyself.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-03-22 10:23:52 +01:00
Rene Herman
6f595cffed [PATCH] snd-cs4236 typo fix
I noticed on 2.6.16-rc4 that my MPU-401 wasn't functional, due to a simple
copy & paste error in sound/isa/cs423x/cs4236.c.

Acked-by: Takashi Iwai <tiwai@suse.de>
Cc: Jaroslav Kysela <perex@suse.cz>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-02-24 14:31:36 -08:00
Alexey Dobriyan
1d79716ab0 [ALSA] Fix adding second dma channel
Modules: OPL3SA2 driver,GUS Classic driver

dma2 is a global array. sprintf below suggests there was a typo.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-02-01 13:09:26 +01:00
Lukasz Stemach
50f794c8dc [ALSA] cs4236 - Add PnP ids for Netfinity 3000
Modules: CS4236+ driver

PnP ids for Netfinity 3000 builtin soundcard.

This one works for me.

This patch was submitted through kernel Bugzilla #4214.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-02-01 13:09:12 +01:00
Takashi Iwai
9113485970 [ALSA] opti93x - Fix a compile warning
Modules: Opti9xx drivers

Fix a gcc-4.1 compile warning regarding uninitialized variables.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-02-01 13:09:09 +01:00
Takashi Iwai
fe25ad8a84 [ALSA] wavefront - Fix a compile warning
Modules: Wavefront drivers

Fix a gcc-4.1 compile warning regarding uninitialized variables.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-02-01 13:09:07 +01:00
Jaroslav Kysela
ec80859ed2 [ALSA] cs4232/cs4236 - moved CS423X_DRIVER define outside CONFIG_PNP
Modules: CS4236+ driver

Signed-off-by: Jaroslav Kysela <perex@suse.cz>
2006-01-22 17:10:43 +01:00
Takashi Iwai
80faf041cd [ALSA] sb16 - Fix duplicated PnP entry
Modules: SB16/AWE driver

Fix the duplicated PnP entry between sb16 and sbawe drivers.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-01-22 16:25:00 +01:00
Takashi Iwai
62af9905a1 [ALSA] opl3sa2 - Fix conflict of driver name on sysfs
Modules: OPL3SA2 driver

Fix the conflict of driver name 'opl3sa2' on sysfs with OSS driver.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-01-22 16:24:58 +01:00
Takashi Iwai
59b1b34f47 [ALSA] Fix compilation without CONFIG_PNP
Fix compilation of some ISA drivers without CONFIG_PNP.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-01-22 16:23:48 +01:00
Andrew Morton
a136564702 [PATCH] remove gcc-2 checks
Remove various things which were checking for gcc-1.x and gcc-2.x compilers.

From: Adrian Bunk <bunk@stusta.de>

    Some documentation updates and removes some code paths for gcc < 3.2.

Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-01-08 20:14:02 -08:00
Clemens Ladisch
7b6d92451a [ALSA] seq: set client name in snd_seq_create_kernel_client()
All users of snd_seq_create_kernel_client() have to set the client name
anyway, so we can just pass the name as parameter.  This relieves us
from having to muck around with a struct snd_seq_client_info in these
cases.

Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
2006-01-03 12:30:49 +01:00
Clemens Ladisch
83e8ad6984 [ALSA] seq: remove struct snd_seq_client_callback
The fields of struct snd_seq_client_callback either aren't used or are
always set to the same value, so we can get rid of it altogether.

Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
2006-01-03 12:30:47 +01:00
Clemens Ladisch
f7a9275d94 [ALSA] unregister platform devices
Call platform_device_unregister() for all platform devices that we've
registered.

Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
2006-01-03 12:30:39 +01:00
Takashi Iwai
9d70d91c46 [ALSA] ad1848 - Fix compilation without CONFIG_PM
Modules: AD1848 driver

Fix compilation without CONFIG_PM.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-01-03 12:29:59 +01:00
Takashi Iwai
a2c855bbd7 [ALSA] Fix a compile warning
Modules: CS4231 driver

Fix a compile warning (unused variable).

Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-01-03 12:29:09 +01:00
Takashi Iwai
a9824c868a [ALSA] Add CS4232 PnP BIOS support
Modules: CS4231 driver,CS4236+ driver

Add CS4232 PnP BIOS support.  Still experimental.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-01-03 12:29:02 +01:00
Takashi Iwai
fa55f837bb [ALSA] Fix resume of cs4231
Modules: CS4231 driver

Use mce_down() again in the resume callback.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-01-03 12:29:00 +01:00
Takashi Iwai
73e77ba023 [ALSA] Add error messages
Add error messages in the critial error path to be more verbose.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-01-03 12:28:58 +01:00
Takashi Iwai
00a4e3d9f8 [ALSA] Merge ad1816a-lib module to ad1816a
Modules: AD1816A driver

Merge ad1816a-lib module to ad1816.
There is no more reason to split.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-01-03 12:28:57 +01:00
Takashi Iwai
7f52bdb61b [ALSA] Remove SND_GENERIC_DRIVER from isa/Kconfig
Modules: ISA

Remove the obsolete SND_GENERIC_DRIVER from isa/Kconfig.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-01-03 12:28:41 +01:00
Takashi Iwai
d29b761e61 [ALSA] wavefront - Use platform_device
Modules: Wavefront drivers

Rewrite the probe/remove with platform_device.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-01-03 12:28:39 +01:00
Takashi Iwai
99a0b7687e [ALSA] opti9xx - Use platform_device
Modules: Opti9xx drivers

Rewrite the probe/remove with platform_device.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-01-03 12:28:37 +01:00
Takashi Iwai
654aa66177 [ALSA] gus - Use platform_device
Rewrite the probe/remove with platform_device.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-01-03 12:28:36 +01:00
Takashi Iwai
2a571ed13c [ALSA] es1688 - Use platform_device
Modules: ES1688 driver

Rewrite the probe/remove with platform_device.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-01-03 12:28:34 +01:00
Takashi Iwai
277e926c9b [ALSA] sscape - Use platform_device
Modules: Sound Scape driver

Rewrite the probe/remove with platform_device.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-01-03 12:28:31 +01:00
Takashi Iwai
feb158e6ad [ALSA] sgalaxy - Use platform_device, add PM support
Modules: Sound Galaxy driver

Rewrite the probe/remove with platform_device.
Also, add the PM support.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-01-03 12:28:29 +01:00
Takashi Iwai
f7e0ba3e44 [ALSA] es18xx - Use platform_device
Modules: ES18xx driver

Rewrite the probe/remove with platform_device.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-01-03 12:28:28 +01:00
Takashi Iwai
704e05204c [ALSA] opl3sa2 - Use platform_device
Modules: OPL3SA2 driver

Rewrite the probe/remove with platform_device.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-01-03 12:28:27 +01:00
Takashi Iwai
acdcbc1542 [ALSA] cmi8330 - Use platform_device, add PM support
Modules: CMI8330 driver

Rewrite the probe/remove with platform_device.
Also, add the PM support.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-01-03 12:28:25 +01:00
Takashi Iwai
175cdcfb11 [ALSA] ad1816a - Clean up PnP code
Modules: AD1816A driver

Clean up PnP code of ad1816a driver.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-01-03 12:28:24 +01:00
Takashi Iwai
e2fa213591 [ALSA] dt019x - Add PM support
Modules: DT019x driver

Add PM support to dt019x driver.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-01-03 12:28:23 +01:00
Takashi Iwai
b6cc25cae3 [ALSA] azt2320 - Add PM support
Modules: AZT2320 driver

Add PM support to azt2320 driver.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-01-03 12:28:21 +01:00
Takashi Iwai
480615f33f [ALSA] als100 - Add PM support
Modules: ALS100 driver

Add PM support to als100 driver.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-01-03 12:28:17 +01:00
Takashi Iwai
6bba41ac97 [ALSA] cs4236 - Use platform_device
Modules: CS4236+ driver

Rewrite the probe/remove with platform_device.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-01-03 12:28:16 +01:00
Takashi Iwai
8b91375736 [ALSA] cs4231 - Use platform_device
Modules: CS4231 driver

Rewrite the probe/remove with platform_device.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-01-03 12:28:15 +01:00
Takashi Iwai
7bb35e20e8 [ALSA] cs4231 - Fix PM support
Modules: CS4231 driver

Fix PM support.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-01-03 12:28:13 +01:00
Takashi Iwai
686688458e [ALSA] ad1848 - Use platform_device, add PM
Modules: AD1848 driver

Rewrite the probe/remove with platform_device.
Add the PM support, too.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
2006-01-03 12:28:11 +01:00