79bd202987
commit a208fa8f33031b9e0aba44c7d1b7e68eb0cbd29e upstream. We need to consistently enforce that keyed hashes cannot be used without setting the key. To do this we need a reliable way to determine whether a given hash algorithm is keyed or not. AF_ALG currently does this by checking for the presence of a ->setkey() method. However, this is actually slightly broken because the CRC-32 algorithms implement ->setkey() but can also be used without a key. (The CRC-32 "key" is not actually a cryptographic key but rather represents the initial state. If not overridden, then a default initial state is used.) Prepare to fix this by introducing a flag CRYPTO_ALG_OPTIONAL_KEY which indicates that the algorithm has a ->setkey() method, but it is not required to be called. Then set it on all the CRC-32 algorithms. The same also applies to the Adler-32 implementation in Lustre. Also, the cryptd and mcryptd templates have to pass through the flag from their underlying algorithm. Change-Id: Ie0547047b828f276d967e8979cd9176e57c99ac8 Signed-off-by: Eric Biggers <ebiggers@google.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> [bwh: Backported to 3.2: - Drop changes to nonexistent drivers - There's no CRYPTO_ALG_INTERNAL flag - Adjust filenames] Signed-off-by: Ben Hutchings <ben@decadent.org.uk> |
||
|---|---|---|
| .. | ||
| Makefile | ||
| ablk_helper.c | ||
| aes-i586-asm_32.S | ||
| aes-x86_64-asm_64.S | ||
| aes_glue.c | ||
| aesni-intel_asm.S | ||
| aesni-intel_glue.c | ||
| blowfish-avx2-asm_64.S | ||
| blowfish-x86_64-asm_64.S | ||
| blowfish_avx2_glue.c | ||
| blowfish_glue.c | ||
| camellia-aesni-avx-asm_64.S | ||
| camellia-aesni-avx2-asm_64.S | ||
| camellia-x86_64-asm_64.S | ||
| camellia_aesni_avx2_glue.c | ||
| camellia_aesni_avx_glue.c | ||
| camellia_glue.c | ||
| cast5-avx-x86_64-asm_64.S | ||
| cast5_avx_glue.c | ||
| cast6-avx-x86_64-asm_64.S | ||
| cast6_avx_glue.c | ||
| crc32-pclmul_asm.S | ||
| crc32-pclmul_glue.c | ||
| crc32c-intel_glue.c | ||
| crc32c-pcl-intel-asm_64.S | ||
| fpu.c | ||
| ghash-clmulni-intel_asm.S | ||
| ghash-clmulni-intel_glue.c | ||
| glue_helper-asm-avx.S | ||
| glue_helper-asm-avx2.S | ||
| glue_helper.c | ||
| salsa20-i586-asm_32.S | ||
| salsa20-x86_64-asm_64.S | ||
| salsa20_glue.c | ||
| serpent-avx-x86_64-asm_64.S | ||
| serpent-avx2-asm_64.S | ||
| serpent-sse2-i586-asm_32.S | ||
| serpent-sse2-x86_64-asm_64.S | ||
| serpent_avx2_glue.c | ||
| serpent_avx_glue.c | ||
| serpent_sse2_glue.c | ||
| sha1_ssse3_asm.S | ||
| sha1_ssse3_glue.c | ||
| sha256-avx-asm.S | ||
| sha256-avx2-asm.S | ||
| sha256-ssse3-asm.S | ||
| sha256_ssse3_glue.c | ||
| sha512-avx-asm.S | ||
| sha512-avx2-asm.S | ||
| sha512-ssse3-asm.S | ||
| sha512_ssse3_glue.c | ||
| twofish-avx-x86_64-asm_64.S | ||
| twofish-avx2-asm_64.S | ||
| twofish-i586-asm_32.S | ||
| twofish-x86_64-asm_64-3way.S | ||
| twofish-x86_64-asm_64.S | ||
| twofish_avx2_glue.c | ||
| twofish_avx_glue.c | ||
| twofish_glue.c | ||
| twofish_glue_3way.c | ||