Linus Torvalds 6c2754c28f Revert "tty: Add a new file /proc/tty/consoles" ... This reverts commit f4a3e0bceb. Jiri Sladby points out that the tty structure we're using may already be gone, and Al Viro doesn't hold back in complaining about the random loading of 'filp->private_data' which doesn't have to be a pointer at all, nor does checking the magic field for TTY_MAGIC prove anything. Belated review by Al: "a) global variable depending on stdin of the last opener? Affecting output of read(2)? Really? b) iterator is broken; list should be locked in ->start(), unlocked in ->stop() and *NOT* unlocked/relocked in ->next() c) ->show() ought to do nothing in case of ->device == NULL, instead of skipping those in ->next()/->start() d) regardless of the merits of the bright idea about asterisk at that line in output *and* regardless of (a), the implementation is not only atrociously ugly, it's actually very likely to be a roothole. Verifying that Cthulhu knows what number happens to be address of a tty_struct by blindly dereferencing memory at that address... Ouch. Please revert that crap." And Christoph pipes in and NAK's the approach of walking fd tables etc too. So it's pretty unanimous. Noticed-by: Jri Slaby <jslaby@suse.cz> Requested-by: Al Viro <viro@zeniv.linux.org.uk> Cc: Greg Kroah-Hartman <gregkh@suse.de> Cc: Werner Fink <werner@suse.de> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk> Cc: Christoph Hellwig <hch@infradead.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2010-10-23 08:14:12 -07:00
..
9p	fs/9p: Don't use dotl version of mknod for dotu inode operations	2010-09-13 08:13:03 -05:00
adfs	Merge branch 'vfs' of git://git.kernel.org/pub/scm/linux/kernel/git/arnd/bkl	2010-10-22 10:52:01 -07:00
affs	Merge branch 'vfs' of git://git.kernel.org/pub/scm/linux/kernel/git/arnd/bkl	2010-10-22 10:52:01 -07:00
afs	Merge branch 'llseek' of git://git.kernel.org/pub/scm/linux/kernel/git/arnd/bkl	2010-10-22 10:52:56 -07:00
autofs	Merge branch 'vfs' of git://git.kernel.org/pub/scm/linux/kernel/git/arnd/bkl	2010-10-22 10:52:01 -07:00
autofs4	Merge branch 'llseek' of git://git.kernel.org/pub/scm/linux/kernel/git/arnd/bkl	2010-10-22 10:52:56 -07:00
befs
bfs	BKL: Remove BKL from BFS	2010-10-04 21:10:35 +02:00
btrfs	Merge branch 'for-2.6.37/barrier' of git://git.kernel.dk/linux-2.6-block	2010-10-22 17:07:18 -07:00
cachefiles	llseek: automatically add .llseek fop	2010-10-15 15:53:27 +02:00
ceph	ceph: do not carry i_lock for readdir from dcache	2010-10-20 15:38:27 -07:00
cifs	Merge git://git.kernel.org/pub/scm/linux/kernel/git/sfrench/cifs-2.6	2010-10-22 17:52:29 -07:00
coda	Merge branch 'llseek' of git://git.kernel.org/pub/scm/linux/kernel/git/arnd/bkl	2010-10-22 10:52:56 -07:00
configfs
cramfs
debugfs	llseek: automatically add .llseek fop	2010-10-15 15:53:27 +02:00
devpts
dlm	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/teigland/dlm	2010-10-22 17:33:16 -07:00
ecryptfs	Merge branch 'llseek' of git://git.kernel.org/pub/scm/linux/kernel/git/arnd/bkl	2010-10-22 10:52:56 -07:00
efs
exofs	exofs: Fix double page_unlock BUG in write_begin/end	2010-10-08 11:26:54 -04:00
exportfs
ext2	BKL: Remove BKL from ext2 filesystem	2010-10-04 21:10:44 +02:00
ext3	Merge branch 'for-2.6.37/barrier' of git://git.kernel.dk/linux-2.6-block	2010-10-22 17:07:18 -07:00
ext4	Merge branch 'for-2.6.37/barrier' of git://git.kernel.dk/linux-2.6-block	2010-10-22 17:07:18 -07:00
fat	Merge branch 'for-2.6.37/barrier' of git://git.kernel.dk/linux-2.6-block	2010-10-22 17:07:18 -07:00
freevxfs	BKL: remove BKL from freevxfs	2010-10-21 18:48:09 +02:00
fscache
fuse	Merge branch 'llseek' of git://git.kernel.org/pub/scm/linux/kernel/git/arnd/bkl	2010-10-22 10:52:56 -07:00
gfs2	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq	2010-10-22 17:13:10 -07:00
hfs	Merge branch 'vfs' of git://git.kernel.org/pub/scm/linux/kernel/git/arnd/bkl	2010-10-22 10:52:01 -07:00
hfsplus	hfsplus: fix getxattr return value	2010-10-15 05:45:00 -07:00
hostfs
hpfs	Merge branch 'vfs' of git://git.kernel.org/pub/scm/linux/kernel/git/arnd/bkl	2010-10-22 10:52:01 -07:00
hppfs	llseek: automatically add .llseek fop	2010-10-15 15:53:27 +02:00
hugetlbfs	llseek: automatically add .llseek fop	2010-10-15 15:53:27 +02:00
isofs	BKL: Remove BKL from isofs	2010-10-04 21:10:45 +02:00
jbd	Merge branch 'for-2.6.37/barrier' of git://git.kernel.dk/linux-2.6-block	2010-10-22 17:07:18 -07:00
jbd2	Merge branch 'for-2.6.37/barrier' of git://git.kernel.dk/linux-2.6-block	2010-10-22 17:07:18 -07:00
jffs2	BKL: Remove BKL from jffs2	2010-10-04 21:10:50 +02:00
jfs	BKL: Remove BKL from JFS	2010-10-04 21:10:40 +02:00
lockd
logfs	llseek: automatically add .llseek fop	2010-10-15 15:53:27 +02:00
minix
ncpfs	ncpfs: Lock socket in ncpfs while setting its callbacks	2010-10-05 11:02:14 +02:00
nfs	Merge branch 'vfs' of git://git.kernel.org/pub/scm/linux/kernel/git/arnd/bkl	2010-10-22 10:52:01 -07:00
nfs_common
nfsd	Merge branch 'llseek' of git://git.kernel.org/pub/scm/linux/kernel/git/arnd/bkl	2010-10-22 10:52:56 -07:00
nilfs2	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ryusuke/nilfs2	2010-10-23 01:26:47 -07:00
nls
notify	Merge branch 'llseek' of git://git.kernel.org/pub/scm/linux/kernel/git/arnd/bkl	2010-10-22 10:52:56 -07:00
ntfs	BKL: Remove BKL from NTFS	2010-10-04 21:10:41 +02:00
ocfs2	ocfs2: drop the BLKDEV_IFL_WAIT flag	2010-10-22 19:30:38 -07:00
omfs
openpromfs
partitions	Merge git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core-2.6	2010-10-22 19:36:42 -07:00
proc	Revert "tty: Add a new file /proc/tty/consoles"	2010-10-23 08:14:12 -07:00
qnx4	BKL: remove BKL from qnx4	2010-10-21 18:48:04 +02:00
quota
ramfs
reiserfs	Merge branch 'v2.6.36-rc8' into for-2.6.37/barrier	2010-10-19 09:13:04 +02:00
romfs	llseek: automatically add .llseek fop	2010-10-15 15:53:27 +02:00
smbfs	Merge branch 'vfs' of git://git.kernel.org/pub/scm/linux/kernel/git/arnd/bkl	2010-10-22 10:52:01 -07:00
squashfs	Merge branch 'llseek' of git://git.kernel.org/pub/scm/linux/kernel/git/arnd/bkl	2010-10-22 10:52:56 -07:00
sysfs	Merge git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core-2.6	2010-10-22 19:36:42 -07:00
sysv
ubifs	Merge branch 'linux-next' of git://git.infradead.org/ubifs-2.6	2010-10-22 16:34:03 -07:00
udf	Merge branch 'vfs' of git://git.kernel.org/pub/scm/linux/kernel/git/arnd/bkl	2010-10-22 10:52:01 -07:00
ufs	Merge branch 'vfs' of git://git.kernel.org/pub/scm/linux/kernel/git/arnd/bkl	2010-10-22 10:52:01 -07:00
xfs	Merge branch 'for-linus' of git://oss.sgi.com/xfs/xfs	2010-10-22 17:32:27 -07:00
aio.c	aio: do not return ERESTARTSYS as a result of AIO	2010-09-22 17:22:39 -07:00
anon_inodes.c
attr.c
bad_inode.c
binfmt_aout.c	Don't dump task struct in a.out core-dumps	2010-10-14 10:57:40 -07:00
binfmt_elf.c	ARM: 6342/1: fix ASLR of PIE executables	2010-10-08 10:02:53 +01:00
binfmt_elf_fdpic.c
binfmt_em86.c
binfmt_flat.c
binfmt_misc.c	llseek: automatically add .llseek fop	2010-10-15 15:53:27 +02:00
binfmt_script.c
binfmt_som.c
bio-integrity.c
bio.c
block_dev.c	block: remove BLKDEV_IFL_WAIT	2010-09-16 20:52:58 +02:00
buffer.c
char_dev.c	Merge branch 'llseek' of git://git.kernel.org/pub/scm/linux/kernel/git/arnd/bkl	2010-10-22 10:52:56 -07:00
compat.c	Prevent freeing uninitialized pointer in compat_do_readv_writev	2010-09-22 17:22:38 -07:00
compat_binfmt_elf.c
compat_ioctl.c	fix rawctl compat ioctls breakage on amd64 and itanic	2010-10-19 11:29:54 +02:00
dcache.c
dcookies.c
direct-io.c
drop_caches.c
eventfd.c	llseek: automatically add .llseek fop	2010-10-15 15:53:27 +02:00
eventpoll.c	llseek: automatically add .llseek fop	2010-10-15 15:53:27 +02:00
exec.c	Export dump_{write,seek} to binary loader modules	2010-10-14 19:15:28 -07:00
fcntl.c
fifo.c	llseek: automatically add .llseek fop	2010-10-15 15:53:27 +02:00
file.c
file_table.c
filesystems.c
fs-writeback.c	writeback: always use sb->s_bdi for writeback purposes	2010-10-04 14:25:33 +02:00
fs_struct.c
generic_acl.c
inode.c
internal.h
ioctl.c
ioprio.c
Kconfig	BKL: introduce CONFIG_BKL.	2010-10-21 15:44:13 +02:00
Kconfig.binfmt
libfs.c
locks.c	fs/locks.c: prepare for BKL removal	2010-10-05 11:02:04 +02:00
Makefile
mbcache.c
mpage.c
namei.c
namespace.c	BKL: Remove BKL from do_new_mount()	2010-10-04 21:10:43 +02:00
nfsctl.c
no-block.c	llseek: automatically add .llseek fop	2010-10-15 15:53:27 +02:00
open.c
pipe.c	pipe: fix failure to return error code on ->confirm()	2010-10-21 14:56:33 +02:00
pnode.c
pnode.h
posix_acl.c
read_write.c	vfs: make no_llseek the default	2010-10-15 15:53:46 +02:00
read_write.h
readdir.c
select.c
seq_file.c
signalfd.c	llseek: automatically add .llseek fop	2010-10-15 15:53:27 +02:00
splice.c
stack.c
stat.c
statfs.c
super.c
sync.c
timerfd.c	llseek: automatically add .llseek fop	2010-10-15 15:53:27 +02:00
utimes.c
xattr.c
xattr_acl.c