Eric Dumazet 2037ffd53c ipv6: sit: better validate user provided tunnel names ... commit b95211e066fc3494b7c115060b2297b4ba21f025 upstream. Use dev_valid_name() to make sure user does not provide illegal device name. syzbot caught the following bug : BUG: KASAN: stack-out-of-bounds in strlcpy include/linux/string.h:300 [inline] BUG: KASAN: stack-out-of-bounds in ipip6_tunnel_locate+0x63b/0xaa0 net/ipv6/sit.c:254 Write of size 33 at addr ffff8801b64076d8 by task syzkaller932654/4453 CPU: 0 PID: 4453 Comm: syzkaller932654 Not tainted 4.16.0+ #1 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:17 [inline] dump_stack+0x1b9/0x29f lib/dump_stack.c:53 print_address_description+0x6c/0x20b mm/kasan/report.c:256 kasan_report_error mm/kasan/report.c:354 [inline] kasan_report.cold.7+0xac/0x2f5 mm/kasan/report.c:412 check_memory_region_inline mm/kasan/kasan.c:260 [inline] check_memory_region+0x13e/0x1b0 mm/kasan/kasan.c:267 memcpy+0x37/0x50 mm/kasan/kasan.c:303 strlcpy include/linux/string.h:300 [inline] ipip6_tunnel_locate+0x63b/0xaa0 net/ipv6/sit.c:254 ipip6_tunnel_ioctl+0xe71/0x241b net/ipv6/sit.c:1221 dev_ifsioc+0x43e/0xb90 net/core/dev_ioctl.c:334 dev_ioctl+0x69a/0xcc0 net/core/dev_ioctl.c:525 sock_ioctl+0x47e/0x680 net/socket.c:1015 vfs_ioctl fs/ioctl.c:46 [inline] file_ioctl fs/ioctl.c:500 [inline] do_vfs_ioctl+0x1cf/0x1650 fs/ioctl.c:684 ksys_ioctl+0xa9/0xd0 fs/ioctl.c:701 SYSC_ioctl fs/ioctl.c:708 [inline] SyS_ioctl+0x24/0x30 fs/ioctl.c:706 do_syscall_64+0x29e/0x9d0 arch/x86/entry/common.c:287 entry_SYSCALL_64_after_hwframe+0x42/0xb7 Fixes: 1da177e4c3 ("Linux-2.6.12-rc2") Signed-off-by: Eric Dumazet <edumazet@google.com> Reported-by: syzbot <syzkaller@googlegroups.com> Signed-off-by: David S. Miller <davem@davemloft.net> [bwh: Backported to 3.16: adjust context] Signed-off-by: Ben Hutchings <ben@decadent.org.uk>		2019-07-27 21:52:03 +02:00
..
9p	…
802	…
8021q	…
appletalk	…
atm	…
ax25	…
batman-adv	…
bluetooth	Bluetooth: hidp: Fix handling of strncpy for hid->name information	2019-07-27 21:51:39 +02:00
bridge	netfilter: bridge: ebt_among: add more missing match size checks	2019-07-27 21:49:26 +02:00
caif	…
can	…
ceph	…
core	neighbour: confirm neigh entries when ARP packet is received	2019-07-27 21:51:56 +02:00
dcb	…
dccp	dccp: check sk for closed state in dccp_sendmsg()	2019-07-27 21:49:52 +02:00
decnet	…
dns_resolver	…
dsa	…
ethernet	…
ieee802154	…
ipc_router	net: ipc_router: Fix buffer overflow during memcpy	2019-07-27 21:51:21 +02:00
ipv4	ip_tunnel: better validate user provided tunnel names	2019-07-27 21:52:03 +02:00
ipv6	ipv6: sit: better validate user provided tunnel names	2019-07-27 21:52:03 +02:00
ipx	ipx: call ipxitf_put() in ioctl error path	2018-01-21 21:05:49 -08:00
irda	…
iucv	…
key	af_key: fix buffer overread in parse_exthdrs()	2019-07-27 21:46:23 +02:00
l2tp	l2tp: use sk_dst_check() to avoid race on sk->sk_dst_cache	2019-07-27 21:51:14 +02:00
lapb	…
llc	…
mac80211	mac80211: use constant time comparison with keys	2019-07-27 21:45:47 +02:00
mac802154	…
netfilter	BACKPORT: ANDROID: Use sk_uid to replace uid get from socket file	2019-07-27 21:51:34 +02:00
netlabel	netlabel: add address family checks to netlbl_{sock,req}_delattr()	2019-07-27 21:41:59 +02:00
netlink	BACKPORT: netlink: add a start callback for starting a netlink dump	2019-07-27 21:51:36 +02:00
netrom	…
nfc	NFC: llcp: Limit size of SDP URI	2019-07-27 21:51:24 +02:00
openvswitch	…
packet	packet: refine ring v3 block size test to hold one frame	2019-07-27 21:51:14 +02:00
phonet	…
rds	…
rfkill	net: rfkill: Do not ignore errors from regulator_enable()	2019-07-27 21:42:01 +02:00
rmnet_data	net: rmnet_data: Change the log level for unknown IOCTL's	2019-07-27 21:51:01 +02:00
rose	…
rxrpc	rxrpc: Fix several cases where a padded len isn't checked in ticket decode	2019-07-27 21:44:13 +02:00
sched	sch_fq_codel: avoid double free on init failure	2019-07-27 21:45:13 +02:00
sctp	sctp: fix a type cast warnings that causes a_rwnd gets the wrong value	2019-07-27 21:45:39 +02:00
sunrpc	kernel: make groups_sort calling a responsibility group_info allocators	2019-07-27 21:46:18 +02:00
tipc	…
unix	net/unix: don't show information about sockets from other namespaces	2019-07-27 21:45:50 +02:00
vmw_vsock	…
wimax	…
wireless	cfg80211: nl80211_update_ft_ies() to validate NL80211_ATTR_IE	2019-07-27 21:51:54 +02:00
x25	…
xfrm	xfrm: fix 'passing zero to ERR_PTR()' warning	2019-07-27 21:51:39 +02:00
Kconfig	…
Makefile	…
activity_stats.c	…
compat.c	net: support compat 64-bit time in {s,g}etsockopt	2019-07-27 21:49:09 +02:00
nonet.c	…
socket.c	UPSTREAM: net: socket: Make unnecessarily global sockfs_setattr() static	2019-07-27 21:51:01 +02:00
sysctl_net.c	…